From patchwork Thu Mar 1 19:42:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 130408 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp451139lja; Thu, 1 Mar 2018 11:43:06 -0800 (PST) X-Google-Smtp-Source: AG47ELs1JDrYnKdcQR9JieOQfcCbXR9RLIdOkboCfca3I8oq0EjBvO/34d92wzUHu85qKU4p7Fvl X-Received: by 10.223.153.51 with SMTP id x48mr2683639wrb.216.1519933386879; Thu, 01 Mar 2018 11:43:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519933386; cv=none; d=google.com; s=arc-20160816; b=044FK+85Udz55Gh50MV4Jot4S4nY8RB3xjF0UuTO5CJrjK2XbS3PRZ90okUUyxmUbO 5y45lhuTS5TJASM6cMX0mddgSL2QPgi2/BpzUucpFOwjzqVmxLry+7rXDQWxO0iYd/Nq 7Rrlez3OArMSM1wFJGJvlPcACd7nGzTe9KxBHOoFNAPHTWMOr494YHAr+Mu6lk7gZqKN DP4Is3K4VkUFQxerc0xv9L4liH3cdu2JvVDiRMGhaB8PnWiZ0grodDdWTgUhkVP/Dcqm 9GeH/a78cbLg+hM2M4AbRy8iz4z42TZ35w/+sHW9bQUVo+9H07h/DROR49asOOH0Ywo4 CFIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:mime-version:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:cc:date :message-id:in-reply-to:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=hBOm3XFvHkGXj2WdY8jhDR8A/Ymn/PBUCmwHhGLqkf4=; b=P8qGVb2IK5H9MlnZUZL7eU3kWLChhHeaI72teGjyyQHst4TgdzCVTn/xKJ6J9enWF5 y2jRd9wcBnwsSPonEBy3wXzuOR9oS1Dv2e8ZR5hsK8RDNsHmRqq8DvpFFrmSW6DBgdwo P4W5sVr0IQwMneKzPrphC53061jM6vidyAtXLONFrzFDj+HWGdYeqV9BCX3kKbRzYx2+ cV6DzHI3cb6iCZfjTTD9sgp6xBAByAzEh5AebfOYvlYo8voJfDYOEQWIz9BIrEvyD9ob jMB9xgfSabOBUHdYLSNs6RN6BHbieVpeF6NzKUIcLXpae5IWs+Zbm/T30k8Cls0kmPu9 5bEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=d1TmjyFJ; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id l18si3020855wmc.229.2018.03.01.11.43.06; Thu, 01 Mar 2018 11:43:06 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=d1TmjyFJ; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id C1AD7267BED; Thu, 1 Mar 2018 20:42:35 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 8C7AF267BDD; Thu, 1 Mar 2018 20:42:28 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 177D0267BD0 for ; Thu, 1 Mar 2018 20:42:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=3Z+XlMeozmlkF1N2wmSf5Tj2WhwwCZ7Wh+Wd7kA++jQ=; b=d1TmjyFJgGMg EAhVpU4KrlVd4EZe0r5rVicmMTngrwDLJ8aLSIbilhWm4oK//E9I0DBjZJaU4y8TgnPL9of3Pm8s0 maD3fCy4b6PkRDIFhyZ9/1iRsL9GtPfWJ38UlDiAxhGTMgI64a/edGATDvOKxAcvguhVEtia1ZMcT PFZcg=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1erU5x-0005ng-73; Thu, 01 Mar 2018 19:42:25 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1erU5w-0003TE-P2; Thu, 01 Mar 2018 19:42:24 +0000 From: Mark Brown To: Geert Uytterhoeven In-Reply-To: Message-Id: Date: Thu, 01 Mar 2018 19:42:24 +0000 Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: rt5514: Fix rt5514_spi_burst_read() buffer passing" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: rt5514: Fix rt5514_spi_burst_read() buffer passing has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 29838a5c1e77ed93d41fb9837390e243b9b73518 Mon Sep 17 00:00:00 2001 From: Geert Uytterhoeven Date: Tue, 30 Jan 2018 14:19:42 +0100 Subject: [PATCH] ASoC: rt5514: Fix rt5514_spi_burst_read() buffer passing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit rt5514_dsp_voice_wake_up_put() passes "(u8 *)&buf" to rt5514_spi_burst_read(), where the cast is needed to silence a compiler warning: sound/soc/codecs/rt5514.c: In function ‘rt5514_dsp_voice_wake_up_put’: sound/soc/codecs/rt5514.c:357: warning: passing argument 2 of ‘rt5514_spi_burst_read’ from incompatible pointer type However, as the variable is declared as an array ("u8 buf[8]"), the function should just pass "buf" instead. Fixes: fc9cab05837639ce ("ASoC: rt5514: The DSP clock can be calibrated by the other clock source") Signed-off-by: Geert Uytterhoeven Signed-off-by: Mark Brown --- sound/soc/codecs/rt5514.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.16.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/rt5514.c b/sound/soc/codecs/rt5514.c index 2d79571098ac..b358704ee19c 100644 --- a/sound/soc/codecs/rt5514.c +++ b/sound/soc/codecs/rt5514.c @@ -353,8 +353,7 @@ static int rt5514_dsp_voice_wake_up_put(struct snd_kcontrol *kcontrol, msleep(20); #if IS_ENABLED(CONFIG_SND_SOC_RT5514_SPI) rt5514_spi_burst_read(RT5514_PLL3_CALIB_CTRL6 | - RT5514_DSP_MAPPING, - (u8 *)&buf, sizeof(buf)); + RT5514_DSP_MAPPING, buf, sizeof(buf)); #else dev_err(component->dev, "There is no SPI driver for" " loading the firmware\n");