From patchwork Wed Mar 7 14:13:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 130898 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp5232573lja; Wed, 7 Mar 2018 06:14:22 -0800 (PST) X-Google-Smtp-Source: AG47ELvGltDpIXHYcUcy2rvzLCnjrZZf3ZoHn0OBeLjM08zmweyTS3zMpxGDC1ISyjQCxi2mjInI X-Received: by 10.28.236.154 with SMTP id h26mr5608338wmi.77.1520432062809; Wed, 07 Mar 2018 06:14:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520432062; cv=none; d=google.com; s=arc-20160816; b=nMj8LT3roztT1/p8lnvo+FNvpgtRaljeOy7OOBQ+CFbgFfYrOT1vIH9xHSXu1J/ALk BP1kyTZUEtfEvbtdqmBFBV/GLcdE4Su34XpuM8l+0pFMABVHcQt8feVLE4Zp7mFrRQ+R 1zjtG41UjkSTS3FsB1VBTvyXAVIHL3SDBL4HzP2ux/8sUI5XFHeSdealX6F0OMVV8plf /O4AiF+kkG+ZWWhBz2z76t+p5fkMcUw72gDsZETZPWXf4yjyYNVObx7DOLDC4iVwfMJA UFH+yuFOfkCwsMJe+kige11eQNdoDGOHGXpkDOwAb2kRqXaFRceqiKLRKrm8brMSpboK l7QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=YocQUGJ5y5R/TGcapir9CzFU8okvFZ+cpD/Fx7ke5dI=; b=v5fGg5xg8Ff43yAI1oM3hoLtUoiD/MqhnXZFhRxfTtLLo5awzJUE1ZlR5PHbFHqdbA PmRRBhUfNMdJ9RJL6YPbpH8KExJd0Fp7pDKnaIFOShmz/+Uh/x3mQBMD05GFDP6UToxm hjgQ5QnTbqKiMjIinxgzk4magpvVAJK/iUew7Fy2JT499BBx9df8JYY/AAtCGrdk7S1U dx/vNgYLQeJ/YuDU6xOB4Fpt8ReS1Al7KF58bBUjcmCV5Zd5BZWINoHTuAtywbdBWT7I 7uuZU+YUYXy6NIXFvkPlX1A7ybok7AJTuONr9K11zVLBmQhgersPTchJbYKV9zhF6Lbr Jg2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=jwh4M1rM; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id c24si13536131wra.352.2018.03.07.06.14.22; Wed, 07 Mar 2018 06:14:22 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=jwh4M1rM; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id BD7F42673C7; Wed, 7 Mar 2018 15:14:04 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 352AB2673D2; Wed, 7 Mar 2018 15:14:02 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 8E17E2673CC for ; Wed, 7 Mar 2018 15:14:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=Lb/8FkA0ZAcwM8vSFHMWgseY7zXIsWEXgJrBhaB8a0k=; b=jwh4M1rMxIDX 8ti7QYx4/eudrpZKO6TqyU6Ca4yCibFAgr9z4TPOqThFrj5B6MD6QjkMocpkXvA7v3rgDWuekMQ8k ZPhptdGjTjE0s2/vpvTv2M43JYZiagyQQJRaD2eO7WhIufxx4X9aUvYOnCATYHJc1d5mmeegvHhjX BCTTo=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1etZpL-0000Ac-T4; Wed, 07 Mar 2018 14:13:55 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1etZpL-0001Of-Ec; Wed, 07 Mar 2018 14:13:55 +0000 From: Mark Brown To: Hans de Goede In-Reply-To: <20180225104713.4745-20-hdegoede@redhat.com> Message-Id: Date: Wed, 07 Mar 2018 14:13:55 +0000 Cc: Oder Chiou , alsa-devel@alsa-project.org, Pierre-Louis Bossart , Takashi Iwai , Mark Brown , Carlo Caione , Bard Liao Subject: [alsa-devel] Applied "ASoC: rt5651: Enable Platform Clock during jack-type detect" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: rt5651: Enable Platform Clock during jack-type detect has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 4b4a373c0212e084045530e47071374a87a3761e Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Sun, 4 Mar 2018 15:35:55 +0100 Subject: [PATCH] ASoC: rt5651: Enable Platform Clock during jack-type detect When using RCCLK instead of MCLK / PLL1 the OVCD status often gets stuck at its last value, which breaks jack-type detection. This commit fixes this by force-enabling the platform clock when doing jack-type detection. Tested-by: Carlo Caione Signed-off-by: Hans de Goede Signed-off-by: Mark Brown --- sound/soc/codecs/rt5651.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.16.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c index 62918f7e8270..873af6798d7a 100644 --- a/sound/soc/codecs/rt5651.c +++ b/sound/soc/codecs/rt5651.c @@ -1563,6 +1563,8 @@ static void rt5651_enable_micbias1_for_ovcd(struct snd_soc_component *component) snd_soc_dapm_mutex_lock(dapm); snd_soc_dapm_force_enable_pin_unlocked(dapm, "LDO"); snd_soc_dapm_force_enable_pin_unlocked(dapm, "micbias1"); + /* OVCD is unreliable when used with RCCLK as sysclk-source */ + snd_soc_dapm_force_enable_pin_unlocked(dapm, "Platform Clock"); snd_soc_dapm_sync_unlocked(dapm); snd_soc_dapm_mutex_unlock(dapm); } @@ -1572,6 +1574,7 @@ static void rt5651_disable_micbias1_for_ovcd(struct snd_soc_component *component struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component); snd_soc_dapm_mutex_lock(dapm); + snd_soc_dapm_disable_pin_unlocked(dapm, "Platform Clock"); snd_soc_dapm_disable_pin_unlocked(dapm, "micbias1"); snd_soc_dapm_disable_pin_unlocked(dapm, "LDO"); snd_soc_dapm_sync_unlocked(dapm);