| Message ID | 1397481367-12652-4-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hi Sachin, On Mon, Apr 14, 2014 at 6:16 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > From: Doug Anderson <dianders@chromium.org> > > Added nodes for ptn3460 driver to Snow board. > > Signed-off-by: Doug Anderson <dianders@chromium.org> > Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> I'm curious, how are you testing this code on the upstream kernel before you post the patches? Especially since Doug was referring to some of these containing parts that is needed for drivers that are not yet upstreamed. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Sachin, On Mon, Apr 14, 2014 at 6:16 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > From: Doug Anderson <dianders@chromium.org> For this patch in particular giving me authorship is pretty tenuous. I don't think I was even the author of the majority of the code in the chromium tree. > Added nodes for ptn3460 driver to Snow board. > > Signed-off-by: Doug Anderson <dianders@chromium.org> > Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > arch/arm/boot/dts/exynos5250-snow.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) I don't see any problems here but really the graphics people are the ones that should be commenting. Added a few folks to the CC list. For the general GPIOs / pinctrl stuff, though: Reviewed-by: Doug Anderson <dianders@chromium.org> ...and as Olof points out, please let us know how this was all tested. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Tue, Apr 15, 2014 at 4:24 AM, Olof Johansson <olof@lixom.net> wrote: > Hi Sachin, > > On Mon, Apr 14, 2014 at 6:16 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: >> From: Doug Anderson <dianders@chromium.org> >> >> Added nodes for ptn3460 driver to Snow board. >> >> Signed-off-by: Doug Anderson <dianders@chromium.org> >> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > I'm curious, how are you testing this code on the upstream kernel > before you post the patches? > > Especially since Doug was referring to some of these containing parts > that is needed for drivers that are not yet upstreamed. Its better to ignore this patch as of now, since discussion is still going on, at http://www.spinics.net/lists/dri-devel/msg58474.html I guess we will have few more DT bindings. Once it is finalized, I shall resend this again. Regards, Ajay Kumar -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/30/14 22:03, Ajay kumar wrote: > Hi, > Hi, > On Tue, Apr 15, 2014 at 4:24 AM, Olof Johansson<olof@lixom.net> wrote: >> Hi Sachin, >> >> On Mon, Apr 14, 2014 at 6:16 AM, Sachin Kamat<sachin.kamat@linaro.org> wrote: >>> From: Doug Anderson<dianders@chromium.org> >>> >>> Added nodes for ptn3460 driver to Snow board. >>> >>> Signed-off-by: Doug Anderson<dianders@chromium.org> >>> Signed-off-by: Ajay Kumar<ajaykumar.rs@samsung.com> >>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org> >> >> I'm curious, how are you testing this code on the upstream kernel >> before you post the patches? >> >> Especially since Doug was referring to some of these containing parts >> that is needed for drivers that are not yet upstreamed. > > Its better to ignore this patch as of now, since discussion is still going > on, at http://www.spinics.net/lists/dri-devel/msg58474.html > I guess we will have few more DT bindings. Once it is finalized, > I shall resend this again. > This means this whole series? Can you please re-spin as soon as possible if you want to see this series in 3.16? Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Kukjin, On Thu, May 15, 2014 at 12:38 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > On 04/30/14 22:03, Ajay kumar wrote: >> >> Hi, >> > Hi, > >> On Tue, Apr 15, 2014 at 4:24 AM, Olof Johansson<olof@lixom.net> wrote: >>> >>> Hi Sachin, >>> >>> On Mon, Apr 14, 2014 at 6:16 AM, Sachin Kamat<sachin.kamat@linaro.org> >>> wrote: >>>> >>>> From: Doug Anderson<dianders@chromium.org> >>>> >>>> Added nodes for ptn3460 driver to Snow board. >>>> >>>> Signed-off-by: Doug Anderson<dianders@chromium.org> >>>> Signed-off-by: Ajay Kumar<ajaykumar.rs@samsung.com> >>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org> >>> >>> >>> I'm curious, how are you testing this code on the upstream kernel >>> before you post the patches? >>> >>> Especially since Doug was referring to some of these containing parts >>> that is needed for drivers that are not yet upstreamed. >> >> >> Its better to ignore this patch as of now, since discussion is still going >> on, at http://www.spinics.net/lists/dri-devel/msg58474.html >> I guess we will have few more DT bindings. Once it is finalized, >> I shall resend this again. >> > This means this whole series? I think you can land everything except the last patch. The tps65090 charger portion of the MFD will fail to probe (assuming it is configured) since we're still waiting for a review on <https://patchwork.kernel.org/patch/4042741/>. ...but it doesn't hurt to take the device tree part. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/16/14 04:50, Doug Anderson wrote: > Kukjin, > Hi Doug, > On Thu, May 15, 2014 at 12:38 PM, Kukjin Kim<kgene.kim@samsung.com> wrote: >> On 04/30/14 22:03, Ajay kumar wrote: >>> >>> Hi, >>> >> Hi, >> >>> On Tue, Apr 15, 2014 at 4:24 AM, Olof Johansson<olof@lixom.net> wrote: >>>> >>>> Hi Sachin, >>>> >>>> On Mon, Apr 14, 2014 at 6:16 AM, Sachin Kamat<sachin.kamat@linaro.org> >>>> wrote: >>>>> >>>>> From: Doug Anderson<dianders@chromium.org> >>>>> >>>>> Added nodes for ptn3460 driver to Snow board. >>>>> >>>>> Signed-off-by: Doug Anderson<dianders@chromium.org> >>>>> Signed-off-by: Ajay Kumar<ajaykumar.rs@samsung.com> >>>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org> >>>> >>>> >>>> I'm curious, how are you testing this code on the upstream kernel >>>> before you post the patches? >>>> >>>> Especially since Doug was referring to some of these containing parts >>>> that is needed for drivers that are not yet upstreamed. >>> >>> >>> Its better to ignore this patch as of now, since discussion is still going >>> on, at http://www.spinics.net/lists/dri-devel/msg58474.html >>> I guess we will have few more DT bindings. Once it is finalized, >>> I shall resend this again. >>> >> This means this whole series? > > I think you can land everything except the last patch. > OK. > The tps65090 charger portion of the MFD will fail to probe (assuming > it is configured) since we're still waiting for a review on > <https://patchwork.kernel.org/patch/4042741/>. ...but it doesn't hurt > to take the device tree part. > Good. Thanks for your confirmation. Will apply 1 to 3 with Tomasz Figa's reviewed tag. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 5/16/14, Doug Anderson <dianders@chromium.org> wrote: > Kukjin, > > On Thu, May 15, 2014 at 12:38 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: >> On 04/30/14 22:03, Ajay kumar wrote: >>> >>> Hi, >>> >> Hi, >> >>> On Tue, Apr 15, 2014 at 4:24 AM, Olof Johansson<olof@lixom.net> wrote: >>>> >>>> Hi Sachin, >>>> >>>> On Mon, Apr 14, 2014 at 6:16 AM, Sachin Kamat<sachin.kamat@linaro.org> >>>> wrote: >>>>> >>>>> From: Doug Anderson<dianders@chromium.org> >>>>> >>>>> Added nodes for ptn3460 driver to Snow board. >>>>> >>>>> Signed-off-by: Doug Anderson<dianders@chromium.org> >>>>> Signed-off-by: Ajay Kumar<ajaykumar.rs@samsung.com> >>>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org> >>>> >>>> >>>> I'm curious, how are you testing this code on the upstream kernel >>>> before you post the patches? >>>> >>>> Especially since Doug was referring to some of these containing parts >>>> that is needed for drivers that are not yet upstreamed. >>> >>> >>> Its better to ignore this patch as of now, since discussion is still >>> going >>> on, at http://www.spinics.net/lists/dri-devel/msg58474.html >>> I guess we will have few more DT bindings. Once it is finalized, >>> I shall resend this again. >>> >> This means this whole series? > > I think you can land everything except the last patch. I think you can take this ptn3460 DT patch also. Because, ptn3460 driver is already present in Inki's tree. Its true that the driver may need some changes, the discussions are still going on, and if we need to add a new DT binding, I will send that change as a seperate patch sometime down the line. As of now, this can go in (but I am sure we won't get the display until we keep FET1 and FET6 "always on" for snow) Ajay > The tps65090 charger portion of the MFD will fail to probe (assuming > it is configured) since we're still waiting for a review on > <https://patchwork.kernel.org/patch/4042741/>. ...but it doesn't hurt > to take the device tree part. > > -Doug > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index a38fd18..52ae335 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -32,6 +32,13 @@ samsung,pin-drv = <0>; }; + ptn3460_gpios: ptn3460-gpios { + samsung,pins = "gpy2-5", "gpx1-5"; + samsung,pin-function = <1>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + sd3_clk: sd3-clk { samsung,pin-drv = <0>; }; @@ -324,4 +331,16 @@ clock-frequency = <24000000>; }; }; + + i2c_7: i2c@12CD0000 { + ptn3460-bridge@20 { + compatible = "nxp,ptn3460"; + reg = <0x20>; + powerdown-gpio = <&gpy2 5 0>; + reset-gpio = <&gpx1 5 0>; + edid-emulation = <5>; + pinctrl-names = "default"; + pinctrl-0 = <&ptn3460_gpios>; + }; + }; };