| Message ID | dd11b4d47ab566931cb943dea34e67c1ce2c3e59.1351530856.git.viresh.kumar@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On 29 October 2012 22:47, Viresh Kumar <viresh.kumar@linaro.org> wrote: > This patch is an attempt to fix following compilation warning. > > In file included from drivers/mtd/chips/cfi_cmdset_0001.c:35:0: > drivers/mtd/chips/cfi_cmdset_0001.c: In function 'cfi_intelext_write_words': > include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function [-Wmaybe-uninitialized] > > I could have used uninitialized_var() too, but didn't used it as the final else > part of map_word_load() is missing. So there is a chance that it might be passed > uninitialized. Better initialize to zero. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Ping!!
On Mon, 2012-10-29 at 22:47 +0530, Viresh Kumar wrote: > This patch is an attempt to fix following compilation warning. > > In file included from drivers/mtd/chips/cfi_cmdset_0001.c:35:0: > drivers/mtd/chips/cfi_cmdset_0001.c: In function 'cfi_intelext_write_words': > include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function [-Wmaybe-uninitialized] > > I could have used uninitialized_var() too, but didn't used it as the final else > part of map_word_load() is missing. So there is a chance that it might be passed > uninitialized. Better initialize to zero. Pushed to l2-mtd.git, thanks!
diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h index 3595a02..56c7936 100644 --- a/include/linux/mtd/map.h +++ b/include/linux/mtd/map.h @@ -328,7 +328,7 @@ static inline int map_word_bitsset(struct map_info *map, map_word val1, map_word static inline map_word map_word_load(struct map_info *map, const void *ptr) { - map_word r; + map_word r = {{0} }; if (map_bankwidth_is_1(map)) r.x[0] = *(unsigned char *)ptr;
This patch is an attempt to fix following compilation warning. In file included from drivers/mtd/chips/cfi_cmdset_0001.c:35:0: drivers/mtd/chips/cfi_cmdset_0001.c: In function 'cfi_intelext_write_words': include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function [-Wmaybe-uninitialized] I could have used uninitialized_var() too, but didn't used it as the final else part of map_word_load() is missing. So there is a chance that it might be passed uninitialized. Better initialize to zero. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- include/linux/mtd/map.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)