diff mbox

[API-NEXT,PATCHv1,1/4] api: classification: queue and drop policy API name change

Message ID 1439210472-15839-2-git-send-email-bala.manoharan@linaro.org
State Superseded
Headers show

Commit Message

Balasubramanian Manoharan Aug. 10, 2015, 12:41 p.m. UTC
changes the name of classification APIs for ODP consistency
odp_cos_set_queue() is changed to odp_cos_queue_set()
odp_cos_set_drop() is changed to odp_cos_drop_set()

Adds the following getter functions
odp_cos_queue()
odp_cos_drop()

Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
---
 include/odp/api/classification.h | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

Comments

Mike Holmes Aug. 10, 2015, 1:24 p.m. UTC | #1
Patch does not list that it fixes
https://bugs.linaro.org/show_bug.cgi?id=1711

On 10 August 2015 at 08:41, Balasubramanian Manoharan <
bala.manoharan@linaro.org> wrote:

> changes the name of classification APIs for ODP consistency
> odp_cos_set_queue() is changed to odp_cos_queue_set()
> odp_cos_set_drop() is changed to odp_cos_drop_set()
>
> Adds the following getter functions
> odp_cos_queue()
> odp_cos_drop()
>
> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
> ---
>  include/odp/api/classification.h | 26 ++++++++++++++++++++++++--
>  1 file changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/include/odp/api/classification.h
> b/include/odp/api/classification.h
> index f597b26..2fdb767 100644
> --- a/include/odp/api/classification.h
> +++ b/include/odp/api/classification.h
> @@ -120,7 +120,19 @@ int odp_cos_destroy(odp_cos_t cos_id);
>   * @retval                     0 on success
>   * @retval                     <0 on failure
>   */
> -int odp_cos_set_queue(odp_cos_t cos_id, odp_queue_t queue_id);
> +int odp_cos_queue_set(odp_cos_t cos_id, odp_queue_t queue_id);
> +
> +/**
> +* Get the queue associated with the specific class-of-service
> +*
> +* @param[in]   cos_id                  class-of-service instance.
> +*
> +* @retval      queue_handle            Queue handle associated with the
> +*                                      given class-of-service
> +*
> +* @retval      ODP_QUEUE_INVALID       on failure
> +*/
> +odp_queue_t odp_cos_queue(odp_cos_t cos_id);
>
>  /**
>   * Assign packet drop policy for specific class-of-service
> @@ -133,7 +145,17 @@ int odp_cos_set_queue(odp_cos_t cos_id, odp_queue_t
> queue_id);
>   *
>   * @note Optional.
>   */
> -int odp_cos_set_drop(odp_cos_t cos_id, odp_drop_e drop_policy);
> +int odp_cos_drop_set(odp_cos_t cos_id, odp_drop_e drop_policy);
> +
> +/**
> +* Get the drop policy configured for a specific class-of-service instance.
> +*
> +* @param[in]   cos_id          class-of-service instance.
> +*
> +* @retval                      Drop policy configured with the given
> +*                              class-of-service
> +*/
> +odp_drop_e odp_cos_drop(odp_cos_t cos_id);
>
>  /**
>   * Request to override per-port class of service
> --
> 1.9.1
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
diff mbox

Patch

diff --git a/include/odp/api/classification.h b/include/odp/api/classification.h
index f597b26..2fdb767 100644
--- a/include/odp/api/classification.h
+++ b/include/odp/api/classification.h
@@ -120,7 +120,19 @@  int odp_cos_destroy(odp_cos_t cos_id);
  * @retval			0 on success
  * @retval			<0 on failure
  */
-int odp_cos_set_queue(odp_cos_t cos_id, odp_queue_t queue_id);
+int odp_cos_queue_set(odp_cos_t cos_id, odp_queue_t queue_id);
+
+/**
+* Get the queue associated with the specific class-of-service
+*
+* @param[in]	cos_id			class-of-service instance.
+*
+* @retval	queue_handle		Queue handle associated with the
+*					given class-of-service
+*
+* @retval	ODP_QUEUE_INVALID	on failure
+*/
+odp_queue_t odp_cos_queue(odp_cos_t cos_id);
 
 /**
  * Assign packet drop policy for specific class-of-service
@@ -133,7 +145,17 @@  int odp_cos_set_queue(odp_cos_t cos_id, odp_queue_t queue_id);
  *
  * @note Optional.
  */
-int odp_cos_set_drop(odp_cos_t cos_id, odp_drop_e drop_policy);
+int odp_cos_drop_set(odp_cos_t cos_id, odp_drop_e drop_policy);
+
+/**
+* Get the drop policy configured for a specific class-of-service instance.
+*
+* @param[in]	cos_id		class-of-service instance.
+*
+* @retval			Drop policy configured with the given
+*				class-of-service
+*/
+odp_drop_e odp_cos_drop(odp_cos_t cos_id);
 
 /**
  * Request to override per-port class of service