diff mbox

"make check" runs tests twice

Message ID 55CA37A7.50701@linaro.org
State New
Headers show

Commit Message

Zoltan Kiss Aug. 11, 2015, 5:57 p.m. UTC 
On 10/08/15 15:51, Zoltan Kiss wrote:
> Hi,
>
> I've noticed that in ODP-DPDK "make check" runs the tests twice. I think
> it's because of the Makefile.am we get from linux-generic:
>
> #@with_platform@ works alone in subdir but not as part of a path???
> SUBDIRS = @platform_with_platform@ \
>        helper \
>        test \
>        @platform_with_platform_test@ \
>        helper/test \
>        doc \
>        example \
>        scripts
>
> So "make check" will run in @platform_with_platform@ and
> @platform_with_platform_test@, and the former will also go into test to
> run the tests. I think it's not necessary, can we do anything to avoid
> this double run?

this bit will sort it out:




> I've just ran make check on latest odp.git, and it doesn't seem to run
> the testcases at all, am I the only one seeing that problem?
This last bit was my issue, I forgot to configure them.


>
> Regards,
>
> Zoltan

Comments

Maxim Uvarov Aug. 12, 2015, 9:06 a.m. UTC | #1 
On 08/11/15 20:57, Zoltan Kiss wrote:
>
>
> On 10/08/15 15:51, Zoltan Kiss wrote:
>> Hi,
>>
>> I've noticed that in ODP-DPDK "make check" runs the tests twice. I think
>> it's because of the Makefile.am we get from linux-generic:
>>
>> #@with_platform@ works alone in subdir but not as part of a path???
>> SUBDIRS = @platform_with_platform@ \
>>        helper \
>>        test \
>>        @platform_with_platform_test@ \
>>        helper/test \
>>        doc \
>>        example \
>>        scripts
>>
>> So "make check" will run in @platform_with_platform@ and
>> @platform_with_platform_test@, and the former will also go into test to
>> run the tests. I think it's not necessary, can we do anything to avoid
>> this double run?
>
> this bit will sort it out:
>
> diff --git a/platform/linux-dpdk/Makefile.am 
> b/platform/linux-dpdk/Makefile.am
> index 71470fb..345c874 100644
> --- a/platform/linux-dpdk/Makefile.am
> +++ b/platform/linux-dpdk/Makefile.am
> @@ -18,7 +18,6 @@ AM_CFLAGS +=  -I$(top_srcdir)/helper/include
>
>  DPDK_LIBS="-ldpdk -ldl -lm -lpcap"
>  LIBS += $(DPDK_LIBS)
> -SUBDIRS = test
>
>  include_HEADERS = \
>                   $(top_srcdir)/include/odp.h
>
>
Yes, that chunk is part of:

commit 7cd8a605dc70cc4bbca4ba59c44c662ba5402781

you need the same for dpdk.

Maxim.

>
>> I've just ran make check on latest odp.git, and it doesn't seem to run
>> the testcases at all, am I the only one seeing that problem?
> This last bit was my issue, I forgot to configure them.
>
>
>>
>> Regards,
>>
>> Zoltan
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/platform/linux-dpdk/Makefile.am 
b/platform/linux-dpdk/Makefile.am
index 71470fb..345c874 100644
--- a/platform/linux-dpdk/Makefile.am
+++ b/platform/linux-dpdk/Makefile.am
@@ -18,7 +18,6 @@  AM_CFLAGS +=  -I$(top_srcdir)/helper/include

  DPDK_LIBS="-ldpdk -ldl -lm -lpcap"
  LIBS += $(DPDK_LIBS)
-SUBDIRS = test

  include_HEADERS = \
                   $(top_srcdir)/include/odp.h