| Message ID | 1459541734-12676-1-git-send-email-anders.roxell@linaro.org |
|---|---|
| State | Accepted |
| Commit | 2d120daaa1816fcd54b9dd1488a19871fa7ad014 |
| Headers | show |
On 04/01 22:15:34, Anders Roxell wrote: > Reorder the m4_include due to LIBS get contaminated while checking for > libraries. > Configure error: > checking for GCC atomic builtins... no > GCC-style __atomic builtins not supported by the compiler. > Use newer version. For gcc > 4.7.0 > > Suggested-by: Ricardo Salveti <ricardo.salveti@linaro.org> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > Thanks to Brians patch "[PATCH 2/2] configure: remove dead code", with my > suggestion to it, we found out that the order matters. > > Cheers, > Anders > > configure.ac | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/configure.ac b/configure.ac > index ba814b3..d0d3ca6 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -83,14 +83,6 @@ AC_SUBST([platform_with_platform], ["platform/${with_platform}"]) > AC_SUBST([platform_with_platform_test], ["platform/${with_platform}/test"]) > > ########################################################################## > -# Include m4 files > -########################################################################## > -m4_include([./doc/m4/configure.m4]) > -m4_include([./example/m4/configure.m4]) > -m4_include([./helper/m4/configure.m4]) > -m4_include([./test/m4/configure.m4]) > - > -########################################################################## > # Run platform specific checks and settings > ########################################################################## > if test "${with_platform}" == "linux-generic"; > @@ -102,6 +94,14 @@ else > fi > > ########################################################################## > +# Include m4 files > +########################################################################## > +m4_include([./doc/m4/configure.m4]) > +m4_include([./example/m4/configure.m4]) > +m4_include([./helper/m4/configure.m4]) > +m4_include([./test/m4/configure.m4]) > + > +########################################################################## > # Set SDK install path > ########################################################################## > AC_ARG_WITH([sdk-install-path], > -- > 2.1.4 Reviewed-by: Brian Brooks <brian.brooks@linaro.org>
Merged, Maxim. On 04/05/16 20:08, Brian Brooks wrote: > On 04/01 22:15:34, Anders Roxell wrote: >> Reorder the m4_include due to LIBS get contaminated while checking for >> libraries. >> Configure error: >> checking for GCC atomic builtins... no >> GCC-style __atomic builtins not supported by the compiler. >> Use newer version. For gcc > 4.7.0 >> >> Suggested-by: Ricardo Salveti <ricardo.salveti@linaro.org> >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> --- >> Thanks to Brians patch "[PATCH 2/2] configure: remove dead code", with my >> suggestion to it, we found out that the order matters. >> >> Cheers, >> Anders >> >> configure.ac | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/configure.ac b/configure.ac >> index ba814b3..d0d3ca6 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -83,14 +83,6 @@ AC_SUBST([platform_with_platform], ["platform/${with_platform}"]) >> AC_SUBST([platform_with_platform_test], ["platform/${with_platform}/test"]) >> >> ########################################################################## >> -# Include m4 files >> -########################################################################## >> -m4_include([./doc/m4/configure.m4]) >> -m4_include([./example/m4/configure.m4]) >> -m4_include([./helper/m4/configure.m4]) >> -m4_include([./test/m4/configure.m4]) >> - >> -########################################################################## >> # Run platform specific checks and settings >> ########################################################################## >> if test "${with_platform}" == "linux-generic"; >> @@ -102,6 +94,14 @@ else >> fi >> >> ########################################################################## >> +# Include m4 files >> +########################################################################## >> +m4_include([./doc/m4/configure.m4]) >> +m4_include([./example/m4/configure.m4]) >> +m4_include([./helper/m4/configure.m4]) >> +m4_include([./test/m4/configure.m4]) >> + >> +########################################################################## >> # Set SDK install path >> ########################################################################## >> AC_ARG_WITH([sdk-install-path], >> -- >> 2.1.4 > Reviewed-by: Brian Brooks <brian.brooks@linaro.org> > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
Hi, At least for me configure is still failing after this patch. $ ./configure --enable-test-perf --enable-test-vald --enable-test-cpp --with-cunit-path=<cunit_path> --with-dpdk-path=<dpdk_path> --with-netmap-path=<netmap_path> --prefix=<install_path> checking for CU_get_error in -lcunit... no configure: error: CUnit libraries required make: *** [config.status] Error 1 -Matias > -----Original Message----- > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of EXT Maxim > Uvarov > Sent: Wednesday, April 06, 2016 2:50 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH] configure: reorder m4_includes > > Merged, > Maxim. > > On 04/05/16 20:08, Brian Brooks wrote: > > On 04/01 22:15:34, Anders Roxell wrote: > >> Reorder the m4_include due to LIBS get contaminated while checking for > >> libraries. > >> Configure error: > >> checking for GCC atomic builtins... no > >> GCC-style __atomic builtins not supported by the compiler. > >> Use newer version. For gcc > 4.7.0 > >> > >> Suggested-by: Ricardo Salveti <ricardo.salveti@linaro.org> > >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > >> --- > >> Thanks to Brians patch "[PATCH 2/2] configure: remove dead code", with my > >> suggestion to it, we found out that the order matters. > >> > >> Cheers, > >> Anders > >> > >> configure.ac | 16 ++++++++-------- > >> 1 file changed, 8 insertions(+), 8 deletions(-) > >> > >> diff --git a/configure.ac b/configure.ac > >> index ba814b3..d0d3ca6 100644 > >> --- a/configure.ac > >> +++ b/configure.ac > >> @@ -83,14 +83,6 @@ AC_SUBST([platform_with_platform], > ["platform/${with_platform}"]) > >> AC_SUBST([platform_with_platform_test], > ["platform/${with_platform}/test"]) > >> > >> > ############################################################## > ############ > >> -# Include m4 files > >> - > ############################################################## > ############ > >> -m4_include([./doc/m4/configure.m4]) > >> -m4_include([./example/m4/configure.m4]) > >> -m4_include([./helper/m4/configure.m4]) > >> -m4_include([./test/m4/configure.m4]) > >> - > >> - > ############################################################## > ############ > >> # Run platform specific checks and settings > >> > ############################################################## > ############ > >> if test "${with_platform}" == "linux-generic"; > >> @@ -102,6 +94,14 @@ else > >> fi > >> > >> > ############################################################## > ############ > >> +# Include m4 files > >> > +############################################################# > ############# > >> +m4_include([./doc/m4/configure.m4]) > >> +m4_include([./example/m4/configure.m4]) > >> +m4_include([./helper/m4/configure.m4]) > >> +m4_include([./test/m4/configure.m4]) > >> + > >> > +############################################################# > ############# > >> # Set SDK install path > >> > ############################################################## > ############ > >> AC_ARG_WITH([sdk-install-path], > >> -- > >> 2.1.4 > > Reviewed-by: Brian Brooks <brian.brooks@linaro.org> > > _______________________________________________ > > lng-odp mailing list > > lng-odp@lists.linaro.org > > https://lists.linaro.org/mailman/listinfo/lng-odp > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
On 7 April 2016 at 07:48, Elo, Matias (Nokia - FI/Espoo) <matias.elo@nokia.com> wrote: > Hi, > > At least for me configure is still failing after this patch. > > $ ./configure --enable-test-perf --enable-test-vald --enable-test-cpp --with-cunit-path=<cunit_path> --with-dpdk-path=<dpdk_path> --with-netmap-path=<netmap_path> --prefix=<install_path> > > checking for CU_get_error in -lcunit... no > configure: error: CUnit libraries required > make: *** [config.status] Error 1 Correct, and this patch wasn't intended to fix this issue. This patch didn't fix that problem. I replied to Brians patch [1] with a few review comments how to fix this error you see. Cheers, Anders [1] https://lists.linaro.org/pipermail/lng-odp/2016-April/021680.html > > > -Matias > >> -----Original Message----- >> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of EXT Maxim >> Uvarov >> Sent: Wednesday, April 06, 2016 2:50 PM >> To: lng-odp@lists.linaro.org >> Subject: Re: [lng-odp] [PATCH] configure: reorder m4_includes >> >> Merged, >> Maxim. >> >> On 04/05/16 20:08, Brian Brooks wrote: >> > On 04/01 22:15:34, Anders Roxell wrote: >> >> Reorder the m4_include due to LIBS get contaminated while checking for >> >> libraries. >> >> Configure error: >> >> checking for GCC atomic builtins... no >> >> GCC-style __atomic builtins not supported by the compiler. >> >> Use newer version. For gcc > 4.7.0 >> >> >> >> Suggested-by: Ricardo Salveti <ricardo.salveti@linaro.org> >> >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> >> --- >> >> Thanks to Brians patch "[PATCH 2/2] configure: remove dead code", with my >> >> suggestion to it, we found out that the order matters. >> >> >> >> Cheers, >> >> Anders >> >> >> >> configure.ac | 16 ++++++++-------- >> >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> >> >> diff --git a/configure.ac b/configure.ac >> >> index ba814b3..d0d3ca6 100644 >> >> --- a/configure.ac >> >> +++ b/configure.ac >> >> @@ -83,14 +83,6 @@ AC_SUBST([platform_with_platform], >> ["platform/${with_platform}"]) >> >> AC_SUBST([platform_with_platform_test], >> ["platform/${with_platform}/test"]) >> >> >> >> >> ############################################################## >> ############ >> >> -# Include m4 files >> >> - >> ############################################################## >> ############ >> >> -m4_include([./doc/m4/configure.m4]) >> >> -m4_include([./example/m4/configure.m4]) >> >> -m4_include([./helper/m4/configure.m4]) >> >> -m4_include([./test/m4/configure.m4]) >> >> - >> >> - >> ############################################################## >> ############ >> >> # Run platform specific checks and settings >> >> >> ############################################################## >> ############ >> >> if test "${with_platform}" == "linux-generic"; >> >> @@ -102,6 +94,14 @@ else >> >> fi >> >> >> >> >> ############################################################## >> ############ >> >> +# Include m4 files >> >> >> +############################################################# >> ############# >> >> +m4_include([./doc/m4/configure.m4]) >> >> +m4_include([./example/m4/configure.m4]) >> >> +m4_include([./helper/m4/configure.m4]) >> >> +m4_include([./test/m4/configure.m4]) >> >> + >> >> >> +############################################################# >> ############# >> >> # Set SDK install path >> >> >> ############################################################## >> ############ >> >> AC_ARG_WITH([sdk-install-path], >> >> -- >> >> 2.1.4 >> > Reviewed-by: Brian Brooks <brian.brooks@linaro.org> >> > _______________________________________________ >> > lng-odp mailing list >> > lng-odp@lists.linaro.org >> > https://lists.linaro.org/mailman/listinfo/lng-odp >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp
> -----Original Message----- > From: EXT Anders Roxell [mailto:anders.roxell@linaro.org] > Sent: Thursday, April 07, 2016 9:06 AM > To: Elo, Matias (Nokia - FI/Espoo) <matias.elo@nokia.com> > Cc: lng-odp@lists.linaro.org; EXT Brian Brooks <brian.brooks@linaro.org> > Subject: Re: [lng-odp] [PATCH] configure: reorder m4_includes > > On 7 April 2016 at 07:48, Elo, Matias (Nokia - FI/Espoo) > <matias.elo@nokia.com> wrote: > > Hi, > > > > At least for me configure is still failing after this patch. > > > > $ ./configure --enable-test-perf --enable-test-vald --enable-test-cpp --with- > cunit-path=<cunit_path> --with-dpdk-path=<dpdk_path> --with-netmap- > path=<netmap_path> --prefix=<install_path> > > > > checking for CU_get_error in -lcunit... no > > configure: error: CUnit libraries required > > make: *** [config.status] Error 1 > > Correct, and this patch wasn't intended to fix this issue. > > This patch didn't fix that problem. I replied to Brians patch [1] with > a few review > comments how to fix this error you see. > > Cheers, > Anders > [1] https://lists.linaro.org/pipermail/lng-odp/2016-April/021680.html Thanks, I tested your suggested change and it fixed the configure error. The master branch build has been broken for several days now (https://bugs.linaro.org/show_bug.cgi?id=2161). This should be fixed ASAP. Who's going to send a patch for this? -Matias
On 04/07/16 10:47, Elo, Matias (Nokia - FI/Espoo) wrote: > >> -----Original Message----- >> From: EXT Anders Roxell [mailto:anders.roxell@linaro.org] >> Sent: Thursday, April 07, 2016 9:06 AM >> To: Elo, Matias (Nokia - FI/Espoo) <matias.elo@nokia.com> >> Cc: lng-odp@lists.linaro.org; EXT Brian Brooks <brian.brooks@linaro.org> >> Subject: Re: [lng-odp] [PATCH] configure: reorder m4_includes >> >> On 7 April 2016 at 07:48, Elo, Matias (Nokia - FI/Espoo) >> <matias.elo@nokia.com> wrote: >>> Hi, >>> >>> At least for me configure is still failing after this patch. >>> >>> $ ./configure --enable-test-perf --enable-test-vald --enable-test-cpp --with- >> cunit-path=<cunit_path> --with-dpdk-path=<dpdk_path> --with-netmap- >> path=<netmap_path> --prefix=<install_path> >>> checking for CU_get_error in -lcunit... no >>> configure: error: CUnit libraries required >>> make: *** [config.status] Error 1 >> Correct, and this patch wasn't intended to fix this issue. >> >> This patch didn't fix that problem. I replied to Brians patch [1] with >> a few review >> comments how to fix this error you see. >> >> Cheers, >> Anders >> [1] https://lists.linaro.org/pipermail/lng-odp/2016-April/021680.html > Thanks, I tested your suggested change and it fixed the configure error. > > The master branch build has been broken for several days now (https://bugs.linaro.org/show_bug.cgi?id=2161). This should be fixed ASAP. Who's going to send a patch for this? > > -Matias > For me it works and check-odp scripts also pass. I think it might be because I have cunit in system path. Maxim.
diff --git a/configure.ac b/configure.ac index ba814b3..d0d3ca6 100644 --- a/configure.ac +++ b/configure.ac @@ -83,14 +83,6 @@ AC_SUBST([platform_with_platform], ["platform/${with_platform}"]) AC_SUBST([platform_with_platform_test], ["platform/${with_platform}/test"]) ########################################################################## -# Include m4 files -########################################################################## -m4_include([./doc/m4/configure.m4]) -m4_include([./example/m4/configure.m4]) -m4_include([./helper/m4/configure.m4]) -m4_include([./test/m4/configure.m4]) - -########################################################################## # Run platform specific checks and settings ########################################################################## if test "${with_platform}" == "linux-generic"; @@ -102,6 +94,14 @@ else fi ########################################################################## +# Include m4 files +########################################################################## +m4_include([./doc/m4/configure.m4]) +m4_include([./example/m4/configure.m4]) +m4_include([./helper/m4/configure.m4]) +m4_include([./test/m4/configure.m4]) + +########################################################################## # Set SDK install path ########################################################################## AC_ARG_WITH([sdk-install-path],
Reorder the m4_include due to LIBS get contaminated while checking for libraries. Configure error: checking for GCC atomic builtins... no GCC-style __atomic builtins not supported by the compiler. Use newer version. For gcc > 4.7.0 Suggested-by: Ricardo Salveti <ricardo.salveti@linaro.org> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- Thanks to Brians patch "[PATCH 2/2] configure: remove dead code", with my suggestion to it, we found out that the order matters. Cheers, Anders configure.ac | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)