| Message ID | 1460365909-15184-1-git-send-email-balakrishna.garapati@linaro.org |
|---|---|
| State | Accepted |
| Commit | 7c27b1e270678a4b7aa1ab9a791a8aea9366b59a |
| Headers | show |
ping /Krishna On 11 April 2016 at 11:11, Balakrishna Garapati < balakrishna.garapati@linaro.org> wrote: > Resolving https://bugs.linaro.org/show_bug.cgi?id=2135 by return > over packet allocation failure. > > Signed-off-by: Balakrishna Garapati <balakrishna.garapati@linaro.org> > --- > test/performance/odp_crypto.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/performance/odp_crypto.c b/test/performance/odp_crypto.c > index fe1c7b4..ca461e5 100644 > --- a/test/performance/odp_crypto.c > +++ b/test/performance/odp_crypto.c > @@ -550,6 +550,7 @@ run_measure_one(crypto_args_t *cargs, > if (pkt == ODP_PACKET_INVALID) { > app_err("failed to allocate > buffer\n"); > rc = -1; > + return rc; > } else { > void *mem = odp_packet_data(pkt); > > -- > 1.9.1 > >
That will go after 1.9 release. Maxim. On 04/21/16 15:51, Krishna Garapati wrote: > ping > > /Krishna > > On 11 April 2016 at 11:11, Balakrishna Garapati > <balakrishna.garapati@linaro.org > <mailto:balakrishna.garapati@linaro.org>> wrote: > > Resolving https://bugs.linaro.org/show_bug.cgi?id=2135 by return > over packet allocation failure. > > Signed-off-by: Balakrishna Garapati > <balakrishna.garapati@linaro.org > <mailto:balakrishna.garapati@linaro.org>> > --- > test/performance/odp_crypto.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/performance/odp_crypto.c > b/test/performance/odp_crypto.c > index fe1c7b4..ca461e5 100644 > --- a/test/performance/odp_crypto.c > +++ b/test/performance/odp_crypto.c > @@ -550,6 +550,7 @@ run_measure_one(crypto_args_t *cargs, > if (pkt == ODP_PACKET_INVALID) { > app_err("failed to > allocate buffer\n"); > rc = -1; > + return rc; > } else { > void *mem = > odp_packet_data(pkt); > > -- > 1.9.1 > >
On 04/11/16 12:11, Balakrishna Garapati wrote: > Resolving https://bugs.linaro.org/show_bug.cgi?id=2135 by return > over packet allocation failure. > > Signed-off-by: Balakrishna Garapati <balakrishna.garapati@linaro.org> > --- > test/performance/odp_crypto.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/performance/odp_crypto.c b/test/performance/odp_crypto.c > index fe1c7b4..ca461e5 100644 > --- a/test/performance/odp_crypto.c > +++ b/test/performance/odp_crypto.c > @@ -550,6 +550,7 @@ run_measure_one(crypto_args_t *cargs, > if (pkt == ODP_PACKET_INVALID) { > app_err("failed to allocate buffer\n"); > rc = -1; > + return rc; that has to be simple: return -1; you can add my Reviewed-by: Maxim Uvarov <maxim.uvarov@linaro.org> for updated version. Maxim. > } else { > void *mem = odp_packet_data(pkt); >
merged Krishna, I made Maxims update and added his reviewed by for you On 25 April 2016 at 09:15, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 04/11/16 12:11, Balakrishna Garapati wrote: > >> Resolving https://bugs.linaro.org/show_bug.cgi?id=2135 by return >> over packet allocation failure. >> >> Signed-off-by: Balakrishna Garapati <balakrishna.garapati@linaro.org> >> --- >> test/performance/odp_crypto.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/test/performance/odp_crypto.c b/test/performance/odp_crypto.c >> index fe1c7b4..ca461e5 100644 >> --- a/test/performance/odp_crypto.c >> +++ b/test/performance/odp_crypto.c >> @@ -550,6 +550,7 @@ run_measure_one(crypto_args_t *cargs, >> if (pkt == ODP_PACKET_INVALID) { >> app_err("failed to allocate >> buffer\n"); >> rc = -1; >> + return rc; >> > that has to be simple: > return -1; > > you can add my > Reviewed-by: Maxim Uvarov <maxim.uvarov@linaro.org> > > for updated version. > > Maxim. > > } else { >> void *mem = odp_packet_data(pkt); >> >> > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
Thanks mike, I missed the comment received. my bad. /Krishna On 3 May 2016 at 23:33, Mike Holmes <mike.holmes@linaro.org> wrote: > merged > > Krishna, I made Maxims update and added his reviewed by for you > > On 25 April 2016 at 09:15, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > >> On 04/11/16 12:11, Balakrishna Garapati wrote: >> >>> Resolving https://bugs.linaro.org/show_bug.cgi?id=2135 by return >>> over packet allocation failure. >>> >>> Signed-off-by: Balakrishna Garapati <balakrishna.garapati@linaro.org> >>> --- >>> test/performance/odp_crypto.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/test/performance/odp_crypto.c >>> b/test/performance/odp_crypto.c >>> index fe1c7b4..ca461e5 100644 >>> --- a/test/performance/odp_crypto.c >>> +++ b/test/performance/odp_crypto.c >>> @@ -550,6 +550,7 @@ run_measure_one(crypto_args_t *cargs, >>> if (pkt == ODP_PACKET_INVALID) { >>> app_err("failed to allocate >>> buffer\n"); >>> rc = -1; >>> + return rc; >>> >> that has to be simple: >> return -1; >> >> you can add my >> Reviewed-by: Maxim Uvarov <maxim.uvarov@linaro.org> >> >> for updated version. >> >> Maxim. >> >> } else { >>> void *mem = odp_packet_data(pkt); >>> >>> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp >> > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" > > >
diff --git a/test/performance/odp_crypto.c b/test/performance/odp_crypto.c index fe1c7b4..ca461e5 100644 --- a/test/performance/odp_crypto.c +++ b/test/performance/odp_crypto.c @@ -550,6 +550,7 @@ run_measure_one(crypto_args_t *cargs, if (pkt == ODP_PACKET_INVALID) { app_err("failed to allocate buffer\n"); rc = -1; + return rc; } else { void *mem = odp_packet_data(pkt);
Resolving https://bugs.linaro.org/show_bug.cgi?id=2135 by return over packet allocation failure. Signed-off-by: Balakrishna Garapati <balakrishna.garapati@linaro.org> --- test/performance/odp_crypto.c | 1 + 1 file changed, 1 insertion(+)