diff mbox

[API-NEXT] example: tm: do not init platform params

Message ID 1461767289-18436-1-git-send-email-maxim.uvarov@linaro.org
State Accepted
Commit 4103cae3d5996a3c18e9206e7d3d3fc630fc57c7
Headers show

Commit Message

Maxim Uvarov April 27, 2016, 2:28 p.m. UTC
api does not specify platform specific init parameters for
odp_init_global as well as their structure.

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
---
 fixes:
 odp_traffic_mgmt.c:62:1: error: missing initializer for field ‘ipc_ns’ of ‘odp_platform_init_t’ [-Werror=missing-field-initializers]

 Strange that I did not see this warning on previous runs. Looks like I updated something in system.

 Maxim.

 example/traffic_mgmt/odp_traffic_mgmt.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Bill Fischofer April 27, 2016, 2:43 p.m. UTC | #1
On Wed, Apr 27, 2016 at 9:28 AM, Maxim Uvarov <maxim.uvarov@linaro.org>
wrote:

> api does not specify platform specific init parameters for

> odp_init_global as well as their structure.

>

> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

>


Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>



> ---

>  fixes:

>  odp_traffic_mgmt.c:62:1: error: missing initializer for field ‘ipc_ns’ of

> ‘odp_platform_init_t’ [-Werror=missing-field-initializers]

>

>  Strange that I did not see this warning on previous runs. Looks like I

> updated something in system.

>

>  Maxim.

>

>  example/traffic_mgmt/odp_traffic_mgmt.c | 5 +----

>  1 file changed, 1 insertion(+), 4 deletions(-)

>

> diff --git a/example/traffic_mgmt/odp_traffic_mgmt.c

> b/example/traffic_mgmt/odp_traffic_mgmt.c

> index e940954..1a1c652 100644

> --- a/example/traffic_mgmt/odp_traffic_mgmt.c

> +++ b/example/traffic_mgmt/odp_traffic_mgmt.c

> @@ -58,9 +58,6 @@ static const odp_init_t ODP_INIT_PARAMS = {

>         .abort_fn = odp_override_abort

>  };

>

> -static const odp_platform_init_t PLATFORM_PARAMS = {

> -};

> -

>  static profile_params_set_t COMPANY_PROFILE_PARAMS = {

>         .shaper_params = {

>                 .commit_bps = 50  * MBPS,  .commit_burst      = 1000000,

> @@ -768,7 +765,7 @@ int main(int argc, char *argv[])

>         rlimit.rlim_cur = rlimit.rlim_max;

>         setrlimit(RLIMIT_CORE, &rlimit);

>

> -       odp_init_global(&instance, &ODP_INIT_PARAMS, &PLATFORM_PARAMS);

> +       odp_init_global(&instance, &ODP_INIT_PARAMS, NULL);

>         odp_init_local(instance, ODP_THREAD_CONTROL);

>

>         if (process_cmd_line_options(argc, argv) < 0)

> --

> 2.7.1.250.gff4ea60

>

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp

>
Maxim Uvarov April 27, 2016, 3:33 p.m. UTC | #2
Merged,
Maxim.

On 04/27/16 17:43, Bill Fischofer wrote:
>
>
> On Wed, Apr 27, 2016 at 9:28 AM, Maxim Uvarov <maxim.uvarov@linaro.org 
> <mailto:maxim.uvarov@linaro.org>> wrote:
>
>     api does not specify platform specific init parameters for
>     odp_init_global as well as their structure.
>
>     Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org
>     <mailto:maxim.uvarov@linaro.org>>
>
>
> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org 
> <mailto:bill.fischofer@linaro.org>>
>
>     ---
>      fixes:
>      odp_traffic_mgmt.c:62:1: error: missing initializer for field
>     ‘ipc_ns’ of ‘odp_platform_init_t’ [-Werror=missing-field-initializers]
>
>      Strange that I did not see this warning on previous runs. Looks
>     like I updated something in system.
>
>      Maxim.
>
>      example/traffic_mgmt/odp_traffic_mgmt.c | 5 +----
>      1 file changed, 1 insertion(+), 4 deletions(-)
>
>     diff --git a/example/traffic_mgmt/odp_traffic_mgmt.c
>     b/example/traffic_mgmt/odp_traffic_mgmt.c
>     index e940954..1a1c652 100644
>     --- a/example/traffic_mgmt/odp_traffic_mgmt.c
>     +++ b/example/traffic_mgmt/odp_traffic_mgmt.c
>     @@ -58,9 +58,6 @@ static const odp_init_t ODP_INIT_PARAMS = {
>             .abort_fn = odp_override_abort
>      };
>
>     -static const odp_platform_init_t PLATFORM_PARAMS = {
>     -};
>     -
>      static profile_params_set_t COMPANY_PROFILE_PARAMS = {
>             .shaper_params = {
>                     .commit_bps = 50  * MBPS,  .commit_burst     =
>     1000000,
>     @@ -768,7 +765,7 @@ int main(int argc, char *argv[])
>             rlimit.rlim_cur = rlimit.rlim_max;
>             setrlimit(RLIMIT_CORE, &rlimit);
>
>     -       odp_init_global(&instance, &ODP_INIT_PARAMS,
>     &PLATFORM_PARAMS);
>     +       odp_init_global(&instance, &ODP_INIT_PARAMS, NULL);
>             odp_init_local(instance, ODP_THREAD_CONTROL);
>
>             if (process_cmd_line_options(argc, argv) < 0)
>     --
>     2.7.1.250.gff4ea60
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
diff mbox

Patch

diff --git a/example/traffic_mgmt/odp_traffic_mgmt.c b/example/traffic_mgmt/odp_traffic_mgmt.c
index e940954..1a1c652 100644
--- a/example/traffic_mgmt/odp_traffic_mgmt.c
+++ b/example/traffic_mgmt/odp_traffic_mgmt.c
@@ -58,9 +58,6 @@  static const odp_init_t ODP_INIT_PARAMS = {
 	.abort_fn = odp_override_abort
 };
 
-static const odp_platform_init_t PLATFORM_PARAMS = {
-};
-
 static profile_params_set_t COMPANY_PROFILE_PARAMS = {
 	.shaper_params = {
 		.commit_bps = 50  * MBPS,  .commit_burst      = 1000000,
@@ -768,7 +765,7 @@  int main(int argc, char *argv[])
 	rlimit.rlim_cur = rlimit.rlim_max;
 	setrlimit(RLIMIT_CORE, &rlimit);
 
-	odp_init_global(&instance, &ODP_INIT_PARAMS, &PLATFORM_PARAMS);
+	odp_init_global(&instance, &ODP_INIT_PARAMS, NULL);
 	odp_init_local(instance, ODP_THREAD_CONTROL);
 
 	if (process_cmd_line_options(argc, argv) < 0)