diff mbox

[1/4] iio: pressure: bmp280: augment DT bindings

Message ID 1466176341-17442-1-git-send-email-linus.walleij@linaro.org
State Superseded
Headers show

Commit Message

Linus Walleij June 17, 2016, 3:12 p.m. UTC
This adds standard device tree bindings for a reset GPIO line, and
the VDDD and VDDA power regulators.

Cc: devicetree@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 Documentation/devicetree/bindings/iio/pressure/bmp085.txt | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

-- 
2.4.11

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring (Arm) June 20, 2016, 4:46 p.m. UTC | #1
On Fri, Jun 17, 2016 at 05:12:18PM +0200, Linus Walleij wrote:
> This adds standard device tree bindings for a reset GPIO line, and

> the VDDD and VDDA power regulators.

> 

> Cc: devicetree@vger.kernel.org

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---

>  Documentation/devicetree/bindings/iio/pressure/bmp085.txt | 11 +++++++++--

>  1 file changed, 9 insertions(+), 2 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.txt b/Documentation/devicetree/bindings/iio/pressure/bmp085.txt

> index d7a6deb6b21e..06ad5feaea28 100644

> --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.txt

> +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.txt

> @@ -1,7 +1,7 @@

> -BMP085/BMP18x digital pressure sensors

> +BMP085/BMP18x/BMP28x digital pressure sensors

>  

>  Required properties:

> -- compatible: bosch,bmp085

> +- compatible: "bosch,bmp085" or "bosch,bmp180" or "bosch,bmp280"


One per line is preferred, but I wouldn't respin just for that.

Acked-by: Rob Herring <robh@kernel.org>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij June 27, 2016, 8:52 a.m. UTC | #2
On Sun, Jun 26, 2016 at 6:47 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 20/06/16 17:46, Rob Herring wrote:

>> On Fri, Jun 17, 2016 at 05:12:18PM +0200, Linus Walleij wrote:


>>>  Required properties:

>>> -- compatible: bosch,bmp085

>>> +- compatible: "bosch,bmp085" or "bosch,bmp180" or "bosch,bmp280"

>>

>> One per line is preferred, but I wouldn't respin just for that.

>>

>> Acked-by: Rob Herring <robh@kernel.org>

>>

> Applied to the togreg branch of iio.git - initially pushed out

> as testing.


Actually I did fix Rob's minor comments and sent out as v2,
but no big deal.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.txt b/Documentation/devicetree/bindings/iio/pressure/bmp085.txt
index d7a6deb6b21e..06ad5feaea28 100644
--- a/Documentation/devicetree/bindings/iio/pressure/bmp085.txt
+++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.txt
@@ -1,7 +1,7 @@ 
-BMP085/BMP18x digital pressure sensors
+BMP085/BMP18x/BMP28x digital pressure sensors
 
 Required properties:
-- compatible: bosch,bmp085
+- compatible: "bosch,bmp085" or "bosch,bmp180" or "bosch,bmp280"
 
 Optional properties:
 - chip-id: configurable chip id for non-default chip revisions
@@ -10,6 +10,10 @@  Optional properties:
   value range is 0-3 with rising sensitivity.
 - interrupt-parent: should be the phandle for the interrupt controller
 - interrupts: interrupt mapping for IRQ
+- reset-gpios: a GPIO line handling reset of the sensor: as the line is
+  active low, it should be marked GPIO_ACTIVE_LOW (see gpio/gpio.txt)
+- vddd-supply: digital voltage regulator (see regulator/regulator.txt)
+- vdda-supply: analog voltage regulator (see regulator/regulator.txt)
 
 Example:
 
@@ -21,4 +25,7 @@  pressure@77 {
 	default-oversampling = <2>;
 	interrupt-parent = <&gpio0>;
 	interrupts = <25 IRQ_TYPE_EDGE_RISING>;
+	reset-gpios = <&gpio0 26 GPIO_ACTIVE_LOW>;
+	vddd-supply = <&foo>;
+	vdda-supply = <&bar>;
 };