diff mbox

[v3,1/5] example: l3fwd: add missing gitignores

Message ID 1475495356-4038-1-git-send-email-matias.elo@nokia.com
State Accepted
Commit 018c59b52d91dc0ef4ded90d4a76a8b053d078b6
Headers show

Commit Message

Elo, Matias (Nokia - FI/Espoo) Oct. 3, 2016, 11:49 a.m. UTC
Signed-off-by: Matias Elo <matias.elo@nokia.com>

---
 example/l3fwd/.gitignore | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.7.4

Comments

Maxim Uvarov Oct. 21, 2016, 1:04 p.m. UTC | #1
Does somebody review test this?

Maxim.

On 10/03/16 14:49, Matias Elo wrote:
> Signed-off-by: Matias Elo <matias.elo@nokia.com>

> ---

>   example/l3fwd/.gitignore | 2 ++

>   1 file changed, 2 insertions(+)

>

> diff --git a/example/l3fwd/.gitignore b/example/l3fwd/.gitignore

> index 74e501f..3411830 100644

> --- a/example/l3fwd/.gitignore

> +++ b/example/l3fwd/.gitignore

> @@ -1 +1,3 @@

>   odp_l3fwd

> +*.log

> +*.trs
Mike Holmes Oct. 21, 2016, 2:31 p.m. UTC | #2
On 3 October 2016 at 07:49, Matias Elo <matias.elo@nokia.com> wrote:
> Signed-off-by: Matias Elo <matias.elo@nokia.com>


Reviewed-by: Mike Holmes <mike.holmes@linaro.org>


But I wonder if we should at some point  ignore these in the root of
odp/example and odp/test to save repeating them ?

> ---

>  example/l3fwd/.gitignore | 2 ++

>  1 file changed, 2 insertions(+)

>

> diff --git a/example/l3fwd/.gitignore b/example/l3fwd/.gitignore

> index 74e501f..3411830 100644

> --- a/example/l3fwd/.gitignore

> +++ b/example/l3fwd/.gitignore

> @@ -1 +1,3 @@

>  odp_l3fwd

> +*.log

> +*.trs

> --

> 2.7.4

>




-- 
Mike Holmes
Program Manager - Linaro Networking Group
Linaro.org │ Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"
Maxim Uvarov Oct. 24, 2016, 3:59 p.m. UTC | #3
Merged.

On 10/21/16 17:31, Mike Holmes wrote:
> On 3 October 2016 at 07:49, Matias Elo <matias.elo@nokia.com> wrote:

>> Signed-off-by: Matias Elo <matias.elo@nokia.com>

> Reviewed-by: Mike Holmes <mike.holmes@linaro.org>

>

> But I wonder if we should at some point  ignore these in the root of

> odp/example and odp/test to save repeating them ?

maybe even to global root.

Maxim.


>> ---

>>   example/l3fwd/.gitignore | 2 ++

>>   1 file changed, 2 insertions(+)

>>

>> diff --git a/example/l3fwd/.gitignore b/example/l3fwd/.gitignore

>> index 74e501f..3411830 100644

>> --- a/example/l3fwd/.gitignore

>> +++ b/example/l3fwd/.gitignore

>> @@ -1 +1,3 @@

>>   odp_l3fwd

>> +*.log

>> +*.trs

>> --

>> 2.7.4

>>

>

>
diff mbox

Patch

diff --git a/example/l3fwd/.gitignore b/example/l3fwd/.gitignore
index 74e501f..3411830 100644
--- a/example/l3fwd/.gitignore
+++ b/example/l3fwd/.gitignore
@@ -1 +1,3 @@ 
 odp_l3fwd
+*.log
+*.trs