| Message ID | 1477325206-24646-3-git-send-email-ard.biesheuvel@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Oct 24, 2016 at 05:06:42PM +0100, Ard Biesheuvel wrote: > Drop the include of AsmMacroIoLib.h, which contains GCC preprocessor macros > that RVCT does not use or require, given it has its own AsmMacroIoLib.inc > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Not verified, but looks sensible, so: Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> ...ish > --- > ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm b/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm > index 1417c9a78204..882f25b780cd 100644 > --- a/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm > +++ b/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm > @@ -11,10 +11,6 @@ > // > // > > -#include <AsmMacroIoLib.h> > -#include <Library/ArmCpuLib.h> > -#include <Chipset/ArmCortexA9.h> > - > INCLUDE AsmMacroExport.inc > INCLUDE AsmMacroIoLib.inc > > -- > 2.7.4 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm b/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm index 1417c9a78204..882f25b780cd 100644 --- a/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm +++ b/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm @@ -11,10 +11,6 @@ // // -#include <AsmMacroIoLib.h> -#include <Library/ArmCpuLib.h> -#include <Chipset/ArmCortexA9.h> - INCLUDE AsmMacroExport.inc INCLUDE AsmMacroIoLib.inc
Drop the include of AsmMacroIoLib.h, which contains GCC preprocessor macros that RVCT does not use or require, given it has its own AsmMacroIoLib.inc Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm | 4 ---- 1 file changed, 4 deletions(-) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel