diff mbox

ld/ARM: Fix script-type testsuite failure.

Message ID 528215D9.1050405@linaro.org
State Accepted
Headers show

Commit Message

Will Newton Nov. 12, 2013, 11:49 a.m. UTC 
Commit 34a79995c4cc34f6f41e2a4b2df477db31b31f0c changed how STT_FILE
symbols were emitted but this testcase got missed in the cleanup.

ld/testsuite/ChangeLog:

2013-11-12  Will Newton  <will.newton@linaro.org>

	* ld-arm/script-type.sym: Remove redundant STT_FILE symbol.
---
 ld/testsuite/ld-arm/script-type.sym | 1 -
 1 file changed, 1 deletion(-)

Comments

Alan Modra Nov. 14, 2013, 3:38 a.m. UTC | #1 
On Tue, Nov 12, 2013 at 11:49:45AM +0000, Will Newton wrote:
> 	* ld-arm/script-type.sym: Remove redundant STT_FILE symbol.

You could commit this as obvious.  I don't believe anyone would
complain (unless of course your patch was wrong!)
Will Newton Nov. 14, 2013, 8:42 a.m. UTC | #2 
On 14 November 2013 03:38, Alan Modra <amodra@gmail.com> wrote:
> On Tue, Nov 12, 2013 at 11:49:45AM +0000, Will Newton wrote:
>>       * ld-arm/script-type.sym: Remove redundant STT_FILE symbol.
>
> You could commit this as obvious.  I don't believe anyone would
> complain (unless of course your patch was wrong!)

Thanks. I'm never quite sure where the threshold of obviousness lies
so I erred on the safe side. ;-)
diff mbox

Patch

diff --git a/ld/testsuite/ld-arm/script-type.sym b/ld/testsuite/ld-arm/script-type.sym
index 4b54dd6..1623c03 100644
--- a/ld/testsuite/ld-arm/script-type.sym
+++ b/ld/testsuite/ld-arm/script-type.sym
@@ -9,7 +9,6 @@  Symbol table '.symtab' contains [0-9]+ entries:
 .* 0+10 +0 NOTYPE +LOCAL +DEFAULT +1 \$d
 .* 0+14 +0 NOTYPE +LOCAL +DEFAULT +1 \$a
 .* 0+20 +0 NOTYPE +LOCAL +DEFAULT +1 \$t
-.* 0+ +0 FILE +LOCAL +DEFAULT +ABS .*
 .* 0+10 +0 OBJECT +GLOBAL DEFAULT +1 bar_o
 .* 0+21 +0 FUNC +GLOBAL DEFAULT +1 bar_t
 .* 0+ +0 FUNC +GLOBAL DEFAULT +1 foo_a