Message ID | a6cbb256-6df3-ed33-9c53-56f7d9bbba64@suse.cz |
---|---|
State | New |
Headers | show |
On 11/04/2016 11:14 AM, Martin Liška wrote: > Hello. > > Sorry for the breakage, I'm attaching untested patch which fixes that. > I'm going to trigger regression tests. > > Martin Regression tests have finished on ppc64le-redhat-linux. Ready to be installed? Martin
> >From 531392d44eb195bd39cb49a169047f5bd898242f Mon Sep 17 00:00:00 2001 > From: marxin <mliska@suse.cz> > Date: Fri, 4 Nov 2016 11:12:06 +0100 > Subject: [PATCH] time_profiler: Set proper type to time_profiler_counter_ptr. > > gcc/ChangeLog: > > 2016-11-04 Martin Liska <mliska@suse.cz> > > * tree-profile.c (gimple_gen_time_profiler): Set proper type > to time_profiler_counter_ptr. Looks OK if it passes. Honza > --- > gcc/tree-profile.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gcc/tree-profile.c b/gcc/tree-profile.c > index 09a702f..d18b954 100644 > --- a/gcc/tree-profile.c > +++ b/gcc/tree-profile.c > @@ -489,8 +489,9 @@ gimple_gen_time_profiler (unsigned tag, unsigned base) > /* Emit: counters[0] = ++__gcov_time_profiler_counter. */ > if (flag_profile_update == PROFILE_UPDATE_ATOMIC) > { > - tree ptr = make_temp_ssa_name (type, NULL, "time_profiler_counter_ptr"); > - tree addr = build1 (ADDR_EXPR, build_pointer_type (type), > + tree ptr = make_temp_ssa_name (build_pointer_type (type), NULL, > + "time_profiler_counter_ptr"); > + tree addr = build1 (ADDR_EXPR, TREE_TYPE (ptr), > tree_time_profiler_counter); > gassign *assign = gimple_build_assign (ptr, NOP_EXPR, addr); > gsi_insert_before (&gsi, assign, GSI_NEW_STMT); > -- > 2.10.1 >
On 11/05/2016 09:38 AM, Jan Hubicka wrote: > Looks OK if it passes. > > Honza Thanks, fixed on trunk as r241894. Martin
On 7 November 2016 at 09:58, Martin Liška <mliska@suse.cz> wrote: > On 11/05/2016 09:38 AM, Jan Hubicka wrote: >> Looks OK if it passes. >> >> Honza > > Thanks, fixed on trunk as r241894. > Martin Thanks, this fixed the problems I reported. Christophe
From 531392d44eb195bd39cb49a169047f5bd898242f Mon Sep 17 00:00:00 2001 From: marxin <mliska@suse.cz> Date: Fri, 4 Nov 2016 11:12:06 +0100 Subject: [PATCH] time_profiler: Set proper type to time_profiler_counter_ptr. gcc/ChangeLog: 2016-11-04 Martin Liska <mliska@suse.cz> * tree-profile.c (gimple_gen_time_profiler): Set proper type to time_profiler_counter_ptr. --- gcc/tree-profile.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gcc/tree-profile.c b/gcc/tree-profile.c index 09a702f..d18b954 100644 --- a/gcc/tree-profile.c +++ b/gcc/tree-profile.c @@ -489,8 +489,9 @@ gimple_gen_time_profiler (unsigned tag, unsigned base) /* Emit: counters[0] = ++__gcov_time_profiler_counter. */ if (flag_profile_update == PROFILE_UPDATE_ATOMIC) { - tree ptr = make_temp_ssa_name (type, NULL, "time_profiler_counter_ptr"); - tree addr = build1 (ADDR_EXPR, build_pointer_type (type), + tree ptr = make_temp_ssa_name (build_pointer_type (type), NULL, + "time_profiler_counter_ptr"); + tree addr = build1 (ADDR_EXPR, TREE_TYPE (ptr), tree_time_profiler_counter); gassign *assign = gimple_build_assign (ptr, NOP_EXPR, addr); gsi_insert_before (&gsi, assign, GSI_NEW_STMT); -- 2.10.1