diff mbox

[2/4] arm64: dts: rockchip: Arch counter doesn't tick in system suspend

Message ID 1479807866-6957-2-git-send-email-daniel.lezcano@linaro.org
State Accepted
Commit e6186820a74546ac201a6669ebbee42399583b8b
Headers show

Commit Message

Daniel Lezcano Nov. 22, 2016, 9:44 a.m. UTC
From: Brian Norris <briannorris@chromium.org>


The "arm,no-tick-in-suspend" property was introduced to note
implementations where the system counter does not quite follow the ARM
specification that it "must be implemented in an always-on power
domain".

Particularly, RK3399's counter stops ticking when we switch from the
24MHz clock to the 32KHz clock in low-power suspend, so let's mark it as
such.

Signed-off-by: Brian Norris <briannorris@chromium.org>

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Heiko Stuebner Nov. 22, 2016, 3:02 p.m. UTC | #1
Am Dienstag, 22. November 2016, 10:44:22 schrieb Daniel Lezcano:
> From: Brian Norris <briannorris@chromium.org>

> 

> The "arm,no-tick-in-suspend" property was introduced to note

> implementations where the system counter does not quite follow the ARM

> specification that it "must be implemented in an always-on power

> domain".

> 

> Particularly, RK3399's counter stops ticking when we switch from the

> 24MHz clock to the 32KHz clock in low-power suspend, so let's mark it as

> such.

> 

> Signed-off-by: Brian Norris <briannorris@chromium.org>

> Reviewed-by: Douglas Anderson <dianders@chromium.org>

> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>


not sure if needed, but anyway
Acked-by: Heiko Stuebner <heiko@sntech.de>


> ---

>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi

> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index b65c193..d85b651 100644

> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi

> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi

> @@ -174,6 +174,7 @@

>  			     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW 0>,

>  			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW 0>,

>  			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW 0>;

> +		arm,no-tick-in-suspend;

>  	};

> 

>  	xin24m: xin24m {


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index b65c193..d85b651 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -174,6 +174,7 @@ 
 			     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW 0>,
 			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW 0>,
 			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW 0>;
+		arm,no-tick-in-suspend;
 	};
 
 	xin24m: xin24m {