| Message ID | 20170307155054.5833-4-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | MTTCG fix-ups for 2.9 | expand |
On 03/07/2017 12:50 PM, Alex Bennée wrote: > While we may fail the memory ordering check later that can be > confusing. So in cases where TARGET_SUPPORT_MTTCG has yet to be > defined we should say so specifically. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Reviewed-by: Richard Henderson <rth@twiddle.net> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > cpus.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/cpus.c b/cpus.c > index 6a817fec13..69e21858b8 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -202,6 +202,10 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp) > } else if (use_icount) { > error_setg(errp, "No MTTCG when icount is enabled"); > } else { > +#ifndef TARGET_SUPPORT_MTTCG > + error_report("Guest not yet converted to MTTCG - " > + "you may get unexpected results"); > +#endif > if (!check_tcg_memory_orders_compatible()) { > error_report("Guest expects a stronger memory ordering " > "than the host provides"); >
diff --git a/cpus.c b/cpus.c index 6a817fec13..69e21858b8 100644 --- a/cpus.c +++ b/cpus.c @@ -202,6 +202,10 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp) } else if (use_icount) { error_setg(errp, "No MTTCG when icount is enabled"); } else { +#ifndef TARGET_SUPPORT_MTTCG + error_report("Guest not yet converted to MTTCG - " + "you may get unexpected results"); +#endif if (!check_tcg_memory_orders_compatible()) { error_report("Guest expects a stronger memory ordering " "than the host provides");