| Message ID | 1489080073-13328-2-git-send-email-ard.biesheuvel@linaro.org |
|---|---|
| State | Accepted |
| Commit | eec1ba7dab8bfc774cab63523c999e5264a7b848 |
| Headers | show |
| Series | ArmVirtPkg: make DT vs ACPI support mutually exclusive | expand |
On 03/09/17 18:21, Ard Biesheuvel wrote: > From: Laszlo Ersek <lersek@redhat.com> > > Add missing EFIAPI calling convention specifiers to STATIC function > that are exposed via the FdtClientProtocol interface. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <lersek@redhat.com> > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > index 7cc0c44ca12a..547a29fce62c 100644 > --- a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > +++ b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > @@ -29,6 +29,7 @@ STATIC VOID *mDeviceTreeBase; > > STATIC > EFI_STATUS > +EFIAPI > GetNodeProperty ( > IN FDT_CLIENT_PROTOCOL *This, > IN INT32 Node, > @@ -55,6 +56,7 @@ GetNodeProperty ( > > STATIC > EFI_STATUS > +EFIAPI > SetNodeProperty ( > IN FDT_CLIENT_PROTOCOL *This, > IN INT32 Node, > @@ -267,6 +269,7 @@ FindMemoryNodeReg ( > > STATIC > EFI_STATUS > +EFIAPI > GetOrInsertChosenNode ( > IN FDT_CLIENT_PROTOCOL *This, > OUT INT32 *Node > Well, I can't exactly "review" or "ACK" my own patch (or patches mostly derived from my patches). Leif, can you pls R-b this? Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> On 9 Mar 2017 6:29 pm, "Laszlo Ersek" <lersek@redhat.com> wrote: > On 03/09/17 18:21, Ard Biesheuvel wrote: > > From: Laszlo Ersek <lersek@redhat.com> > > > > Add missing EFIAPI calling convention specifiers to STATIC function > > that are exposed via the FdtClientProtocol interface. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Laszlo Ersek <lersek@redhat.com> > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > --- > > ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > > index 7cc0c44ca12a..547a29fce62c 100644 > > --- a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > > +++ b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > > @@ -29,6 +29,7 @@ STATIC VOID *mDeviceTreeBase; > > > > STATIC > > EFI_STATUS > > +EFIAPI > > GetNodeProperty ( > > IN FDT_CLIENT_PROTOCOL *This, > > IN INT32 Node, > > @@ -55,6 +56,7 @@ GetNodeProperty ( > > > > STATIC > > EFI_STATUS > > +EFIAPI > > SetNodeProperty ( > > IN FDT_CLIENT_PROTOCOL *This, > > IN INT32 Node, > > @@ -267,6 +269,7 @@ FindMemoryNodeReg ( > > > > STATIC > > EFI_STATUS > > +EFIAPI > > GetOrInsertChosenNode ( > > IN FDT_CLIENT_PROTOCOL *This, > > OUT INT32 *Node > > > > Well, I can't exactly "review" or "ACK" my own patch (or patches mostly > derived from my patches). Leif, can you pls R-b this? > > Thanks > Laszlo > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c index 7cc0c44ca12a..547a29fce62c 100644 --- a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c +++ b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c @@ -29,6 +29,7 @@ STATIC VOID *mDeviceTreeBase; STATIC EFI_STATUS +EFIAPI GetNodeProperty ( IN FDT_CLIENT_PROTOCOL *This, IN INT32 Node, @@ -55,6 +56,7 @@ GetNodeProperty ( STATIC EFI_STATUS +EFIAPI SetNodeProperty ( IN FDT_CLIENT_PROTOCOL *This, IN INT32 Node, @@ -267,6 +269,7 @@ FindMemoryNodeReg ( STATIC EFI_STATUS +EFIAPI GetOrInsertChosenNode ( IN FDT_CLIENT_PROTOCOL *This, OUT INT32 *Node