| Message ID | 1474693266-16132-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Saturday, September 24, 2016 1:01:06 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/dma/imx-sdma.c:673:13: warning: 'sdma_handle_channel_loop' defined but not used [-Wunused-function] > > In fact, this function is called by no one and not exported, > so this patch removes it. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> The warning also shows up without W=1. I submitted the same patch, and it was applied on Thursday. Arnd
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 695f160..7fb55dd 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -670,11 +670,6 @@ static void sdma_event_disable(struct sdma_channel *sdmac, unsigned int event) writel_relaxed(val, sdma->regs + chnenbl); } -static void sdma_handle_channel_loop(struct sdma_channel *sdmac) -{ - dmaengine_desc_get_callback_invoke(&sdmac->desc, NULL); -} - static void sdma_update_channel_loop(struct sdma_channel *sdmac) { struct sdma_buffer_descriptor *bd;
We get 1 warning when building kernel with W=1: drivers/dma/imx-sdma.c:673:13: warning: 'sdma_handle_channel_loop' defined but not used [-Wunused-function] In fact, this function is called by no one and not exported, so this patch removes it. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/dma/imx-sdma.c | 5 ----- 1 file changed, 5 deletions(-) -- 2.7.4