diff mbox series

[7/9] config: android-base: enable CONFIG_INET_DIAG_DESTROY

Message ID 1496915712-14176-8-git-send-email-amit.pundir@linaro.org
State New
Headers show
Series kernel/configs: Android config fragment updates | expand

Commit Message

Amit Pundir June 8, 2017, 9:55 a.m. UTC 
From: Lorenzo Colitti <lorenzo@google.com>


As of Android N, this is required to close sockets when a
network disconnects.

Reviewed-at: https://android-review.googlesource.com/#/c/322674/

[AmitP: cherry-picked this change from Android common kernel]
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>

---
 kernel/configs/android-base.config | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4

Comments

Lorenzo Colitti June 8, 2017, 10:02 a.m. UTC | #1 
On Thu, Jun 8, 2017 at 6:55 PM, Amit Pundir <amit.pundir@linaro.org> wrote:
> Reviewed-at: https://android-review.googlesource.com/#/c/322674/


Note: that change was a mistake.

> --- a/kernel/configs/android-base.config

> +++ b/kernel/configs/android-base.config

> @@ -27,6 +27,7 @@ CONFIG_HIGH_RES_TIMERS=y

>  CONFIG_IKCONFIG=y

>  CONFIG_IKCONFIG_PROC=y

>  CONFIG_INET6_AH=y

> +CONFIG_INET6_DIAG_DESTROY=y


CONFIG_INET6_DIAG_DESTROY does not exist. The correct variable is
CONFIG_INET_DIAG_DESTROY.
Amit Pundir June 8, 2017, 10:34 a.m. UTC | #2 
On 8 June 2017 at 15:32, Lorenzo Colitti <lorenzo@google.com> wrote:
> On Thu, Jun 8, 2017 at 6:55 PM, Amit Pundir <amit.pundir@linaro.org> wrote:

>> Reviewed-at: https://android-review.googlesource.com/#/c/322674/

>

> Note: that change was a mistake.

>

>> --- a/kernel/configs/android-base.config

>> +++ b/kernel/configs/android-base.config

>> @@ -27,6 +27,7 @@ CONFIG_HIGH_RES_TIMERS=y

>>  CONFIG_IKCONFIG=y

>>  CONFIG_IKCONFIG_PROC=y

>>  CONFIG_INET6_AH=y

>> +CONFIG_INET6_DIAG_DESTROY=y

>

> CONFIG_INET6_DIAG_DESTROY does not exist. The correct variable is

> CONFIG_INET_DIAG_DESTROY.


Thanks for pointing it out. I grep-ed for "CONFIG_INET_DIAG_DESTROY"
as mentioned in the subject line before sending but didn't notice the
actual change. I'll re-spin the series.

Regards,
Amit Pundir
diff mbox series

Patch

diff --git a/kernel/configs/android-base.config b/kernel/configs/android-base.config
index 62cb392fc34b..5ecedaaf7c2e 100644
--- a/kernel/configs/android-base.config
+++ b/kernel/configs/android-base.config
@@ -27,6 +27,7 @@  CONFIG_HIGH_RES_TIMERS=y
 CONFIG_IKCONFIG=y
 CONFIG_IKCONFIG_PROC=y
 CONFIG_INET6_AH=y
+CONFIG_INET6_DIAG_DESTROY=y
 CONFIG_INET6_ESP=y
 CONFIG_INET6_IPCOMP=y
 CONFIG_INET=y