mbox series

[0/4] some scheduler code movements and small cleanup

Message ID 20170614171926.8345-1-nicolas.pitre@linaro.org
Headers show
Series some scheduler code movements and small cleanup | expand

Message

Nicolas Pitre June 14, 2017, 5:19 p.m. UTC 
On Tue, 13 Jun 2017, Ingo Molnar wrote:

> So I'm fine with most of the code movement - let's try this series

> without any of the more controversial bits which should make future

> arguments easier.


Here it is. Big diffstat due to code movement which should untangle
scheduler classes from common code some more, and isolating PI futex
support, with the net effect of reducing the common code file size.

Sidenote: I just discovered that the default git diff algorithm produces
awful results with this series at least, with 1270 extra diff lines
compared to the output from the patience or minimal diff algorithms.
Using --diff-algorithm=minimal produces a much saner diffstat, way more
representative of the actual changes in this case.


 include/linux/futex.h   |    7 +-
 init/Kconfig            |    8 +-
 kernel/futex.c          | 1559 +---------------------------------------
 kernel/futex_pi.c       | 1563 +++++++++++++++++++++++++++++++++++++++++
 kernel/sched/core.c     |  655 +----------------
 kernel/sched/deadline.c |  336 +++++++++
 kernel/sched/rt.c       |  310 ++++++++
 kernel/sched/sched.h    |   19 +
 8 files changed, 2272 insertions(+), 2185 deletions(-)

Comments

Nicolas Pitre June 21, 2017, 1:23 p.m. UTC | #1 
Ping.


On Wed, 14 Jun 2017, Nicolas Pitre wrote:

> On Tue, 13 Jun 2017, Ingo Molnar wrote:

> 

> > So I'm fine with most of the code movement - let's try this series

> > without any of the more controversial bits which should make future

> > arguments easier.

> 

> Here it is. Big diffstat due to code movement which should untangle

> scheduler classes from common code some more, and isolating PI futex

> support, with the net effect of reducing the common code file size.

> 

> Sidenote: I just discovered that the default git diff algorithm produces

> awful results with this series at least, with 1270 extra diff lines

> compared to the output from the patience or minimal diff algorithms.

> Using --diff-algorithm=minimal produces a much saner diffstat, way more

> representative of the actual changes in this case.

> 

> 

>  include/linux/futex.h   |    7 +-

>  init/Kconfig            |    8 +-

>  kernel/futex.c          | 1559 +---------------------------------------

>  kernel/futex_pi.c       | 1563 +++++++++++++++++++++++++++++++++++++++++

>  kernel/sched/core.c     |  655 +----------------

>  kernel/sched/deadline.c |  336 +++++++++

>  kernel/sched/rt.c       |  310 ++++++++

>  kernel/sched/sched.h    |   19 +

>  8 files changed, 2272 insertions(+), 2185 deletions(-)

>
Ingo Molnar June 21, 2017, 4:46 p.m. UTC | #2 
* Nicolas Pitre <nicolas.pitre@linaro.org> wrote:

> Ping.


I've applied the first patch to the scheduler tree yesterday, but the other 
changes unfortunately conflicted with other pending scheduler work - could you 
please re-post the other 3 patches on top of tip:sched/core?

Thanks,

	Ingo