| Message ID | 1499324063-907-1-git-send-email-hayashi.kunihiko@socionext.com |
|---|---|
| State | Accepted |
| Commit | 65ff135b4f748f7d5f0d6a21b860e88a0d1fb7c5 |
| Headers | show |
2017-07-06 15:54 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>: > According to pinctrl assignment for Pro4, each definition of USB#2 and > USB#3 are as follows. > > 184: USB2VBUS > 185: USB2OD > 186: USB2ID > 187: USB3VBUS > 188: USB3OD > > USB#2 has an additional pin "USB2ID", but the chip doesn't use this pin > while in host-mode. Considering this pin, the pin definitions for USB#3 > should be {187, 188}. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com> -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 6, 2017 at 8:54 AM, Kunihiko Hayashi <hayashi.kunihiko@socionext.com> wrote: > According to pinctrl assignment for Pro4, each definition of USB#2 and > USB#3 are as follows. > > 184: USB2VBUS > 185: USB2OD > 186: USB2ID > 187: USB3VBUS > 188: USB3OD > > USB#2 has an additional pin "USB2ID", but the chip doesn't use this pin > while in host-mode. Considering this pin, the pin definitions for USB#3 > should be {187, 188}. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Patch applied for fixes with Masahiro's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c b/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c index a433a30..c75e094 100644 --- a/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c +++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c @@ -1084,7 +1084,7 @@ static const unsigned usb1_pins[] = {182, 183}; static const int usb1_muxvals[] = {0, 0}; static const unsigned usb2_pins[] = {184, 185}; static const int usb2_muxvals[] = {0, 0}; -static const unsigned usb3_pins[] = {186, 187}; +static const unsigned usb3_pins[] = {187, 188}; static const int usb3_muxvals[] = {0, 0}; static const unsigned port_range0_pins[] = { 300, 301, 302, 303, 304, 305, 306, 307, /* PORT0x */
According to pinctrl assignment for Pro4, each definition of USB#2 and USB#3 are as follows. 184: USB2VBUS 185: USB2OD 186: USB2ID 187: USB3VBUS 188: USB3OD USB#2 has an additional pin "USB2ID", but the chip doesn't use this pin while in host-mode. Considering this pin, the pin definitions for USB#3 should be {187, 188}. Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html