diff mbox series

[RFC,1/3] dt-bindings: interrupt-controller: Add Realtek RTD1295

Message ID 20170817101140.32000-2-afaerber@suse.de
State New
Headers show
Series [RFC,1/3] dt-bindings: interrupt-controller: Add Realtek RTD1295 | expand

Commit Message

Andreas Färber Aug. 17, 2017, 10:11 a.m. UTC
Add binding for Realtek RTD1295 IRQ mux.

Signed-off-by: Andreas Färber <afaerber@suse.de>

---
 .../interrupt-controller/realtek,rtd119x-mux.txt   | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt

-- 
2.12.3

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring Aug. 22, 2017, 2:14 a.m. UTC | #1
On Thu, Aug 17, 2017 at 12:11:38PM +0200, Andreas Färber wrote:
> Add binding for Realtek RTD1295 IRQ mux.

> 

> Signed-off-by: Andreas Färber <afaerber@suse.de>

> ---

>  .../interrupt-controller/realtek,rtd119x-mux.txt   | 28 ++++++++++++++++++++++

>  1 file changed, 28 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt

> 

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt

> new file mode 100644

> index 000000000000..4b43370e3d74

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt

> @@ -0,0 +1,28 @@

> +Realtek RTD119x/129x IRQ Mux Controller

> +=======================================

> +

> +Required properties:

> +

> +- compatible           :  Should be one of the following:

> +                          - "realtek,rtd1295-irq-mux"

> +                          - "realtek,rtd1295-iso-irq-mux"

> +- reg                  :  Specifies base physical address and size of the registers.

> +- interrupts           :  Specifies the interrupt line which is mux'ed.

> +- interrupt-controller :  Presence indicates the node as interrupt controller.

> +- #interrupt-cells     :  Shall be 1. See common bindings in interrupt.txt.

> +

> +

> +Optional properties:

> +

> +See interrupt.txt for common bindings.


What else would apply here? interrupt-parent is the only thing I see, 
but that's really implicit anyway.

> +

> +

> +Example:

> +

> +	interrupt-controller@98007000 {

> +		compatible = "realtek,rtd1295-iso-irq-mux";

> +		reg = <0x98007000 0x100>;

> +		interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;

> +		interrupt-controller;

> +		#interrupt-cells = <1>;

> +	};

> -- 

> 2.12.3

> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andreas Färber Aug. 25, 2017, 7:41 p.m. UTC | #2
Am 22.08.2017 um 04:14 schrieb Rob Herring:
> On Thu, Aug 17, 2017 at 12:11:38PM +0200, Andreas Färber wrote:

>> Add binding for Realtek RTD1295 IRQ mux.

>>

>> Signed-off-by: Andreas Färber <afaerber@suse.de>

>> ---

>>  .../interrupt-controller/realtek,rtd119x-mux.txt   | 28 ++++++++++++++++++++++

>>  1 file changed, 28 insertions(+)

>>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt

>>

>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt

>> new file mode 100644

>> index 000000000000..4b43370e3d74

>> --- /dev/null

>> +++ b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt

>> @@ -0,0 +1,28 @@

>> +Realtek RTD119x/129x IRQ Mux Controller

>> +=======================================

>> +

>> +Required properties:

>> +

>> +- compatible           :  Should be one of the following:

>> +                          - "realtek,rtd1295-irq-mux"

>> +                          - "realtek,rtd1295-iso-irq-mux"

>> +- reg                  :  Specifies base physical address and size of the registers.

>> +- interrupts           :  Specifies the interrupt line which is mux'ed.

>> +- interrupt-controller :  Presence indicates the node as interrupt controller.

>> +- #interrupt-cells     :  Shall be 1. See common bindings in interrupt.txt.

>> +

>> +

>> +Optional properties:

>> +

>> +See interrupt.txt for common bindings.

> 

> What else would apply here? interrupt-parent is the only thing I see, 

> but that's really implicit anyway.


interrupt-names would be another optional property not needed today.
interrupt-controller and #interrupt-cells are common properties, too.

I'll drop both lines if you prefer. Otherwise okay?

Regards,
Andreas

>> +

>> +

>> +Example:

>> +

>> +	interrupt-controller@98007000 {

>> +		compatible = "realtek,rtd1295-iso-irq-mux";

>> +		reg = <0x98007000 0x100>;

>> +		interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;

>> +		interrupt-controller;

>> +		#interrupt-cells = <1>;

>> +	};

>> -- 

>> 2.12.3


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt
new file mode 100644
index 000000000000..4b43370e3d74
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd119x-mux.txt
@@ -0,0 +1,28 @@ 
+Realtek RTD119x/129x IRQ Mux Controller
+=======================================
+
+Required properties:
+
+- compatible           :  Should be one of the following:
+                          - "realtek,rtd1295-irq-mux"
+                          - "realtek,rtd1295-iso-irq-mux"
+- reg                  :  Specifies base physical address and size of the registers.
+- interrupts           :  Specifies the interrupt line which is mux'ed.
+- interrupt-controller :  Presence indicates the node as interrupt controller.
+- #interrupt-cells     :  Shall be 1. See common bindings in interrupt.txt.
+
+
+Optional properties:
+
+See interrupt.txt for common bindings.
+
+
+Example:
+
+	interrupt-controller@98007000 {
+		compatible = "realtek,rtd1295-iso-irq-mux";
+		reg = <0x98007000 0x100>;
+		interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-controller;
+		#interrupt-cells = <1>;
+	};