| Message ID | 20170907181938.3948-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | target/alpha queued patches | expand |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 0/4] target/alpha queued patches
Message-id: 20170907181938.3948-1-richard.henderson@linaro.org
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20170907201335.13956-1-david@redhat.com -> patchew/20170907201335.13956-1-david@redhat.com
Switched to a new branch 'test'
ed15303b60 target/alpha: Switch to do_transaction_failed() hook
b9223923b6 target/alpha: Convert to TranslatorOps
8ad04070b6 target/alpha: Convert to DisasContextBase
06c614ec51 target/alpha: Convert to DisasJumpType
=== OUTPUT BEGIN ===
Checking PATCH 1/4: target/alpha: Convert to DisasJumpType...
Checking PATCH 2/4: target/alpha: Convert to DisasContextBase...
ERROR: return is not a function, parentheses are not required
#48: FILE: target/alpha/translate.c:464:
+ return ((ctx->base.tb->cflags & CF_LAST_IO)
total: 1 errors, 0 warnings, 242 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/4: target/alpha: Convert to TranslatorOps...
Checking PATCH 4/4: target/alpha: Switch to do_transaction_failed() hook...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On 7 September 2017 at 19:19, Richard Henderson <richard.henderson@linaro.org> wrote: > Convert to TranslatorOps and do_transaction_failed. > > > r~ > > > The following changes since commit cda4a338c4243fa3bff4498b935340ac7121cc76: > > tcg/tci: Add TCG_TARGET_DEFAULT_MO (2017-09-07 18:57:34 +0100) > > are available in the git repository at: > > git://github.com/rth7680/qemu.git tags/pull-axp-20170907 > > for you to fetch changes up to 6ad4d7eed05a1e23537fc92b50f898f5977f37e6: > > target/alpha: Switch to do_transaction_failed() hook (2017-09-07 11:15:55 -0700) > > ---------------------------------------------------------------- > Queued target/alpha patches > > ---------------------------------------------------------------- > Peter Maydell (1): > target/alpha: Switch to do_transaction_failed() hook > > Richard Henderson (3): > target/alpha: Convert to DisasJumpType > target/alpha: Convert to DisasContextBase > target/alpha: Convert to TranslatorOps > > target/alpha/cpu.c | 2 +- > target/alpha/cpu.h | 8 +- > target/alpha/helper.c | 8 ++ > target/alpha/mem_helper.c | 19 +-- > target/alpha/translate.c | 347 +++++++++++++++++++++------------------------- > 5 files changed, 180 insertions(+), 204 deletions(-) Applied, thanks. -- PMM
Convert to TranslatorOps and do_transaction_failed. r~ The following changes since commit cda4a338c4243fa3bff4498b935340ac7121cc76: tcg/tci: Add TCG_TARGET_DEFAULT_MO (2017-09-07 18:57:34 +0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-axp-20170907 for you to fetch changes up to 6ad4d7eed05a1e23537fc92b50f898f5977f37e6: target/alpha: Switch to do_transaction_failed() hook (2017-09-07 11:15:55 -0700) ---------------------------------------------------------------- Queued target/alpha patches ---------------------------------------------------------------- Peter Maydell (1): target/alpha: Switch to do_transaction_failed() hook Richard Henderson (3): target/alpha: Convert to DisasJumpType target/alpha: Convert to DisasContextBase target/alpha: Convert to TranslatorOps target/alpha/cpu.c | 2 +- target/alpha/cpu.h | 8 +- target/alpha/helper.c | 8 ++ target/alpha/mem_helper.c | 19 +-- target/alpha/translate.c | 347 +++++++++++++++++++++------------------------- 5 files changed, 180 insertions(+), 204 deletions(-)