| Message ID | 2e9f4d4efd6568931aef634b499625f6d2ac5ae6.1508360121.git.amit.kucheria@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64 defconfig: enable additional led triggers | expand |
On Thu, Oct 19, 2017 at 5:30 PM, Guodong Xu <guodong.xu@linaro.org> wrote: > > > On Thu, Oct 19, 2017 at 4:57 AM, Amit Kucheria <amit.kucheria@linaro.org> > wrote: >> >> Blink the LED on a kernel panic. >> >> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> >> --- >> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts >> b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts >> index fd4705c..febbcb5 100644 >> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts >> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts >> @@ -108,6 +108,7 @@ >> label = "user_led4"; >> /* gpio_190_user_led4 */ >> gpios = <&gpio23 6 0>; >> + panic-indicator; > > > Looks good to me. Can I take that as an Ack? How about the Hikey960 patch? > > >> >> linux,default-trigger = "cpu0"; >> }; >> >> -- >> 2.7.4 >> >
On Mon, Oct 23, 2017 at 12:43 PM, Amit Kucheria <amit.kucheria@linaro.org> wrote: > On Thu, Oct 19, 2017 at 5:30 PM, Guodong Xu <guodong.xu@linaro.org> wrote: >> >> >> On Thu, Oct 19, 2017 at 4:57 AM, Amit Kucheria <amit.kucheria@linaro.org> >> wrote: >>> >>> Blink the LED on a kernel panic. >>> >>> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> >>> --- >>> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts >>> b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts >>> index fd4705c..febbcb5 100644 >>> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts >>> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts >>> @@ -108,6 +108,7 @@ >>> label = "user_led4"; >>> /* gpio_190_user_led4 */ >>> gpios = <&gpio23 6 0>; >>> + panic-indicator; >> >> >> Looks good to me. > > Can I take that as an Ack? How about the Hikey960 patch? > Acked-by: Guodong Xu <guodong.xu@linaro.org> -Guodong >> >> >>> >>> linux,default-trigger = "cpu0"; >>> }; >>> >>> -- >>> 2.7.4 >>> >>
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts index fd4705c..febbcb5 100644 --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts @@ -108,6 +108,7 @@ label = "user_led4"; /* gpio_190_user_led4 */ gpios = <&gpio23 6 0>; + panic-indicator; linux,default-trigger = "cpu0"; };
Blink the LED on a kernel panic. Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> --- arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 + 1 file changed, 1 insertion(+) -- 2.7.4