mbox series

[0/7,v3] I2C GPIO to use gpiolibs open drain

Message ID 20171005110310.5900-1-linus.walleij@linaro.org
Headers show
Series I2C GPIO to use gpiolibs open drain | expand

Message

Linus Walleij Oct. 5, 2017, 11:03 a.m. UTC
Finalized this series and collected the ACKs.

Wolfram: if not too late for v4.15, please carry this series.

Geert Uytterhoeven (1):
  dt-bindings: i2c: i2c-gpio: Add support for named gpios

Linus Walleij (6):
  i2c: gpio: Convert to use descriptors
  gpio: Make it possible for consumers to enforce open drain
  i2c: gpio: Enforce open drain through gpiolib
  i2c: gpio: Augment all boardfiles to use open drain
  i2c: gpio: Local vars in probe
  i2c: gpio: Add support for named gpios in DT

 Documentation/devicetree/bindings/i2c/i2c-gpio.txt |  32 +++-
 arch/arm/mach-ep93xx/core.c                        |  41 ++--
 arch/arm/mach-ep93xx/edb93xx.c                     |  15 +-
 arch/arm/mach-ep93xx/include/mach/platform.h       |   4 +-
 arch/arm/mach-ep93xx/simone.c                      |  12 +-
 arch/arm/mach-ep93xx/snappercl15.c                 |  12 +-
 arch/arm/mach-ep93xx/vision_ep9307.c               |   7 +-
 arch/arm/mach-ixp4xx/avila-setup.c                 |  17 +-
 arch/arm/mach-ixp4xx/dsmg600-setup.c               |  16 +-
 arch/arm/mach-ixp4xx/fsg-setup.c                   |  16 +-
 arch/arm/mach-ixp4xx/goramo_mlr.c                  |  24 +--
 arch/arm/mach-ixp4xx/ixdp425-setup.c               |  16 +-
 arch/arm/mach-ixp4xx/nas100d-setup.c               |  16 +-
 arch/arm/mach-ixp4xx/nslu2-setup.c                 |  16 +-
 arch/arm/mach-ks8695/board-acs5k.c                 |  15 +-
 arch/arm/mach-pxa/palmz72.c                        |  14 +-
 arch/arm/mach-pxa/viper.c                          |  27 ++-
 arch/arm/mach-sa1100/simpad.c                      |  14 +-
 arch/blackfin/mach-bf533/boards/blackstamp.c       |  19 +-
 arch/blackfin/mach-bf533/boards/ezkit.c            |  18 +-
 arch/blackfin/mach-bf533/boards/stamp.c            |  18 +-
 arch/blackfin/mach-bf561/boards/ezkit.c            |  18 +-
 arch/mips/alchemy/board-gpr.c                      |  23 ++-
 arch/mips/ath79/mach-pb44.c                        |  16 +-
 drivers/gpio/gpiolib.c                             |  13 ++
 drivers/i2c/busses/i2c-gpio.c                      | 212 ++++++++++-----------
 drivers/mfd/sm501.c                                |  49 ++---
 include/linux/gpio/consumer.h                      |   6 +
 include/linux/i2c-gpio.h                           |   4 -
 29 files changed, 422 insertions(+), 288 deletions(-)

-- 
2.13.5

Comments

Linus Walleij Oct. 19, 2017, 2:37 p.m. UTC | #1
On Thu, Oct 5, 2017 at 1:03 PM, Linus Walleij <linus.walleij@linaro.org> wrote:

> Finalized this series and collected the ACKs.

>

> Wolfram: if not too late for v4.15, please carry this series.


Sorry to bother with this, it's fine if you don't have time
to do the administration for this refactoring for v4.15.

There is a git branch:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=gpio-descriptors-i2c

If you want I can make a branch without the revision
comments and prepare a pull request on whatever
-rc you prefer.

If you want I can merge it through the GPIO tree with
your ACK if you need to get offloaded.

I can also hold it back for v4.16, just that then I want to
merge the GPIO infrastructure patches to GPIO
already.

Yours,
Linus Walleij
Wolfram Sang Oct. 19, 2017, 2:40 p.m. UTC | #2
> Sorry to bother with this, it's fine if you don't have time

> to do the administration for this refactoring for v4.15.


My plan is to review it this weekend and hopefully merge it for v4.15.
Wolfram Sang Oct. 27, 2017, 1:49 p.m. UTC | #3
Hey Linus,

> Sorry to bother with this, it's fine if you don't have time

> to do the administration for this refactoring for v4.15.


So, I finally had a look at this series and it looks good to me.
I don't know about the missing ACKs, though. My experience is that we
don't get ACKs for Blackfin these days, but there is still some MIPS and
MFD ack missing? Can you ping them again?

> If you want I can merge it through the GPIO tree with

> your ACK if you need to get offloaded.


I prefer I2C if you don't mind.

Regards,

   Wolfram
Wolfram Sang Oct. 27, 2017, 1:55 p.m. UTC | #4
> There is a git branch:

> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=gpio-descriptors-i2c


I assume this branch has been tested by buildbot already?
Linus Walleij Oct. 29, 2017, 11:19 p.m. UTC | #5
On Fri, Oct 27, 2017 at 3:55 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>

>> There is a git branch:

>> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=gpio-descriptors-i2c

>

> I assume this branch has been tested by buildbot already?


Yes it all gets tested all the time. Compiled fine.

Yours,
Linus Walleij
Wolfram Sang Oct. 30, 2017, 12:28 a.m. UTC | #6
> don't get ACKs for Blackfin these days, but there is still some MIPS and

> MFD ack missing? Can you ping them again?


Update: Lee's ack is already collected and Ralf acked V1 of this series.
Did you miss to include it in v3? Or did the patch change so much?
Linus Walleij Oct. 30, 2017, 7:52 a.m. UTC | #7
On Mon, Oct 30, 2017 at 1:28 AM, Wolfram Sang <wsa@the-dreams.de> wrote:

>> don't get ACKs for Blackfin these days, but there is still some MIPS and

>> MFD ack missing? Can you ping them again?

>

> Update: Lee's ack is already collected and Ralf acked V1 of this series.

> Did you miss to include it in v3? Or did the patch change so much?


Their ACKs are on the relevant patches on the git branch AFAICT
but if you want I can resend the patches too.

BTW my branch contains my changelogs as well,
so it should be edited to remove those (below the ---)
for convenience I also published a branch without them:
git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-wolfram

If you want to pull from my tree, take this :)

Yours,
Linus Walleij
Wolfram Sang Nov. 1, 2017, 10:45 p.m. UTC | #8
> for convenience I also published a branch without them:

> git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-wolfram


Merged this one. Thanks!