diff mbox series

radix-tree: replace <linux/spinlock.h> with <linux/spinlock_types.h>

Message ID 1507899816-11021-1-git-send-email-yamada.masahiro@socionext.com
State New
Headers show
Series radix-tree: replace <linux/spinlock.h> with <linux/spinlock_types.h> | expand

Commit Message

Masahiro Yamada Oct. 13, 2017, 1:03 p.m. UTC
This header contains references to spinlock_t and lockdep_is_held(),
both of which are defined in <linux/spinlock_types.h>

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 include/linux/radix-tree.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

Comments

Masahiro Yamada Nov. 13, 2017, 4:42 a.m. UTC | #1
Hi Andrew,


2017-10-13 22:03 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> This header contains references to spinlock_t and lockdep_is_held(),

> both of which are defined in <linux/spinlock_types.h>

>

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>



I have not got any comment on this patch.

Could you take a look at it, please?


> ---

>

>  include/linux/radix-tree.h | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/include/linux/radix-tree.h b/include/linux/radix-tree.h

> index 567ebb5..6df7fa9 100644

> --- a/include/linux/radix-tree.h

> +++ b/include/linux/radix-tree.h

> @@ -27,7 +27,7 @@

>  #include <linux/list.h>

>  #include <linux/preempt.h>

>  #include <linux/rcupdate.h>

> -#include <linux/spinlock.h>

> +#include <linux/spinlock_types.h>

>  #include <linux/types.h>

>

>  /*

> --

> 2.7.4

>




-- 
Best Regards
Masahiro Yamada
Matthew Wilcox Nov. 13, 2017, 4:09 p.m. UTC | #2
It's a waste of time.  I have the XArray replacement well in hand, so this header isn't staying around long-term.

> -----Original Message-----

> From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]

> Sent: Sunday, November 12, 2017 11:43 PM

> To: Andrew Morton <akpm@linux-foundation.org>

> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>; Matthew Wilcox

> <mawilcox@microsoft.com>; Jan Kara <jack@suse.cz>; Linux Kernel Mailing List

> <linux-kernel@vger.kernel.org>; Johannes Weiner <hannes@cmpxchg.org>;

> Chris Mi <chrism@mellanox.com>

> Subject: Re: [PATCH] radix-tree: replace <linux/spinlock.h> with

> <linux/spinlock_types.h>

> 

> Hi Andrew,

> 

> 

> 2017-10-13 22:03 GMT+09:00 Masahiro Yamada

> <yamada.masahiro@socionext.com>:

> > This header contains references to spinlock_t and lockdep_is_held(),

> > both of which are defined in <linux/spinlock_types.h>

> >

> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> 

> 

> I have not got any comment on this patch.

> 

> Could you take a look at it, please?

> 

> 

> > ---

> >

> >  include/linux/radix-tree.h | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/include/linux/radix-tree.h b/include/linux/radix-tree.h

> > index 567ebb5..6df7fa9 100644

> > --- a/include/linux/radix-tree.h

> > +++ b/include/linux/radix-tree.h

> > @@ -27,7 +27,7 @@

> >  #include <linux/list.h>

> >  #include <linux/preempt.h>

> >  #include <linux/rcupdate.h>

> > -#include <linux/spinlock.h>

> > +#include <linux/spinlock_types.h>

> >  #include <linux/types.h>

> >

> >  /*

> > --

> > 2.7.4

> >

> 

> 

> 

> --

> Best Regards

> Masahiro Yamada
diff mbox series

Patch

diff --git a/include/linux/radix-tree.h b/include/linux/radix-tree.h
index 567ebb5..6df7fa9 100644
--- a/include/linux/radix-tree.h
+++ b/include/linux/radix-tree.h
@@ -27,7 +27,7 @@ 
 #include <linux/list.h>
 #include <linux/preempt.h>
 #include <linux/rcupdate.h>
-#include <linux/spinlock.h>
+#include <linux/spinlock_types.h>
 #include <linux/types.h>
 
 /*