diff mbox series

[v6,4/6] dt: bindings: lp8860: Update the bindings to the standard

Message ID 20171201165613.10358-4-dmurphy@ti.com
State New
Headers show
Series None | expand

Commit Message

Dan Murphy Dec. 1, 2017, 4:56 p.m. UTC 
Update the lp8860 dt binding to the LED standard where
the LED should have a child node and also adding a
LED trigger entry.

Signed-off-by: Dan Murphy <dmurphy@ti.com>

---

v6 - New patch to fix binding documentation

 Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

-- 
2.15.0.124.g7668cbc60

Comments

Jacek Anaszewski Dec. 3, 2017, 1:27 p.m. UTC | #1 
Dan,

On 12/01/2017 05:56 PM, Dan Murphy wrote:
> Update the lp8860 dt binding to the LED standard where

> the LED should have a child node and also adding a

> LED trigger entry.

> 

> Signed-off-by: Dan Murphy <dmurphy@ti.com>

> ---

> 

> v6 - New patch to fix binding documentation

> 

>  Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++----

>  1 file changed, 11 insertions(+), 4 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt

> index aad38dd94d4b..4cf396de6eba 100644

> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt

> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt

> @@ -12,17 +12,24 @@ Required properties:

>  	- label - Used for naming LEDs

>  

>  Optional properties:

> -	- enable-gpio - gpio pin to enable/disable the device.

> -	- supply - "vled" - LED supply

> +	- enable-gpios : gpio pin to enable/disable the device.

> +	- vled-supply : LED supply

> +	- label : see Documentation/devicetree/bindings/leds/common.txt

> +	- linux,default-trigger : (optional)

> +	   see Documentation/devicetree/bindings/leds/common.txt

>  

>  Example:

>  

> -leds: leds@6 {

> +lp8860@2d {

>  	compatible = "ti,lp8860";

>  	reg = <0x2d>;

> -	label = "display_cluster";

>  	enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;

>  	vled-supply = <&vbatt>;

> +

> +	backlight: backlight@0 {

> +		label = "backlight_cluster";


You'll need to change this to:

label = "white:backlight_cluster"

Please always cc your patches with DT bindings to
devicetree@vger.kernel.org and related maintainers.

> +		linux,default-trigger = "backlight";

> +	};

>  }

>  

>  For more product information please see the link below:

> 


-- 
Best regards,
Jacek Anaszewski
Jacek Anaszewski Dec. 3, 2017, 1:49 p.m. UTC | #2 
Hi Dan,

Thanks for the patch.

On 12/01/2017 05:56 PM, Dan Murphy wrote:
> Update the lp8860 dt binding to the LED standard where

> the LED should have a child node and also adding a

> LED trigger entry.

> 

> Signed-off-by: Dan Murphy <dmurphy@ti.com>

> ---

> 

> v6 - New patch to fix binding documentation

> 

>  Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++----

>  1 file changed, 11 insertions(+), 4 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt

> index aad38dd94d4b..4cf396de6eba 100644

> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt

> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt

> @@ -12,17 +12,24 @@ Required properties:

>  	- label - Used for naming LEDs

>  

>  Optional properties:

> -	- enable-gpio - gpio pin to enable/disable the device.

> -	- supply - "vled" - LED supply

> +	- enable-gpios : gpio pin to enable/disable the device.

> +	- vled-supply : LED supply

> +	- label : see Documentation/devicetree/bindings/leds/common.txt

> +	- linux,default-trigger : (optional)

> +	   see Documentation/devicetree/bindings/leds/common.txt


Related driver doesn't parse this DT property AFAICS.

>  Example:

>  

> -leds: leds@6 {

> +lp8860@2d {

>  	compatible = "ti,lp8860";

>  	reg = <0x2d>;

> -	label = "display_cluster";

>  	enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;


s/gpio/gpios/

>  	vled-supply = <&vbatt>;

> +

> +	backlight: backlight@0 {

> +		label = "backlight_cluster";

> +		linux,default-trigger = "backlight";

> +	};

>  }

>  

>  For more product information please see the link below:

> 


-- 
Best regards,
Jacek Anaszewski
Jacek Anaszewski Dec. 3, 2017, 2:34 p.m. UTC | #3 
On 12/03/2017 02:49 PM, Jacek Anaszewski wrote:
> Hi Dan,

> 

> Thanks for the patch.

> 

> On 12/01/2017 05:56 PM, Dan Murphy wrote:

>> Update the lp8860 dt binding to the LED standard where

>> the LED should have a child node and also adding a

>> LED trigger entry.

>>

>> Signed-off-by: Dan Murphy <dmurphy@ti.com>

>> ---

>>

>> v6 - New patch to fix binding documentation

>>

>>  Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++----

>>  1 file changed, 11 insertions(+), 4 deletions(-)

>>

>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt

>> index aad38dd94d4b..4cf396de6eba 100644

>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt

>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt

>> @@ -12,17 +12,24 @@ Required properties:

>>  	- label - Used for naming LEDs

>>  

>>  Optional properties:

>> -	- enable-gpio - gpio pin to enable/disable the device.

>> -	- supply - "vled" - LED supply

>> +	- enable-gpios : gpio pin to enable/disable the device.

>> +	- vled-supply : LED supply

>> +	- label : see Documentation/devicetree/bindings/leds/common.txt

>> +	- linux,default-trigger : (optional)

>> +	   see Documentation/devicetree/bindings/leds/common.txt

> 

> Related driver doesn't parse this DT property AFAICS.


Ah, I missed that you're adding it in 5/6.

> 

>>  Example:

>>  

>> -leds: leds@6 {

>> +lp8860@2d {

>>  	compatible = "ti,lp8860";

>>  	reg = <0x2d>;

>> -	label = "display_cluster";

>>  	enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;

> 

> s/gpio/gpios/

> 

>>  	vled-supply = <&vbatt>;

>> +

>> +	backlight: backlight@0 {

>> +		label = "backlight_cluster";

>> +		linux,default-trigger = "backlight";

>> +	};

>>  }

>>  

>>  For more product information please see the link below:

>>

>
Dan Murphy Dec. 5, 2017, 1:06 p.m. UTC | #4 
Rob

On 12/04/2017 04:35 PM, Rob Herring wrote:
> On Sun, Dec 03, 2017 at 02:27:20PM +0100, Jacek Anaszewski wrote:

>> Dan,

>>

>> On 12/01/2017 05:56 PM, Dan Murphy wrote:

>>> Update the lp8860 dt binding to the LED standard where

>>> the LED should have a child node and also adding a

>>> LED trigger entry.

>>>

>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>

>>> ---

>>>

>>> v6 - New patch to fix binding documentation

>>>

>>>  Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++----

>>>  1 file changed, 11 insertions(+), 4 deletions(-)

>>>

>>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt

>>> index aad38dd94d4b..4cf396de6eba 100644

>>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt

>>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt

>>> @@ -12,17 +12,24 @@ Required properties:

>>>  	- label - Used for naming LEDs

>>>  

>>>  Optional properties:

>>> -	- enable-gpio - gpio pin to enable/disable the device.

>>> -	- supply - "vled" - LED supply

>>> +	- enable-gpios : gpio pin to enable/disable the device.

>>> +	- vled-supply : LED supply

>>> +	- label : see Documentation/devicetree/bindings/leds/common.txt

>>> +	- linux,default-trigger : (optional)

>>> +	   see Documentation/devicetree/bindings/leds/common.txt

>>>  

>>>  Example:

>>>  

>>> -leds: leds@6 {

>>> +lp8860@2d {

> 

> leds@2d


Ack

> 

>>>  	compatible = "ti,lp8860";

>>>  	reg = <0x2d>;

>>> -	label = "display_cluster";

>>>  	enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;

>>>  	vled-supply = <&vbatt>;

>>> +

>>> +	backlight: backlight@0 {

> 

> unit-address requires a 'reg' property. Building your dts files with W=1 

> will tell you this.


I will add this.  There is so much noise when enabling this option on the dts
I missed the warning.

Dan

<snip>

-- 
------------------
Dan Murphy
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
index aad38dd94d4b..4cf396de6eba 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
+++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
@@ -12,17 +12,24 @@  Required properties:
 	- label - Used for naming LEDs
 
 Optional properties:
-	- enable-gpio - gpio pin to enable/disable the device.
-	- supply - "vled" - LED supply
+	- enable-gpios : gpio pin to enable/disable the device.
+	- vled-supply : LED supply
+	- label : see Documentation/devicetree/bindings/leds/common.txt
+	- linux,default-trigger : (optional)
+	   see Documentation/devicetree/bindings/leds/common.txt
 
 Example:
 
-leds: leds@6 {
+lp8860@2d {
 	compatible = "ti,lp8860";
 	reg = <0x2d>;
-	label = "display_cluster";
 	enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
 	vled-supply = <&vbatt>;
+
+	backlight: backlight@0 {
+		label = "backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
 }
 
 For more product information please see the link below: