| Message ID | 20171221124030.23721-8-maxime.ripard@free-electrons.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | sunxi: arm64 binary size fixes | expand |
Hi, On 21/12/17 12:40, Maxime Ripard wrote: > The sunXi arm64 build has overflown, leading to the main U-boot binary > overwriting the environment when flashing the new image, or even worse, > overwriting itself when we're calling saveenv. > > Disable this command that is not critical until we can adress the issue > properly. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Same comment as the other patch: we only support VIDEO_BPP32 for sunxi. Cheers, Andre. > --- > drivers/video/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index a267c9acfecb..2fc0defcd0d1 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -49,6 +49,7 @@ config VIDEO_BPP8 > config VIDEO_BPP16 > bool "Support 16-bit-per-pixel displays" > depends on DM_VIDEO > + default n if ARCH_SUNXI > default y if DM_VIDEO > help > Support drawing text and bitmaps onto a 16-bit-per-pixel display. >
On Thu, 21 Dec 2017 13:40:26 +0100 Maxime Ripard maxime.ripard@free-electrons.com wrote: > The sunXi arm64 build has overflown, leading to the main U-boot binary > overwriting the environment when flashing the new image, or even worse, > overwriting itself when we're calling saveenv. > > Disable this command that is not critical until we can adress the issue > properly. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Reviewed-by: Anatolij Gustschin <agust@denx.de>
On Thu, Dec 21, 2017 at 9:42 PM, Anatolij Gustschin <agust@denx.de> wrote: > On Thu, 21 Dec 2017 13:40:26 +0100 > Maxime Ripard maxime.ripard@free-electrons.com wrote: > >> The sunXi arm64 build has overflown, leading to the main U-boot binary >> overwriting the environment when flashing the new image, or even worse, >> overwriting itself when we're calling saveenv. >> >> Disable this command that is not critical until we can adress the issue >> properly. >> >> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > Reviewed-by: Anatolij Gustschin <agust@denx.de> Applied to u-boot-sunxi/master
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index a267c9acfecb..2fc0defcd0d1 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -49,6 +49,7 @@ config VIDEO_BPP8 config VIDEO_BPP16 bool "Support 16-bit-per-pixel displays" depends on DM_VIDEO + default n if ARCH_SUNXI default y if DM_VIDEO help Support drawing text and bitmaps onto a 16-bit-per-pixel display.
The sunXi arm64 build has overflown, leading to the main U-boot binary overwriting the environment when flashing the new image, or even worse, overwriting itself when we're calling saveenv. Disable this command that is not critical until we can adress the issue properly. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- drivers/video/Kconfig | 1 + 1 file changed, 1 insertion(+)