| Message ID | 20180110162816.431038-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 3343647813fdf0f2409fbf5816ee3e0622168079 |
| Headers | show |
| Series | ARM: pxa/tosa-bt: add MODULE_LICENSE tag | expand |
Arnd Bergmann <arnd@arndb.de> writes: > Without this tag, we get a build warning: > > WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o > > For completeness, I'm also adding author and description fields. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Queued into pxa/for-next, thanks. Cheers. -- Robert
On Wed, Jan 10, 2018 at 9:22 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote: > Arnd Bergmann <arnd@arndb.de> writes: > >> Without this tag, we get a build warning: >> >> WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o >> >> For completeness, I'm also adding author and description fields. >> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Queued into pxa/for-next, thanks. I see now that you didn't send this back to arm@kernel.org. I assume you planned to send it for 4.17, but kernelci now still reports the warning for both 4.15 and linux-next (4.16). Should we just include this patch in the 4.16 fixes instead? Arnd
Arnd Bergmann <arnd@arndb.de> writes: > On Wed, Jan 10, 2018 at 9:22 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote: >> Arnd Bergmann <arnd@arndb.de> writes: >> >>> Without this tag, we get a build warning: >>> >>> WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o >>> >>> For completeness, I'm also adding author and description fields. >>> >>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> >> Queued into pxa/for-next, thanks. > > I see now that you didn't send this back to arm@kernel.org. I assume you planned > to send it for 4.17, but kernelci now still reports the warning for > both 4.15 and > linux-next (4.16). Should we just include this patch in the 4.16 fixes > instead? Yeah sure, go ahead and merge it into 4.16 staging branch, with my : Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> Cheers. -- Robert
On Fri, Jan 19, 2018 at 6:18 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote: > Arnd Bergmann <arnd@arndb.de> writes: > >> On Wed, Jan 10, 2018 at 9:22 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote: >>> Arnd Bergmann <arnd@arndb.de> writes: >>> >>>> Without this tag, we get a build warning: >>>> >>>> WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o >>>> >>>> For completeness, I'm also adding author and description fields. >>>> >>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >>> >>> Queued into pxa/for-next, thanks. >> >> I see now that you didn't send this back to arm@kernel.org. I assume you planned >> to send it for 4.17, but kernelci now still reports the warning for >> both 4.15 and >> linux-next (4.16). Should we just include this patch in the 4.16 fixes >> instead? > Yeah sure, go ahead and merge it into 4.16 staging branch, with my : > Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> Applied to next/soc now, thanks! Arnd
diff --git a/arch/arm/mach-pxa/tosa-bt.c b/arch/arm/mach-pxa/tosa-bt.c index 107f37210fb9..83606087edc7 100644 --- a/arch/arm/mach-pxa/tosa-bt.c +++ b/arch/arm/mach-pxa/tosa-bt.c @@ -132,3 +132,7 @@ static struct platform_driver tosa_bt_driver = { }, }; module_platform_driver(tosa_bt_driver); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Dmitry Baryshkov"); +MODULE_DESCRIPTION("Bluetooth built-in chip control");
Without this tag, we get a build warning: WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o For completeness, I'm also adding author and description fields. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-pxa/tosa-bt.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.9.0