| Message ID | 20180228233249.26281-2-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | e71de5ee08dcb053da860f96d46cb1fb0ddfb0c6 |
| Headers | show |
| Series | [1/6] kbuild: remove remaining use of undefined YACC_PREFIX | expand |
2018-03-01 8:32 GMT+09:00 Rob Herring <robh@kernel.org>: > Commit eea199b445f6 ("kbuild: remove unnecessary LEX_PREFIX and > YACC_PREFIX") removed YACC_PREFIX definition, but left one use of it. There > was not any build error since there is no user of "cmd_bison_h" currently. > Remove the last remaining occurrence of YACC_PREFIX. > > Fixes: eea199b445f6 ("kbuild: remove unnecessary LEX_PREFIX and YACC_PREFIX") > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Signed-off-by: Rob Herring <robh@kernel.org> You can replace CC with my Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > scripts/Makefile.lib | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 5589bae34af6..1bc2f90cb8c0 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -217,7 +217,7 @@ $(filter %.tab.c,$(targets)): $(obj)/%.tab.c: $(src)/%.y FORCE > $(call if_changed,bison) > > quiet_cmd_bison_h = YACC $@ > - cmd_bison_h = bison -o/dev/null --defines=$@ -t -l -p $(YACC_PREFIX) $< > + cmd_bison_h = bison -o/dev/null --defines=$@ -t -l $< > > ifdef REGENERATE_PARSERS > .PRECIOUS: $(src)/%.tab.h_shipped > -- > 2.14.1 > -- Best Regards Masahiro Yamada
On Thu, Mar 1, 2018 at 8:01 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > 2018-03-01 22:39 GMT+09:00 Rob Herring <robh@kernel.org>: >> On Thu, Mar 1, 2018 at 5:35 AM, Masahiro Yamada >> <yamada.masahiro@socionext.com> wrote: >>> Hi Rob, >>> >>> 2018-03-01 13:20 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>: >>>> 2018-03-01 8:32 GMT+09:00 Rob Herring <robh@kernel.org>: >>>>> Commit eea199b445f6 ("kbuild: remove unnecessary LEX_PREFIX and >>>>> YACC_PREFIX") removed YACC_PREFIX definition, but left one use of it. There >>>>> was not any build error since there is no user of "cmd_bison_h" currently. >>>>> Remove the last remaining occurrence of YACC_PREFIX. >>>>> >>>>> Fixes: eea199b445f6 ("kbuild: remove unnecessary LEX_PREFIX and YACC_PREFIX") >>>>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> >>>>> Signed-off-by: Rob Herring <robh@kernel.org> >>>> >>>> You can replace CC with my >>>> >>>> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com> >>> >>> >>> I got a reason to send a fixes pull request this week. >>> >>> If you do not mind, may I include this one in >>> my Kbuild fixes pull request? >> >> Yes, please do. >> >>> >>> I do not see dependency between 1/6 and the rest of the series. >> >> Only that dtc won't build without it. :) >> > > Sorry, I missed that. > You are right. > > I see this series is already queued up in your tree. It is not really queued up, I just pushed out a tree for 0-day testing. And it turns out I need strrchr in several places. > So, just keep it in your tree. Okay. Rob
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 5589bae34af6..1bc2f90cb8c0 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -217,7 +217,7 @@ $(filter %.tab.c,$(targets)): $(obj)/%.tab.c: $(src)/%.y FORCE $(call if_changed,bison) quiet_cmd_bison_h = YACC $@ - cmd_bison_h = bison -o/dev/null --defines=$@ -t -l -p $(YACC_PREFIX) $< + cmd_bison_h = bison -o/dev/null --defines=$@ -t -l $< ifdef REGENERATE_PARSERS .PRECIOUS: $(src)/%.tab.h_shipped
Commit eea199b445f6 ("kbuild: remove unnecessary LEX_PREFIX and YACC_PREFIX") removed YACC_PREFIX definition, but left one use of it. There was not any build error since there is no user of "cmd_bison_h" currently. Remove the last remaining occurrence of YACC_PREFIX. Fixes: eea199b445f6 ("kbuild: remove unnecessary LEX_PREFIX and YACC_PREFIX") Cc: Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by: Rob Herring <robh@kernel.org> --- scripts/Makefile.lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.1