diff mbox series

[edk2,v1,4/4] edk2-platforms: created RDK Qemu platform for RDK UEFI applications

Message ID 20180212103122.10729-5-moorthy.baskaravenkatraman-sambamoorthy@linaro.org
State New
Headers show
Series edk2-platforms:Comcast:RDK Qemu platform for RDK UEFI application | expand

Commit Message

Moorthy B S Feb. 12, 2018, 10:31 a.m. UTC
From: Kalyan Nagabhirava <kalyankumar.nagabhirava@linaro.org>


Linaro and RDK are working on standardizing the boot process for RDK
STB boxes using Uefi. Implmented couple of RDK UEFI apllications (secure
boot and DRI) which are tested on RDK Qemu platform

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Moorthy Baskaravenkatraman <moorthy.baskaravenkatraman-sambamoorthy@linaro.org>

---
 Platform/Comcast/RDKQemu/RDKQemu.dsc | 431 ++++++++++++++++++++
 Platform/Comcast/RDKQemu/RDKQemu.fdf | 128 ++++++
 Platform/Comcast/RDKQemu/README      |  73 ++++
 3 files changed, 632 insertions(+)

-- 
2.15.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel March 2, 2018, 2:49 p.m. UTC | #1
On 12 February 2018 at 10:31, Moorthy Baskaravenkatraman
<moorthy.baskaravenkatraman-sambamoorthy@linaro.org> wrote:
> From: Kalyan Nagabhirava <kalyankumar.nagabhirava@linaro.org>

>

> Linaro and RDK are working on standardizing the boot process for RDK

> STB boxes using Uefi. Implmented couple of RDK UEFI apllications (secure

> boot and DRI) which are tested on RDK Qemu platform

>

> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Moorthy Baskaravenkatraman <moorthy.baskaravenkatraman-sambamoorthy@linaro.org>



This looks fine now.

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Pushed as

433780969763 Platform/Comcast: add RDK boot manager library implementation
c255b21b95cb Platform/Comcast: add RDK Secure Boot application
a628fc23b0af Platform/Comcast: add RDK Disaster Recovery (DRI) Application
56df194bb8cd Platform/Comcast: add RDK Qemu platform for RDK UEFI applications

> ---

>  Platform/Comcast/RDKQemu/RDKQemu.dsc | 431 ++++++++++++++++++++

>  Platform/Comcast/RDKQemu/RDKQemu.fdf | 128 ++++++

>  Platform/Comcast/RDKQemu/README      |  73 ++++

>  3 files changed, 632 insertions(+)

>

> diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc b/Platform/Comcast/RDKQemu/RDKQemu.dsc

> new file mode 100644

> index 000000000000..f5c9f328a2ed

> --- /dev/null

> +++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc

> @@ -0,0 +1,431 @@

> +#

> +#  Copyright (c) 2011-2015, ARM Limited. All rights reserved.

> +#  Copyright (c) 2014 - 2018, Linaro Limited. All rights reserved.

> +#  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.

> +#

> +#  This program and the accompanying materials

> +#  are licensed and made available under the terms and conditions of the BSD License

> +#  which accompanies this distribution.  The full text of the license may be found at

> +#  http://opensource.org/licenses/bsd-license.php

> +#

> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

> +#

> +#

> +

> +################################################################################

> +#

> +# Defines Section - statements that will be processed to create a Makefile.

> +#

> +################################################################################

> +[Defines]

> +  PLATFORM_NAME                  = RdkQemu

> +  PLATFORM_GUID                  = 2D89EF13-B604-4550-B080-5E2E5E382854

> +  PLATFORM_VERSION               = 0.1

> +  DSC_SPECIFICATION              = 0x00010005

> +  OUTPUT_DIRECTORY               = Build/RDK-$(ARCH)

> +  SUPPORTED_ARCHITECTURES        = AARCH64|ARM

> +  BUILD_TARGETS                  = DEBUG|RELEASE

> +  SKUID_IDENTIFIER               = DEFAULT

> +  FLASH_DEFINITION               = Platform/Comcast/RDKQemu/RDKQemu.fdf

> +

> +  #

> +  # Defines for default states.  These can be changed on the command line.

> +  # -D FLAG=VALUE

> +  #

> +  DEFINE SECURE_BOOT_ENABLE      = TRUE

> +  DEFINE HTTP_BOOT_ENABLE        = TRUE

> +

> +!include ArmVirtPkg/ArmVirt.dsc.inc

> +

> +[LibraryClasses.common]

> +  ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf

> +  ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf

> +

> +  # Virtio Support

> +  VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf

> +  VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf

> +  QemuFwCfgLib|ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf

> +  QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf

> +

> +  ArmPlatformLib|ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf

> +

> +  TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf

> +  NorFlashPlatformLib|ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.inf

> +

> +  CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf

> +  BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf

> +  PlatformBootManagerLib|ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf

> +  CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf

> +  QemuBootOrderLib|OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.inf

> +  FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf

> +  PciPcdProducerLib|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf

> +  PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf

> +  PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf

> +  RdkBootManagerLib|Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.inf

> +!if $(HTTP_BOOT_ENABLE) == TRUE

> +  HttpLib|MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.inf

> +!endif

> +

> +[LibraryClasses.common.PEIM]

> +  ArmVirtMemInfoLib|ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoPeiLib.inf

> +

> +[LibraryClasses.common.UEFI_DRIVER]

> +  UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf

> +

> +################################################################################

> +#

> +# Pcd Section - list of all EDK II PCD Entries defined by this Platform

> +#

> +################################################################################

> +

> +[PcdsFeatureFlag.common]

> +  gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE

> +  gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE

> +

> +  ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.

> +  #  It could be set FALSE to save size.

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE

> +

> +[PcdsFixedAtBuild.common]

> +  gArmPlatformTokenSpaceGuid.PcdCoreCount|1

> +!if $(ARCH) == AARCH64

> +  gArmTokenSpaceGuid.PcdVFPEnabled|1

> +!endif

> +

> +  gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x4007c000

> +  gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x4000

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800

> +

> +  # Size of the region used by UEFI in permanent memory (Reserved 64MB)

> +  gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000

> +

> +  ## Trustzone enable (to make the transition from EL3 to EL2 in ArmPlatformPkg/Sec)

> +  gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE

> +

> +  #

> +  # ARM PrimeCell

> +  #

> +

> +  ## PL011 - Serial Terminal

> +  gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|38400

> +

> +  ## Default Terminal Type

> +  ## 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM

> +!if $(TTY_TERMINAL) == TRUE

> +  gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4

> +!else

> +  gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|1

> +!endif

> +

> +  #

> +  # ARM Virtual Architectural Timer -- fetch frequency from QEMU (TCG) or KVM

> +  #

> +  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0

> +

> +!if $(HTTP_BOOT_ENABLE) == TRUE

> +  gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE

> +!endif

> +  # System Memory Base -- fixed at 0x4000_0000

> +  gArmTokenSpaceGuid.PcdSystemMemoryBase|0x40000000

> +

> +  # initial location of the device tree blob passed by QEMU -- base of DRAM

> +  gArmVirtTokenSpaceGuid.PcdDeviceTreeInitialBaseAddress|0x40000000

> +

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }

> +

> +  #

> +  # The maximum physical I/O addressability of the processor, set with

> +  # BuildCpuHob().

> +  #

> +  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16

> +

> +  #

> +  # RdkPkg Pcds

> +  #

> +  # system partition name is nothing but rootfs partition, used only in Http boot (DRI)

> +  gRdkTokenSpaceGuid.PcdRdkSystemPartitionName|"VenHw(837DCA9E-E874-4D82-B29A-23FE0E23D1E2,003E000A00000000)"

> +  gRdkTokenSpaceGuid.PcdRdkCmdLineArgs|"root=/dev/vda"

> +  gRdkTokenSpaceGuid.PcdRdkConfFileName|L"Rdk.conf"

> +  gRdkTokenSpaceGuid.PcdRdkConfFileDevicePath|L"PciRoot(0x0)/Pci(0x2,0x0)"

> +

> +[PcdsFixedAtBuild.AARCH64]

> +  # KVM limits it IPA space to 40 bits (1 TB), so there is no need to

> +  # support anything bigger, even if the host hardware does

> +  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40

> +

> +  # Clearing BIT0 in this PCD prevents installing a 32-bit SMBIOS entry point,

> +  # if the entry point version is >= 3.0. AARCH64 OSes cannot assume the

> +  # presence of the 32-bit entry point anyway (because many AARCH64 systems

> +  # don't have 32-bit addressable physical RAM), and the additional allocations

> +  # below 4 GB needlessly fragment the memory map. So expose the 64-bit entry

> +  # point only, for entry point versions >= 3.0.

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosEntryPointProvideMethod|0x2

> +

> +  # ACPI predates the AARCH64 architecture by 5 versions, so

> +  # we only target OSes that support ACPI v5.0 or later

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20

> +

> +[PcdsDynamicDefault.common]

> +  gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3

> +

> +  ## If TRUE, OvmfPkg/AcpiPlatformDxe will not wait for PCI

> +  #  enumeration to complete before installing ACPI tables.

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|TRUE

> +

> +  # System Memory Size -- 1 MB initially, actual size will be fetched from DT

> +  gArmTokenSpaceGuid.PcdSystemMemorySize|0x00100000

> +

> +  gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0

> +  gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x0

> +  gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|0x0

> +  gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum|0x0

> +

> +  #

> +  # ARM General Interrupt Controller

> +  #

> +  gArmTokenSpaceGuid.PcdGicDistributorBase|0x0

> +  gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x0

> +  gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x0

> +

> +  ## PL031 RealTimeClock

> +  gArmPlatformTokenSpaceGuid.PcdPL031RtcBase|0x0

> +

> +  # set PcdPciExpressBaseAddress to MAX_UINT64, which signifies that this

> +  # PCD and PcdPciDisableBusEnumeration above have not been assigned yet

> +  gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xFFFFFFFFFFFFFFFF

> +

> +  gArmTokenSpaceGuid.PcdPciIoTranslation|0x0

> +

> +  #

> +  # Set video resolution for boot options and for text setup.

> +  # PlatformDxe can set the former at runtime.

> +  #

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|800

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoHorizontalResolution|640

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoVerticalResolution|480

> +

> +  #

> +  # SMBIOS entry point version

> +  #

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0300

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0

> +  gUefiOvmfPkgTokenSpaceGuid.PcdQemuSmbiosValidated|FALSE

> +

> +[PcdsDynamicHii]

> +  gArmVirtTokenSpaceGuid.PcdForceNoAcpi|L"ForceNoAcpi"|gArmVirtVariableGuid|0x0|FALSE|NV,BS

> +

> +################################################################################

> +#

> +# Components Section - list of all EDK II Modules needed by this Platform

> +#

> +################################################################################

> +[Components.common]

> +  #

> +  # PEI Phase modules

> +  #

> +  ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf

> +  MdeModulePkg/Core/Pei/PeiMain.inf

> +  MdeModulePkg/Universal/PCD/Pei/Pcd.inf {

> +    <LibraryClasses>

> +      PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf

> +  }

> +  ArmPlatformPkg/PlatformPei/PlatformPeim.inf

> +  ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf

> +  ArmPkg/Drivers/CpuPei/CpuPei.inf

> +

> +  MdeModulePkg/Universal/Variable/Pei/VariablePei.inf

> +

> +  MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {

> +    <LibraryClasses>

> +      NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf

> +  }

> +

> +  #

> +  # DXE

> +  #

> +  MdeModulePkg/Core/Dxe/DxeMain.inf {

> +    <LibraryClasses>

> +      NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf

> +  }

> +  MdeModulePkg/Universal/PCD/Dxe/Pcd.inf {

> +    <LibraryClasses>

> +      PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf

> +  }

> +

> +  #

> +  # Architectural Protocols

> +  #

> +  ArmPkg/Drivers/CpuDxe/CpuDxe.inf

> +  MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf

> +  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {

> +    <LibraryClasses>

> +      NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf

> +      # don't use unaligned CopyMem () on the UEFI varstore NOR flash region

> +      BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf

> +  }

> +!if $(SECURE_BOOT_ENABLE) == TRUE

> +  MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf {

> +    <LibraryClasses>

> +      NULL|SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.inf

> +  }

> +  SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf

> +!else

> +  MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf

> +!endif

> +  MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf

> +  MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf

> +  MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf

> +  MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf

> +  EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf {

> +    <LibraryClasses>

> +      NULL|ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.inf

> +  }

> +  EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf

> +

> +  MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf

> +  MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf

> +  MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf

> +  MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf

> +  MdeModulePkg/Universal/SerialDxe/SerialDxe.inf

> +

> +  MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf

> +

> +  ArmPkg/Drivers/ArmGic/ArmGicDxe.inf

> +  ArmPkg/Drivers/TimerDxe/TimerDxe.inf {

> +    <LibraryClasses>

> +      NULL|ArmVirtPkg/Library/ArmVirtTimerFdtClientLib/ArmVirtTimerFdtClientLib.inf

> +  }

> +  ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf

> +  MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf

> +

> +  #

> +  # Platform Driver

> +  #

> +  ArmVirtPkg/VirtioFdtDxe/VirtioFdtDxe.inf

> +  ArmVirtPkg/FdtClientDxe/FdtClientDxe.inf

> +  ArmVirtPkg/HighMemDxe/HighMemDxe.inf

> +  OvmfPkg/VirtioBlkDxe/VirtioBlk.inf

> +  OvmfPkg/VirtioScsiDxe/VirtioScsi.inf

> +  OvmfPkg/VirtioNetDxe/VirtioNet.inf

> +  OvmfPkg/VirtioRngDxe/VirtioRng.inf

> +

> +  #

> +  # FAT filesystem + GPT/MBR partitioning + UDF filesystem

> +  #

> +  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf

> +  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf

> +  MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf

> +  FatPkg/EnhancedFatDxe/Fat.inf

> +  MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf

> +

> +  #

> +  # Bds

> +  #

> +  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf

> +  MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf

> +  MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf

> +  MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf

> +  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf

> +  MdeModulePkg/Logo/LogoDxe.inf

> +  MdeModulePkg/Application/UiApp/UiApp.inf {

> +    <LibraryClasses>

> +      NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf

> +      NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf

> +      NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf

> +  }

> +

> +  #

> +  # Networking stack

> +  #

> +  MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf

> +  MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf

> +  MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf

> +  MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf

> +  MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf

> +  MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf

> +  MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf

> +  MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf

> +  MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf

> +  MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf

> +  MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf

> +!if $(HTTP_BOOT_ENABLE) == TRUE

> +  NetworkPkg/DnsDxe/DnsDxe.inf

> +  NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf

> +  NetworkPkg/HttpDxe/HttpDxe.inf

> +  NetworkPkg/HttpBootDxe/HttpBootDxe.inf

> +!endif

> +  #

> +  # SCSI Bus and Disk Driver

> +  #

> +  MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf

> +  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf

> +

> +  #

> +  # SMBIOS Support

> +  #

> +  MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf {

> +    <LibraryClasses>

> +      NULL|OvmfPkg/Library/SmbiosVersionLib/DetectSmbiosVersionLib.inf

> +  }

> +  OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf

> +

> +  #

> +  # PCI support

> +  #

> +  ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf {

> +    <LibraryClasses>

> +      NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf

> +  }

> +  MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf

> +  MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf {

> +    <LibraryClasses>

> +      NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf

> +  }

> +  OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf

> +  OvmfPkg/Virtio10Dxe/Virtio10.inf

> +

> +  #

> +  # Video support

> +  #

> +  OvmfPkg/VirtioGpuDxe/VirtioGpu.inf

> +  OvmfPkg/PlatformDxe/Platform.inf

> +

> +  #

> +  # USB Support

> +  #

> +  MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf

> +  MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf

> +  MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf

> +  MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf

> +  MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf

> +  MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf

> +

> +  #

> +  # ACPI Support

> +  #

> +  ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf

> +

> +  #

> +  # RdkPkg

> +  #

> +  Platform/Comcast/Application/Dri/Dri.inf

> +  Platform/Comcast/Application/SecureBoot/SecureBoot.inf

> +  Platform/Comcast/Application/DriSecureBoot/DriSecureBoot.inf

> +

> +[Components.AARCH64]

> +  MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf

> +  OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf {

> +    <LibraryClasses>

> +      NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf

> +  }

> +

> +[PcdsFixedAtBuild]

> +  gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE

> +

> +[BuildOptions]

> +  GCC:*_*_*_CC_FLAGS = -UDISABLE_NEW_DEPRECATED_INTERFACES

> diff --git a/Platform/Comcast/RDKQemu/RDKQemu.fdf b/Platform/Comcast/RDKQemu/RDKQemu.fdf

> new file mode 100644

> index 000000000000..2ff7bef08adf

> --- /dev/null

> +++ b/Platform/Comcast/RDKQemu/RDKQemu.fdf

> @@ -0,0 +1,128 @@

> +#

> +#  Copyright (c) 2011-2015, ARM Limited. All rights reserved.

> +#  Copyright (c) 2014 - 2018, Linaro Limited. All rights reserved.

> +#  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.

> +#

> +#  This program and the accompanying materials

> +#  are licensed and made available under the terms and conditions of the BSD License

> +#  which accompanies this distribution.  The full text of the license may be found at

> +#  http://opensource.org/licenses/bsd-license.php

> +#

> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

> +#

> +

> +################################################################################

> +#

> +# FD Section

> +# The [FD] Section is made up of the definition statements and a

> +# description of what goes into  the Flash Device Image.  Each FD section

> +# defines one flash "device" image.  A flash device image may be one of

> +# the following: Removable media bootable image (like a boot floppy

> +# image,) an Option ROM image (that would be "flashed" into an add-in

> +# card,) a System "Flash"  image (that would be burned into a system's

> +# flash) or an Update ("Capsule") image that will be used to update and

> +# existing system flash.

> +#

> +################################################################################

> +

> +[FD.RDK_EFI]

> +BaseAddress   = 0x00000000|gArmTokenSpaceGuid.PcdFdBaseAddress  # QEMU assigns 0 - 0x8000000 for a BootROM

> +Size          = 0x00200000|gArmTokenSpaceGuid.PcdFdSize         # The size in bytes of the FLASH Device

> +ErasePolarity = 1

> +

> +# This one is tricky, it must be: BlockSize * NumBlocks = Size

> +BlockSize     = 0x00001000

> +NumBlocks     = 0x200

> +

> +################################################################################

> +#

> +# Following are lists of FD Region layout which correspond to the locations of different

> +# images within the flash device.

> +#

> +# Regions must be defined in ascending order and may not overlap.

> +#

> +# A Layout Region start with a eight digit hex offset (leading "0x" required) followed by

> +# the pipe "|" character, followed by the size of the region, also in hex with the leading

> +# "0x" characters. Like:

> +# Offset|Size

> +# PcdOffsetCName|PcdSizeCName

> +# RegionType <FV, DATA, or FILE>

> +#

> +################################################################################

> +

> +#

> +# UEFI has trouble dealing with FVs that reside at physical address 0x0.

> +# So instead, put a hardcoded 'jump to 0x1000' at offset 0x0, and put the

> +# real FV at offset 0x1000

> +#

> +0x00000000|0x00001000

> +DATA = {

> +!if $(ARCH) == AARCH64

> +  0x00, 0x04, 0x00, 0x14   # 'b 0x1000' in AArch64 ASM

> +!else

> +  0xfe, 0x03, 0x00, 0xea   # 'b 0x1000' in AArch32 ASM

> +!endif

> +}

> +

> +0x00001000|0x001ff000

> +gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize

> +FV = FVMAIN_COMPACT

> +

> +!include ArmVirtPkg/VarStore.fdf.inc

> +

> +################################################################################

> +#

> +# FV Section

> +#

> +# [FV] section is used to define what components or modules are placed within a flash

> +# device file.  This section also defines order the components and modules are positioned

> +# within the image.  The [FV] section consists of define statements, set statements and

> +# module statements.

> +#

> +################################################################################

> +

> +!include ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc

> +

> +[FV.FVMAIN_COMPACT]

> +#FvNameGuid         = 64074afe-340a-4be6-94ba-91b5b4d0d412

> +FvAlignment        = 16

> +ERASE_POLARITY     = 1

> +MEMORY_MAPPED      = TRUE

> +STICKY_WRITE       = TRUE

> +LOCK_CAP           = TRUE

> +LOCK_STATUS        = TRUE

> +WRITE_DISABLED_CAP = TRUE

> +WRITE_ENABLED_CAP  = TRUE

> +WRITE_STATUS       = TRUE

> +WRITE_LOCK_CAP     = TRUE

> +WRITE_LOCK_STATUS  = TRUE

> +READ_DISABLED_CAP  = TRUE

> +READ_ENABLED_CAP   = TRUE

> +READ_STATUS        = TRUE

> +READ_LOCK_CAP      = TRUE

> +READ_LOCK_STATUS   = TRUE

> +

> +  INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf

> +  INF MdeModulePkg/Core/Pei/PeiMain.inf

> +  INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf

> +  INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf

> +  INF ArmPkg/Drivers/CpuPei/CpuPei.inf

> +  INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf

> +  INF MdeModulePkg/Universal/Variable/Pei/VariablePei.inf

> +  INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf

> +

> +  #

> +  # FDT installation

> +  #

> +  # The UEFI driver is at the end of the list of the driver to be dispatched

> +  # after the device drivers (eg: Ethernet) to ensure we have support for them.

> +  #INF Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf

> +

> +  FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {

> +    SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED = TRUE {

> +      SECTION FV_IMAGE = FVMAIN

> +    }

> +  }

> +

> +!include ArmVirtPkg/ArmVirtRules.fdf.inc

> diff --git a/Platform/Comcast/RDKQemu/README b/Platform/Comcast/RDKQemu/README

> new file mode 100644

> index 000000000000..d03de725ed23

> --- /dev/null

> +++ b/Platform/Comcast/RDKQemu/README

> @@ -0,0 +1,73 @@

> +workspace structure:

> +--------------------

> +

> +base directory

> +    |__ edk2

> +    |__ edk2-platforms

> +    |__ uefi-tools

> +

> +Prerequisites:

> +--------------

> +

> +Before building EDK-II UEFI, prepare base tools

> +$ cd edk2

> +$ make -C BaseTools

> +$ cd ..

> +

> +Application can be tested:

> +-------------------------

> +1) Secure boot

> +2) Disaster Recovery Image (DRI) download

> +3) DRI Secure boot

> +

> +above applications source code path- edk2-platforms/Platform/Comcast/Application

> +

> +QEMU setup:

> +-----------

> +$ qemu-system-aarch64 -cpu cortex-a57 -M virt -m 512M -bios RDK_EFI.fd -nographic -no-acpi -hda bootpartition.img -hdb fat:keys -drive if=none,file=rootfs.img,format=raw,id=hd0 -device virtio-blk-device,drive=hd0

> +

> +hdb: a directory which contains KEK.cer and PK.cer (public key) files

> +

> +hda: bootpartition.img

> +

> +$ dd if=/dev/zero bs=1M count=64 of=bootpartition.img

> +$ mkfs.vfat -F 32 bootpartition.img

> +$ sudo mount bootpartition.img /mnt

> +#copy kernel image file (for secure boot), Rdk.conf configuration file, server.url file

> +$ sudo cp <files> /mnt

> +$ sudo umount /mnt

> +

> +Configuration file:

> +

> +RDK Secure boot application accepts 6 configuration

> +ROOTCERT - key file to validate rootfs

> +KEKCERT - KEK public Key

> +PKCERT - PK public key

> +URL - a text file that contains server URL where DRI image is stored

> +IMAGE - kernel image file

> +DTB - Device tree blob file

> +

> +# rdk conf file for getting PK, KEK and kernel file path in flash partitions

> +Typical Rdk.conf file:

> +################################################################

> +KEKCERT="PciRoot(0x0)/Pci(0x3,0x0)/HD(1,MBR,0xBE1AFDFA,0x3F,0xFBFC1)/KEK.cer"

> +PKCERT="PciRoot(0x0)/Pci(0x3,0x0)/HD(1,MBR,0xBE1AFDFA,0x3F,0xFBFC1)/PK.cer"

> +URL="PciRoot(0x0)/Pci(0x2,0x0)/server.url"

> +IMAGE="PciRoot(0x0)/Pci(0x2,0x0)/Image"

> +################################################################

> +

> +server.url:

> +

> +contains the url path to HTTP image (rootfs + kernel + dtb)

> +Eg. http://xx.xx.xx.xx/path/http.img

> +

> +http.img formation:

> +

> +$ touch tmp

> +$ printf "%016d" `stat -c "%s" rootfs.img` >> tmp

> +$ cat rootfs.img >> tmp

> +$ printf "%016d" `stat -c "%s" kernelSignedImage` >> tmp

> +$ cat kernelSignedImage >> tmp

> +$ printf "%016d" `stat -c "%s" dtb` >> tmp

> +$ cat dtb >> tmp

> +$ mv tmp http.img

> --

> 2.15.0

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox series

Patch

diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc b/Platform/Comcast/RDKQemu/RDKQemu.dsc
new file mode 100644
index 000000000000..f5c9f328a2ed
--- /dev/null
+++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc
@@ -0,0 +1,431 @@ 
+#
+#  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
+#  Copyright (c) 2014 - 2018, Linaro Limited. All rights reserved.
+#  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
+#
+#  This program and the accompanying materials
+#  are licensed and made available under the terms and conditions of the BSD License
+#  which accompanies this distribution.  The full text of the license may be found at
+#  http://opensource.org/licenses/bsd-license.php
+#
+#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+#
+
+################################################################################
+#
+# Defines Section - statements that will be processed to create a Makefile.
+#
+################################################################################
+[Defines]
+  PLATFORM_NAME                  = RdkQemu
+  PLATFORM_GUID                  = 2D89EF13-B604-4550-B080-5E2E5E382854
+  PLATFORM_VERSION               = 0.1
+  DSC_SPECIFICATION              = 0x00010005
+  OUTPUT_DIRECTORY               = Build/RDK-$(ARCH)
+  SUPPORTED_ARCHITECTURES        = AARCH64|ARM
+  BUILD_TARGETS                  = DEBUG|RELEASE
+  SKUID_IDENTIFIER               = DEFAULT
+  FLASH_DEFINITION               = Platform/Comcast/RDKQemu/RDKQemu.fdf
+
+  #
+  # Defines for default states.  These can be changed on the command line.
+  # -D FLAG=VALUE
+  #
+  DEFINE SECURE_BOOT_ENABLE      = TRUE
+  DEFINE HTTP_BOOT_ENABLE        = TRUE
+
+!include ArmVirtPkg/ArmVirt.dsc.inc
+
+[LibraryClasses.common]
+  ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
+  ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
+
+  # Virtio Support
+  VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf
+  VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf
+  QemuFwCfgLib|ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf
+  QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf
+
+  ArmPlatformLib|ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
+
+  TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
+  NorFlashPlatformLib|ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.inf
+
+  CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
+  BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
+  PlatformBootManagerLib|ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
+  CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
+  QemuBootOrderLib|OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.inf
+  FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
+  PciPcdProducerLib|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
+  PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf
+  PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
+  RdkBootManagerLib|Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.inf
+!if $(HTTP_BOOT_ENABLE) == TRUE
+  HttpLib|MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.inf
+!endif
+
+[LibraryClasses.common.PEIM]
+  ArmVirtMemInfoLib|ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoPeiLib.inf
+
+[LibraryClasses.common.UEFI_DRIVER]
+  UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf
+
+################################################################################
+#
+# Pcd Section - list of all EDK II PCD Entries defined by this Platform
+#
+################################################################################
+
+[PcdsFeatureFlag.common]
+  gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
+  gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
+
+  ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
+  #  It could be set FALSE to save size.
+  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
+  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
+
+[PcdsFixedAtBuild.common]
+  gArmPlatformTokenSpaceGuid.PcdCoreCount|1
+!if $(ARCH) == AARCH64
+  gArmTokenSpaceGuid.PcdVFPEnabled|1
+!endif
+
+  gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x4007c000
+  gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x4000
+  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
+  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800
+
+  # Size of the region used by UEFI in permanent memory (Reserved 64MB)
+  gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000
+
+  ## Trustzone enable (to make the transition from EL3 to EL2 in ArmPlatformPkg/Sec)
+  gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE
+
+  #
+  # ARM PrimeCell
+  #
+
+  ## PL011 - Serial Terminal
+  gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|38400
+
+  ## Default Terminal Type
+  ## 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM
+!if $(TTY_TERMINAL) == TRUE
+  gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
+!else
+  gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|1
+!endif
+
+  #
+  # ARM Virtual Architectural Timer -- fetch frequency from QEMU (TCG) or KVM
+  #
+  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
+
+!if $(HTTP_BOOT_ENABLE) == TRUE
+  gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
+!endif
+  # System Memory Base -- fixed at 0x4000_0000
+  gArmTokenSpaceGuid.PcdSystemMemoryBase|0x40000000
+
+  # initial location of the device tree blob passed by QEMU -- base of DRAM
+  gArmVirtTokenSpaceGuid.PcdDeviceTreeInitialBaseAddress|0x40000000
+
+  gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
+  gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
+
+  #
+  # The maximum physical I/O addressability of the processor, set with
+  # BuildCpuHob().
+  #
+  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16
+
+  #
+  # RdkPkg Pcds
+  #
+  # system partition name is nothing but rootfs partition, used only in Http boot (DRI)
+  gRdkTokenSpaceGuid.PcdRdkSystemPartitionName|"VenHw(837DCA9E-E874-4D82-B29A-23FE0E23D1E2,003E000A00000000)"
+  gRdkTokenSpaceGuid.PcdRdkCmdLineArgs|"root=/dev/vda"
+  gRdkTokenSpaceGuid.PcdRdkConfFileName|L"Rdk.conf"
+  gRdkTokenSpaceGuid.PcdRdkConfFileDevicePath|L"PciRoot(0x0)/Pci(0x2,0x0)"
+
+[PcdsFixedAtBuild.AARCH64]
+  # KVM limits it IPA space to 40 bits (1 TB), so there is no need to
+  # support anything bigger, even if the host hardware does
+  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40
+
+  # Clearing BIT0 in this PCD prevents installing a 32-bit SMBIOS entry point,
+  # if the entry point version is >= 3.0. AARCH64 OSes cannot assume the
+  # presence of the 32-bit entry point anyway (because many AARCH64 systems
+  # don't have 32-bit addressable physical RAM), and the additional allocations
+  # below 4 GB needlessly fragment the memory map. So expose the 64-bit entry
+  # point only, for entry point versions >= 3.0.
+  gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosEntryPointProvideMethod|0x2
+
+  # ACPI predates the AARCH64 architecture by 5 versions, so
+  # we only target OSes that support ACPI v5.0 or later
+  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
+
+[PcdsDynamicDefault.common]
+  gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3
+
+  ## If TRUE, OvmfPkg/AcpiPlatformDxe will not wait for PCI
+  #  enumeration to complete before installing ACPI tables.
+  gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|TRUE
+
+  # System Memory Size -- 1 MB initially, actual size will be fetched from DT
+  gArmTokenSpaceGuid.PcdSystemMemorySize|0x00100000
+
+  gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0
+  gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x0
+  gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|0x0
+  gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum|0x0
+
+  #
+  # ARM General Interrupt Controller
+  #
+  gArmTokenSpaceGuid.PcdGicDistributorBase|0x0
+  gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x0
+  gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x0
+
+  ## PL031 RealTimeClock
+  gArmPlatformTokenSpaceGuid.PcdPL031RtcBase|0x0
+
+  # set PcdPciExpressBaseAddress to MAX_UINT64, which signifies that this
+  # PCD and PcdPciDisableBusEnumeration above have not been assigned yet
+  gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xFFFFFFFFFFFFFFFF
+
+  gArmTokenSpaceGuid.PcdPciIoTranslation|0x0
+
+  #
+  # Set video resolution for boot options and for text setup.
+  # PlatformDxe can set the former at runtime.
+  #
+  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|800
+  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
+  gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoHorizontalResolution|640
+  gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoVerticalResolution|480
+
+  #
+  # SMBIOS entry point version
+  #
+  gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0300
+  gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0
+  gUefiOvmfPkgTokenSpaceGuid.PcdQemuSmbiosValidated|FALSE
+
+[PcdsDynamicHii]
+  gArmVirtTokenSpaceGuid.PcdForceNoAcpi|L"ForceNoAcpi"|gArmVirtVariableGuid|0x0|FALSE|NV,BS
+
+################################################################################
+#
+# Components Section - list of all EDK II Modules needed by this Platform
+#
+################################################################################
+[Components.common]
+  #
+  # PEI Phase modules
+  #
+  ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+  MdeModulePkg/Core/Pei/PeiMain.inf
+  MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
+    <LibraryClasses>
+      PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
+  }
+  ArmPlatformPkg/PlatformPei/PlatformPeim.inf
+  ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
+  ArmPkg/Drivers/CpuPei/CpuPei.inf
+
+  MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
+
+  MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
+    <LibraryClasses>
+      NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+  }
+
+  #
+  # DXE
+  #
+  MdeModulePkg/Core/Dxe/DxeMain.inf {
+    <LibraryClasses>
+      NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
+  }
+  MdeModulePkg/Universal/PCD/Dxe/Pcd.inf {
+    <LibraryClasses>
+      PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
+  }
+
+  #
+  # Architectural Protocols
+  #
+  ArmPkg/Drivers/CpuDxe/CpuDxe.inf
+  MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
+  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {
+    <LibraryClasses>
+      NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
+      # don't use unaligned CopyMem () on the UEFI varstore NOR flash region
+      BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
+  }
+!if $(SECURE_BOOT_ENABLE) == TRUE
+  MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf {
+    <LibraryClasses>
+      NULL|SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.inf
+  }
+  SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf
+!else
+  MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
+!endif
+  MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
+  MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf
+  MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf
+  MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf
+  EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf {
+    <LibraryClasses>
+      NULL|ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.inf
+  }
+  EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
+
+  MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
+  MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
+  MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
+  MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
+  MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
+
+  MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
+
+  ArmPkg/Drivers/ArmGic/ArmGicDxe.inf
+  ArmPkg/Drivers/TimerDxe/TimerDxe.inf {
+    <LibraryClasses>
+      NULL|ArmVirtPkg/Library/ArmVirtTimerFdtClientLib/ArmVirtTimerFdtClientLib.inf
+  }
+  ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
+  MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
+
+  #
+  # Platform Driver
+  #
+  ArmVirtPkg/VirtioFdtDxe/VirtioFdtDxe.inf
+  ArmVirtPkg/FdtClientDxe/FdtClientDxe.inf
+  ArmVirtPkg/HighMemDxe/HighMemDxe.inf
+  OvmfPkg/VirtioBlkDxe/VirtioBlk.inf
+  OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
+  OvmfPkg/VirtioNetDxe/VirtioNet.inf
+  OvmfPkg/VirtioRngDxe/VirtioRng.inf
+
+  #
+  # FAT filesystem + GPT/MBR partitioning + UDF filesystem
+  #
+  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
+  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
+  MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
+  FatPkg/EnhancedFatDxe/Fat.inf
+  MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
+
+  #
+  # Bds
+  #
+  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
+  MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
+  MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
+  MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf
+  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
+  MdeModulePkg/Logo/LogoDxe.inf
+  MdeModulePkg/Application/UiApp/UiApp.inf {
+    <LibraryClasses>
+      NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
+      NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
+      NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
+  }
+
+  #
+  # Networking stack
+  #
+  MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
+  MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
+  MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
+  MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
+  MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
+  MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
+  MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
+  MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
+  MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
+  MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
+  MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
+!if $(HTTP_BOOT_ENABLE) == TRUE
+  NetworkPkg/DnsDxe/DnsDxe.inf
+  NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
+  NetworkPkg/HttpDxe/HttpDxe.inf
+  NetworkPkg/HttpBootDxe/HttpBootDxe.inf
+!endif
+  #
+  # SCSI Bus and Disk Driver
+  #
+  MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
+  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
+
+  #
+  # SMBIOS Support
+  #
+  MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf {
+    <LibraryClasses>
+      NULL|OvmfPkg/Library/SmbiosVersionLib/DetectSmbiosVersionLib.inf
+  }
+  OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
+
+  #
+  # PCI support
+  #
+  ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf {
+    <LibraryClasses>
+      NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
+  }
+  MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
+  MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf {
+    <LibraryClasses>
+      NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
+  }
+  OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf
+  OvmfPkg/Virtio10Dxe/Virtio10.inf
+
+  #
+  # Video support
+  #
+  OvmfPkg/VirtioGpuDxe/VirtioGpu.inf
+  OvmfPkg/PlatformDxe/Platform.inf
+
+  #
+  # USB Support
+  #
+  MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf
+  MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf
+  MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
+  MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
+  MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
+  MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
+
+  #
+  # ACPI Support
+  #
+  ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf
+
+  #
+  # RdkPkg
+  #
+  Platform/Comcast/Application/Dri/Dri.inf
+  Platform/Comcast/Application/SecureBoot/SecureBoot.inf
+  Platform/Comcast/Application/DriSecureBoot/DriSecureBoot.inf
+
+[Components.AARCH64]
+  MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
+  OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf {
+    <LibraryClasses>
+      NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
+  }
+
+[PcdsFixedAtBuild]
+  gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
+
+[BuildOptions]
+  GCC:*_*_*_CC_FLAGS = -UDISABLE_NEW_DEPRECATED_INTERFACES
diff --git a/Platform/Comcast/RDKQemu/RDKQemu.fdf b/Platform/Comcast/RDKQemu/RDKQemu.fdf
new file mode 100644
index 000000000000..2ff7bef08adf
--- /dev/null
+++ b/Platform/Comcast/RDKQemu/RDKQemu.fdf
@@ -0,0 +1,128 @@ 
+#
+#  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
+#  Copyright (c) 2014 - 2018, Linaro Limited. All rights reserved.
+#  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
+#
+#  This program and the accompanying materials
+#  are licensed and made available under the terms and conditions of the BSD License
+#  which accompanies this distribution.  The full text of the license may be found at
+#  http://opensource.org/licenses/bsd-license.php
+#
+#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+
+################################################################################
+#
+# FD Section
+# The [FD] Section is made up of the definition statements and a
+# description of what goes into  the Flash Device Image.  Each FD section
+# defines one flash "device" image.  A flash device image may be one of
+# the following: Removable media bootable image (like a boot floppy
+# image,) an Option ROM image (that would be "flashed" into an add-in
+# card,) a System "Flash"  image (that would be burned into a system's
+# flash) or an Update ("Capsule") image that will be used to update and
+# existing system flash.
+#
+################################################################################
+
+[FD.RDK_EFI]
+BaseAddress   = 0x00000000|gArmTokenSpaceGuid.PcdFdBaseAddress  # QEMU assigns 0 - 0x8000000 for a BootROM
+Size          = 0x00200000|gArmTokenSpaceGuid.PcdFdSize         # The size in bytes of the FLASH Device
+ErasePolarity = 1
+
+# This one is tricky, it must be: BlockSize * NumBlocks = Size
+BlockSize     = 0x00001000
+NumBlocks     = 0x200
+
+################################################################################
+#
+# Following are lists of FD Region layout which correspond to the locations of different
+# images within the flash device.
+#
+# Regions must be defined in ascending order and may not overlap.
+#
+# A Layout Region start with a eight digit hex offset (leading "0x" required) followed by
+# the pipe "|" character, followed by the size of the region, also in hex with the leading
+# "0x" characters. Like:
+# Offset|Size
+# PcdOffsetCName|PcdSizeCName
+# RegionType <FV, DATA, or FILE>
+#
+################################################################################
+
+#
+# UEFI has trouble dealing with FVs that reside at physical address 0x0.
+# So instead, put a hardcoded 'jump to 0x1000' at offset 0x0, and put the
+# real FV at offset 0x1000
+#
+0x00000000|0x00001000
+DATA = {
+!if $(ARCH) == AARCH64
+  0x00, 0x04, 0x00, 0x14   # 'b 0x1000' in AArch64 ASM
+!else
+  0xfe, 0x03, 0x00, 0xea   # 'b 0x1000' in AArch32 ASM
+!endif
+}
+
+0x00001000|0x001ff000
+gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize
+FV = FVMAIN_COMPACT
+
+!include ArmVirtPkg/VarStore.fdf.inc
+
+################################################################################
+#
+# FV Section
+#
+# [FV] section is used to define what components or modules are placed within a flash
+# device file.  This section also defines order the components and modules are positioned
+# within the image.  The [FV] section consists of define statements, set statements and
+# module statements.
+#
+################################################################################
+
+!include ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
+
+[FV.FVMAIN_COMPACT]
+#FvNameGuid         = 64074afe-340a-4be6-94ba-91b5b4d0d412
+FvAlignment        = 16
+ERASE_POLARITY     = 1
+MEMORY_MAPPED      = TRUE
+STICKY_WRITE       = TRUE
+LOCK_CAP           = TRUE
+LOCK_STATUS        = TRUE
+WRITE_DISABLED_CAP = TRUE
+WRITE_ENABLED_CAP  = TRUE
+WRITE_STATUS       = TRUE
+WRITE_LOCK_CAP     = TRUE
+WRITE_LOCK_STATUS  = TRUE
+READ_DISABLED_CAP  = TRUE
+READ_ENABLED_CAP   = TRUE
+READ_STATUS        = TRUE
+READ_LOCK_CAP      = TRUE
+READ_LOCK_STATUS   = TRUE
+
+  INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+  INF MdeModulePkg/Core/Pei/PeiMain.inf
+  INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
+  INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
+  INF ArmPkg/Drivers/CpuPei/CpuPei.inf
+  INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
+  INF MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
+  INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
+
+  #
+  # FDT installation
+  #
+  # The UEFI driver is at the end of the list of the driver to be dispatched
+  # after the device drivers (eg: Ethernet) to ensure we have support for them.
+  #INF Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf
+
+  FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {
+    SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED = TRUE {
+      SECTION FV_IMAGE = FVMAIN
+    }
+  }
+
+!include ArmVirtPkg/ArmVirtRules.fdf.inc
diff --git a/Platform/Comcast/RDKQemu/README b/Platform/Comcast/RDKQemu/README
new file mode 100644
index 000000000000..d03de725ed23
--- /dev/null
+++ b/Platform/Comcast/RDKQemu/README
@@ -0,0 +1,73 @@ 
+workspace structure:
+--------------------
+
+base directory
+    |__ edk2
+    |__ edk2-platforms
+    |__ uefi-tools
+
+Prerequisites:
+--------------
+
+Before building EDK-II UEFI, prepare base tools
+$ cd edk2
+$ make -C BaseTools
+$ cd ..
+
+Application can be tested:
+-------------------------
+1) Secure boot
+2) Disaster Recovery Image (DRI) download
+3) DRI Secure boot
+
+above applications source code path- edk2-platforms/Platform/Comcast/Application
+
+QEMU setup:
+-----------
+$ qemu-system-aarch64 -cpu cortex-a57 -M virt -m 512M -bios RDK_EFI.fd -nographic -no-acpi -hda bootpartition.img -hdb fat:keys -drive if=none,file=rootfs.img,format=raw,id=hd0 -device virtio-blk-device,drive=hd0
+
+hdb: a directory which contains KEK.cer and PK.cer (public key) files
+
+hda: bootpartition.img
+
+$ dd if=/dev/zero bs=1M count=64 of=bootpartition.img
+$ mkfs.vfat -F 32 bootpartition.img
+$ sudo mount bootpartition.img /mnt
+#copy kernel image file (for secure boot), Rdk.conf configuration file, server.url file
+$ sudo cp <files> /mnt
+$ sudo umount /mnt
+
+Configuration file:
+
+RDK Secure boot application accepts 6 configuration
+ROOTCERT - key file to validate rootfs
+KEKCERT - KEK public Key
+PKCERT - PK public key
+URL - a text file that contains server URL where DRI image is stored
+IMAGE - kernel image file
+DTB - Device tree blob file
+
+# rdk conf file for getting PK, KEK and kernel file path in flash partitions
+Typical Rdk.conf file:
+################################################################
+KEKCERT="PciRoot(0x0)/Pci(0x3,0x0)/HD(1,MBR,0xBE1AFDFA,0x3F,0xFBFC1)/KEK.cer"
+PKCERT="PciRoot(0x0)/Pci(0x3,0x0)/HD(1,MBR,0xBE1AFDFA,0x3F,0xFBFC1)/PK.cer"
+URL="PciRoot(0x0)/Pci(0x2,0x0)/server.url"
+IMAGE="PciRoot(0x0)/Pci(0x2,0x0)/Image"
+################################################################
+
+server.url:
+
+contains the url path to HTTP image (rootfs + kernel + dtb)
+Eg. http://xx.xx.xx.xx/path/http.img
+
+http.img formation:
+
+$ touch tmp
+$ printf "%016d" `stat -c "%s" rootfs.img` >> tmp
+$ cat rootfs.img >> tmp
+$ printf "%016d" `stat -c "%s" kernelSignedImage` >> tmp
+$ cat kernelSignedImage >> tmp
+$ printf "%016d" `stat -c "%s" dtb` >> tmp
+$ cat dtb >> tmp
+$ mv tmp http.img