| Message ID | 20180501213114.20183-1-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC] driver core: make deferring probe forever optional | expand |
On Fri, May 4, 2018 at 8:25 PM, Mark Brown <broonie@kernel.org> wrote: > On Wed, May 02, 2018 at 07:49:57PM +0100, Robin Murphy wrote: > >> I guess there's also the possibility that a single driver may want multiple >> behaviours, if e.g. if SoC variants A and B have some identical peripherals >> but slightly different pinctrl/IOMMU/etc. hardware such that A has workable >> default behaviour and can be treated as optional, whereas B absolutely must >> be controlled by the kernel for the consumers to function properly, and they >> *should* defer forever otherwise. I think that would pretty much demand some >> sort of explicitly-curated white/blacklist setup at the subsystem or driver >> level. > > Different board variants, and possibly even different bootloaders might > also be an issue here - a vendor bootloader might do pinmuxing that an > upstream bootloader doesn't for example. In some cases the pinmuxing > even depends on the boot method with things only getting configured if > the bootloader wanted to use them. I think this is going to be too big of a hammer for pinctrl at least. My current thought is to define a pinctrl DT property to indicate pins are configured already which the OS can use to decide if pinctrl is optional or not. I'd prefer to keep it simple and be a per pin controller flag even though this is quite possibly a per client or pin group state (as you say, the bootloader may only configure what it uses). Making this per pin group could be a lot of nodes and difficult to really get right without testing. Making it per pin controller could make drivers fail in less predictable ways if their pins are not configured. Rob
On Mon 07 May 12:55 PDT 2018, Rob Herring wrote: > On Mon, May 7, 2018 at 1:31 PM, Bjorn Andersson > <bjorn.andersson@linaro.org> wrote: > > On Tue 01 May 14:31 PDT 2018, Rob Herring wrote: > > > >> Deferred probe will currently wait forever on dependent devices to probe, > >> but sometimes a driver will never exist. It's also not always critical for > >> a driver to exist. Platforms can rely on default configuration from the > >> bootloader or reset defaults for things such as pinctrl and power domains. > > > > But how do you know if this is the case? > > Because the platform worked before adding the dependency in the dts. > I'm worried about how to write dts files and drivers to support all permutation of forward and backward dependencies. And you most definitely have the same case with bootloader-enabled clocks, regulators and interconnects. > >> This is often the case with initial platform support until various drivers > >> get enabled. > > > > Can you please name platform that has enough support for Alexander to > > care about backwards and forwards compatibility but lacks a pinctrl > > driver. > > Alex will have to answer that. I do agree pinctrl drivers shouldn't be > that hard because it is all just translating a bunch of pin data into > one-time (mostly) register writes, so it shouldn't take that long to > implement support. OTOH, maybe a pinctrl driver is low priority > because nothing needs it yet. Either a given board works with the > defaults and only some new board needs to change things or you don't > need pinctrl until low power modes are implemented. However, power > domains have the same problem and it can take years for those to get > proper support. > > Alex proposed declaring dts files stable and then enforcing > compatibility after that point. If anyone believes that will work, > then please send a patch marking all the platforms in the kernel tree > that are stable. > That might be a reasonable idea, but at least in our corner the current decision that devicetree should be backwards compatible does make it quite cumbersome to break this assumption - and in the cases we have had to do it it's really been necessary. > >> There's at least 2 scenarios where deferred probe can render > >> a platform broken. Both involve using a DT which has more devices and > >> dependencies than the kernel supports. The 1st case is a driver may be > >> disabled in the kernel config. > > > > I agree that there is a chance that you _might_ get some parts of the > > system working by relying on the boot loader configuration, but > > misconfiguration issues applies to any other fundamental providers, such > > as clocks, regulators, power domains and gpios as well. > > If it is only a chance, then perhaps we shouldn't allow things > upstream without proper drivers for all these things. That will only > give users the wrong impression. > It's not as much the drivers that's the problem here as it is the composition of the drivers. For this particular case it would be convenient not to ship the partial dtb, or at least not ship it with the promise that it's stable. > >> The 2nd case is the kernel version may > >> simply not have the dependent driver. This can happen if using a newer DT > >> (provided by firmware perhaps) with a stable kernel version. > >> > > > > As above, this is in no way limited to pinctrl drivers. > > Yes, I wasn't trying to imply that with this patch. I was just > starting with 1 example. IOMMUs (which essentially is already doing > what this patch does) and power domains are the main other 2. qcom,iommu-v1 is bool, but depends on e.g. CONFIG_MSM_GCC_8916 which is tristate. So you would need to s/tristate/bool/ everything in drivers/clk/qcom/Kconfig as well. Not to mention that there are interconnects and power domains actually involved here as well... > Clocks is an obvious one too, but from the discussion I referenced > that problem is a bit different as platforms change from dummy > fixed-clocks to a real clock controller driver. That will need a > different solution. So how are you going to deal with the case when a vendor decides to ship their firmware package with all clocks enabled and only fixed clocks described in DT and as they upstream a clock driver and patch their firmware to do the right thing? (Or the much less extreme case where this happens for a single clock, regulator, pinctrl, interconnect, etc to fix some bug/power management behavior) And is this really a problem that does not exists in the ACPI world? > > >> Unfortunately, this change breaks with modules as we have no way of > >> knowing when modules are done loading. One possibility is to make this > >> opt in or out based on compatible strings rather than at a subsystem level. > >> Ideally this information could be extracted automatically somehow. OTOH, > >> maybe the lists are pretty small. There's only a handful of subsystems > >> that can be optional, and then only so many drivers in those that can be > >> modules (at least for pinctrl, many drivers are built-in only). > >> > > > > On the Qualcomm platform most drivers are tristate and on most platforms > > there are size restrictions in the proprietary boot loader preventing us > > from boot the kernel after switching all these frameworks from tristate > > to bool (which feels like a more appropriate solution than your hack). > > BTW, QCom platforms are almost the only ones with pinctrl drivers as > modules. They are also happen to be PIA to configure correctly for a > board. > There are a few pinctrl drivers for chips sitting on i2c busses, as such changing this requirement would trickle down to a number of possible i2c masters as well. Sorry to hear that you find it so difficult to configure the pinctrl, it's (almost) entirely using the common pinctrl bindings. Perhaps we need to add some documentation of the hardware in the binding? > However, I would like a solution that works with modules. It would be > nice to know when userspace finished processing all the coldplug > uevents. That would be sufficient to support modules. I researched > that a bit and it doesn't seem the kernel can tell when that has > happened. > It's not that far from the issue I have in remoteproc, where I would like to boot a DSP as soon as the firmware is available - which might be probed at any time after boot. [..] > >> I tested this on a RPi3 B with the pinctrl driver forced off. With this > >> change, the MMC/SD and UART drivers can function without the pinctrl > >> driver. > >> > > > > Cool, so what about graphics, audio, networking, usb and all the other > > things that people actually expect when they _use_ a distro? > > I often care about none of those things. When I do, I'd rather boot to > a working console with those broken than have to debug why the kernel > panicked. > But that's developer-you speaking, developer-me totally agree. But when I take the role of being a user of a distro I most definitely do expect functionality beyond the basics used by the boot loader (UART and dependencies of the primary storage device). My argument is simply that in neither of these cases this patch is helpful. [..] > >> +int driver_deferred_probe_optional(void) > >> +{ > >> + if (initcalls_done) > >> + return -ENODEV; > > > > You forgot the humongous printout here that tells the users that we do > > not want any bug reports related hardware not working as expected after > > this point. > > I assume you were joking, but I would happily add a WARN here. About the print yes, but I most definitely do not want to debug issues related to this! The crazy issues you get from having electrical properties slightly off (e.g. drive-strength of the SD-card pins) or the fact that any driver using pinmuxing will depend on the modprobe ordering. > Spewing new warnings while still booting is a better UX than just > panicking. Ideally, it would be once per missing dependency. > Having a convenient way of listing all unmatched devices or devices sitting in probe deferral would be quite convenient, as a development tool. I know this hassle was the starting point of some of Frank's tools. Regards, Bjorn
On Mon, May 07, 2018 at 03:34:38PM -0700, Bjorn Andersson wrote:
> And is this really a problem that does not exists in the ACPI world?
Sort of, in that on ACPI systems all devices are expected to live in
glorious isolation and anything they need transparently configured by
the firmware with any information about clock speeds or whatever coming
from proprietary/device specific properties (though that's severely
frowned upon) or the apparently idiomatic technique of hardcoding based
on DMI data which has some scalability issues. This works great for
systems intended to work in the ACPI model but is not entirely
successful once you get outside of that.
Some of the embedded ACPI people have been importing bits of DT
wholesale into ACPI, for those bits obviously all the DT issues get
imported too.
On 05/07/2018 08:31 PM, Bjorn Andersson wrote: > On Tue 01 May 14:31 PDT 2018, Rob Herring wrote: > >> Deferred probe will currently wait forever on dependent devices to probe, >> but sometimes a driver will never exist. It's also not always critical for >> a driver to exist. Platforms can rely on default configuration from the >> bootloader or reset defaults for things such as pinctrl and power domains. > But how do you know if this is the case? > >> This is often the case with initial platform support until various drivers >> get enabled. > Can you please name platform that has enough support for Alexander to > care about backwards and forwards compatibility but lacks a pinctrl > driver. ZynqMP is one example that immediately comes to my mind. I'm sure there are others too. In general it's very frustrating to debug what goes wrong when you can't even get serial to output anything at all just because there are now pinctrl bindings that your kernel may not know about yet. I've run into that too many times. > >> There's at least 2 scenarios where deferred probe can render >> a platform broken. Both involve using a DT which has more devices and >> dependencies than the kernel supports. The 1st case is a driver may be >> disabled in the kernel config. > I agree that there is a chance that you _might_ get some parts of the > system working by relying on the boot loader configuration, but > misconfiguration issues applies to any other fundamental providers, such > as clocks, regulators, power domains and gpios as well. > >> The 2nd case is the kernel version may >> simply not have the dependent driver. This can happen if using a newer DT >> (provided by firmware perhaps) with a stable kernel version. >> > As above, this is in no way limited to pinctrl drivers. > >> Unfortunately, this change breaks with modules as we have no way of >> knowing when modules are done loading. One possibility is to make this >> opt in or out based on compatible strings rather than at a subsystem level. >> Ideally this information could be extracted automatically somehow. OTOH, >> maybe the lists are pretty small. There's only a handful of subsystems >> that can be optional, and then only so many drivers in those that can be >> modules (at least for pinctrl, many drivers are built-in only). >> > On the Qualcomm platform most drivers are tristate and on most platforms > there are size restrictions in the proprietary boot loader preventing us > from boot the kernel after switching all these frameworks from tristate > to bool (which feels like a more appropriate solution than your hack). I don't see how setting them to bool contradicts with the hack? The goal of this patch is to allow systems to load drivers on firmware provided pinctrl setups if there is no matching pinctrl driver in the kernel. > >> Cc: Alexander Graf <agraf@suse.de> >> Signed-off-by: Rob Herring <robh@kernel.org> >> --- >> This patch came out of a discussion on the ARM boot-architecture >> list[1] about DT forwards and backwards compatibility issues. There are >> issues with newer DTs breaking on older, stable kernels. Some of these >> are difficult to solve, but cases of optional devices not having >> kernel support should be solvable. >> > There are two cases here: > 1) DT contains compatibles that isn't supported by the kernel. In this > case the associated device will remain in the probe deferral list and > user space won't know about the device. > > 2) DT contains compatibles known to the kernel but has new optional > properties that makes things functional or works around hardware bugs. The key point is not to regress. Imagine you have firmware 1.0 which works with OS 1.0. Firmware provides the device tree. When you update to firmware to 1.1 you want to make sure OS 1.0 still works. The bug you're referring to that existed before of course still exists. But we're not worse off. > >> I tested this on a RPi3 B with the pinctrl driver forced off. With this >> change, the MMC/SD and UART drivers can function without the pinctrl >> driver. >> > Cool, so what about graphics, audio, networking, usb and all the other > things that people actually expect when they _use_ a distro? Again, it's about regressions. If audio didn't work before, a firmware update may not get you working audio with OS 1.0. But it may enable OS 1.1 to provide audio. Alex
On 05/14/2018 12:01 AM, Linus Walleij wrote: > On Wed, May 9, 2018 at 11:44 AM, Alexander Graf <agraf@suse.de> wrote: >> On 05/07/2018 08:31 PM, Bjorn Andersson wrote: >>> Can you please name platform that has enough support for Alexander to >>> care about backwards and forwards compatibility but lacks a pinctrl >>> driver. >> ZynqMP is one example that immediately comes to my mind. I'm sure there are >> others too. > Why isn't that using drivers/pinctrl/pinctrl-zynq.c? > > How is it so very different from (old) Zynq as it is already using > the same GPIO driver? That one is very simple: ZynqMP is usually an AMP system where Linux doesn't have full knowledge of the overall system. IIUC they have a tiny microblaze (PMU) that does the actual full system configuration for peripherals that may interfere with each other. This architecture also allows for safety critical code to run alongside a (less safe) Linux system. I think we'll see architectures like this pop up more over time. TI Sitara has similar issues. I know that Jailhouse ran into exactly that problem before. I also know that during Linaro Connect Budapest even the OP-TEE people realized the current model is bad, because Linux may control pins/clocks/etc of devices that the secure world wants to use. So I actually believe we will see more SoCs in the future that may even start with Linux controllable pinctrl or no pinctrl driver but then will move to firmware controlled drivers once it starts being necessary. Alex
On Mon, May 14, 2018 at 2:44 PM, Michal Simek <michal.simek@xilinx.com> wrote: > On 14.5.2018 09:37, Alexander Graf wrote: >> On 05/14/2018 12:01 AM, Linus Walleij wrote: >>> On Wed, May 9, 2018 at 11:44 AM, Alexander Graf <agraf@suse.de> wrote: >>>> On 05/07/2018 08:31 PM, Bjorn Andersson wrote: >>>>> Can you please name platform that has enough support for Alexander to >>>>> care about backwards and forwards compatibility but lacks a pinctrl >>>>> driver. >>>> ZynqMP is one example that immediately comes to my mind. I'm sure >>>> there are >>>> others too. >>> Why isn't that using drivers/pinctrl/pinctrl-zynq.c? >>> >>> How is it so very different from (old) Zynq as it is already using >>> the same GPIO driver? >> >> That one is very simple: ZynqMP is usually an AMP system where Linux >> doesn't have full knowledge of the overall system. IIUC they have a tiny >> microblaze (PMU) that does the actual full system configuration for >> peripherals that may interfere with each other. This architecture also >> allows for safety critical code to run alongside a (less safe) Linux >> system. > > Linux is running in non secure world that's why Linux can't have full > system visibility and Linux should ask firmware. It doesn't matter if > firmware is running on specific unit or just secure SW in EL3/EL1-S, EL0-S. > You can also configure ZynqMP to protect these address ranges not to be > accessible from NS sw. > If you don't care about security you can use normal read/write accesses > at least for gpio case. Pinctrl/clk will be driven via firmware interface. OK I get it, the situation is similar to some ACPI-based BIOSes on PC where one needs to ask the firmware for misc services. What would be nice is to standardize these APIs (like ACPI or device tree does) so we don't end up with one per-SoC-specific driver per system. But I guess it is not my pick. Yours, Linus Walleij
diff --git a/drivers/base/dd.c b/drivers/base/dd.c index c9f54089429b..5848808b9d7a 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -226,6 +226,15 @@ void device_unblock_probing(void) driver_deferred_probe_trigger(); } + +int driver_deferred_probe_optional(void) +{ + if (initcalls_done) + return -ENODEV; + + return -EPROBE_DEFER; +} + /** * deferred_probe_initcall() - Enable probing of deferred devices * @@ -240,6 +249,13 @@ static int deferred_probe_initcall(void) /* Sort as many dependencies as possible before exiting initcalls */ flush_work(&deferred_probe_work); initcalls_done = true; + + /* + * Trigger deferred probe again, this time we won't defer anything + * that is optional + */ + driver_deferred_probe_trigger(); + flush_work(&deferred_probe_work); return 0; } late_initcall(deferred_probe_initcall); diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c index b601039d6c69..096e52a5c506 100644 --- a/drivers/pinctrl/devicetree.c +++ b/drivers/pinctrl/devicetree.c @@ -120,7 +120,7 @@ static int dt_to_map_one_config(struct pinctrl *p, np_config); of_node_put(np_pctldev); /* OK let's just assume this will appear later then */ - return -EPROBE_DEFER; + return driver_deferred_probe_optional(); } /* If we're creating a hog we can use the passed pctldev */ if (pctldev && (np_pctldev == p->dev->of_node)) diff --git a/include/linux/device.h b/include/linux/device.h index 0059b99e1f25..8de920442bc1 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -332,6 +332,8 @@ struct device *driver_find_device(struct device_driver *drv, struct device *start, void *data, int (*match)(struct device *dev, void *data)); +int driver_deferred_probe_optional(void); + /** * struct subsys_interface - interfaces to device functions * @name: name of the device function
Deferred probe will currently wait forever on dependent devices to probe, but sometimes a driver will never exist. It's also not always critical for a driver to exist. Platforms can rely on default configuration from the bootloader or reset defaults for things such as pinctrl and power domains. This is often the case with initial platform support until various drivers get enabled. There's at least 2 scenarios where deferred probe can render a platform broken. Both involve using a DT which has more devices and dependencies than the kernel supports. The 1st case is a driver may be disabled in the kernel config. The 2nd case is the kernel version may simply not have the dependent driver. This can happen if using a newer DT (provided by firmware perhaps) with a stable kernel version. Unfortunately, this change breaks with modules as we have no way of knowing when modules are done loading. One possibility is to make this opt in or out based on compatible strings rather than at a subsystem level. Ideally this information could be extracted automatically somehow. OTOH, maybe the lists are pretty small. There's only a handful of subsystems that can be optional, and then only so many drivers in those that can be modules (at least for pinctrl, many drivers are built-in only). Cc: Alexander Graf <agraf@suse.de> Signed-off-by: Rob Herring <robh@kernel.org> --- This patch came out of a discussion on the ARM boot-architecture list[1] about DT forwards and backwards compatibility issues. There are issues with newer DTs breaking on older, stable kernels. Some of these are difficult to solve, but cases of optional devices not having kernel support should be solvable. I tested this on a RPi3 B with the pinctrl driver forced off. With this change, the MMC/SD and UART drivers can function without the pinctrl driver. Rob [1] https://lists.linaro.org/pipermail/boot-architecture/2018-April/000466.html drivers/base/dd.c | 16 ++++++++++++++++ drivers/pinctrl/devicetree.c | 2 +- include/linux/device.h | 2 ++ 3 files changed, 19 insertions(+), 1 deletion(-) -- 2.17.0