| Message ID | 20180531103806.2674-1-ulf.hansson@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] mmc: mvsdio: Respect card busy time out from mmc core | expand |
On Thu, 2018-05-31 at 12:38 +0200, Ulf Hansson wrote: > There is no obvious reasons to why mvsdio shouldn't be able to > support > erase/trim/discard operations, hence let's set MMC_CAP_ERASE for it. > > Cc: Damien Thebault <damien.thebault@vitec.com> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/mmc/host/mvsdio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c > index 4c70829cffd7..e22bbff89c8d 100644 > --- a/drivers/mmc/host/mvsdio.c > +++ b/drivers/mmc/host/mvsdio.c > @@ -757,6 +757,8 @@ static int mvsd_probe(struct platform_device > *pdev) > if (maxfreq) > mmc->f_max = maxfreq; > > + mmc->caps |= MMC_CAP_ERASE; > + > spin_lock_init(&host->lock); > > host->base = devm_ioremap_resource(&pdev->dev, r); Tested using blkdiscard and blkdiscard -s on an eMMC. Tested-By: Damien Thébault <damien.thebault@vitec.com> -- Damien Thébault R&D Engineer VITEC T. +33 1 46 73 06 06 F. +33 9 59 85 99 92 E. damien.thebault@vitec.com http://www.vitec.com
On 31 May 2018 at 14:49, Damien Thébault <damien.thebault@vitec.com> wrote: > On Thu, 2018-05-31 at 12:38 +0200, Ulf Hansson wrote: >> There is no obvious reasons to why mvsdio shouldn't be able to >> support >> erase/trim/discard operations, hence let's set MMC_CAP_ERASE for it. >> >> Cc: Damien Thebault <damien.thebault@vitec.com> >> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> >> --- >> drivers/mmc/host/mvsdio.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c >> index 4c70829cffd7..e22bbff89c8d 100644 >> --- a/drivers/mmc/host/mvsdio.c >> +++ b/drivers/mmc/host/mvsdio.c >> @@ -757,6 +757,8 @@ static int mvsd_probe(struct platform_device >> *pdev) >> if (maxfreq) >> mmc->f_max = maxfreq; >> >> + mmc->caps |= MMC_CAP_ERASE; >> + >> spin_lock_init(&host->lock); >> >> host->base = devm_ioremap_resource(&pdev->dev, r); > > Tested using blkdiscard and blkdiscard -s on an eMMC. > > Tested-By: Damien Thébault <damien.thebault@vitec.com> Thanks! I assume the tested by tag also applies for patch1/2? Just asking to make sure you didn't test this standalone. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2018-05-31 at 15:00 +0200, Ulf Hansson wrote: > > Tested using blkdiscard and blkdiscard -s on an eMMC. > > > > Tested-By: Damien Thébault <damien.thebault@vitec.com> > > Thanks! > > I assume the tested by tag also applies for patch1/2? Just asking to > make sure you didn't test this standalone. Yes, I tested the full patchset ; should I reply to the first one with Tested-By as well? I'm unfortunately not up-to date on the usage of the tags. Regards -- Damien Thébault R&D Engineer VITEC T. +33 1 46 73 06 06 F. +33 9 59 85 99 92 E. damien.thebault@vitec.com http://www.vitec.com
diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c index 4c70829cffd7..e22bbff89c8d 100644 --- a/drivers/mmc/host/mvsdio.c +++ b/drivers/mmc/host/mvsdio.c @@ -757,6 +757,8 @@ static int mvsd_probe(struct platform_device *pdev) if (maxfreq) mmc->f_max = maxfreq; + mmc->caps |= MMC_CAP_ERASE; + spin_lock_init(&host->lock); host->base = devm_ioremap_resource(&pdev->dev, r);
There is no obvious reasons to why mvsdio shouldn't be able to support erase/trim/discard operations, hence let's set MMC_CAP_ERASE for it. Cc: Damien Thebault <damien.thebault@vitec.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/mmc/host/mvsdio.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.17.0