mbox series

[v1.1,0/9] target/m68k: Convert to TranslatorOps

Message ID 20180512050250.12774-1-richard.henderson@linaro.org
Headers show
Series target/m68k: Convert to TranslatorOps | expand

Message

Richard Henderson May 12, 2018, 5:02 a.m. UTC 
[ Ho, hum.  I didn't clear out my scratch directory before sending v1.0. ]

FYI, I've only tested this with linux-user-test-0.3 and
our qemu coldfire testing kernel.


r~


Richard Henderson (9):
  target/m68k: Use DISAS_NORETURN for exceptions
  target/m68k: Replace DISAS_TB_JUMP with DISAS_NORETURN
  target/m68k: Remove DISAS_JUMP_NEXT as unused
  target/m68k: Use lookup_and_goto_tb for DISAS_JUMP
  target/m68k: Rename DISAS_UPDATE and gen_lookup_tb
  target/m68k: Convert to DisasContextBase
  target/m68k: Convert to TranslatorOps
  target/m68k: Improve ending TB at page boundaries
  target/m68k: Merge disas_m68k_insn into m68k_tr_translate_insn

 target/m68k/translate.c | 354 ++++++++++++++++++++--------------------
 1 file changed, 179 insertions(+), 175 deletions(-)

-- 
2.17.0

Comments

no-reply@patchew.org May 12, 2018, 5:24 a.m. UTC | #1 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180512050250.12774-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH v1.1 0/9] target/m68k: Convert to TranslatorOps

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180512050250.12774-1-richard.henderson@linaro.org -> patchew/20180512050250.12774-1-richard.henderson@linaro.org
Switched to a new branch 'test'
b396d1ea56 target/m68k: Merge disas_m68k_insn into m68k_tr_translate_insn
1454f7ac75 target/m68k: Improve ending TB at page boundaries
180209d486 target/m68k: Convert to TranslatorOps
838e40004e target/m68k: Convert to DisasContextBase
88f0d5dff1 target/m68k: Rename DISAS_UPDATE and gen_lookup_tb
78920794cd target/m68k: Use lookup_and_goto_tb for DISAS_JUMP
0ae1c99c4a target/m68k: Remove DISAS_JUMP_NEXT as unused
127bfcf989 target/m68k: Replace DISAS_TB_JUMP with DISAS_NORETURN
836179eaad target/m68k: Use DISAS_NORETURN for exceptions

=== OUTPUT BEGIN ===
Checking PATCH 1/9: target/m68k: Use DISAS_NORETURN for exceptions...
Checking PATCH 2/9: target/m68k: Replace DISAS_TB_JUMP with DISAS_NORETURN...
Checking PATCH 3/9: target/m68k: Remove DISAS_JUMP_NEXT as unused...
Checking PATCH 4/9: target/m68k: Use lookup_and_goto_tb for DISAS_JUMP...
Checking PATCH 5/9: target/m68k: Rename DISAS_UPDATE and gen_lookup_tb...
Checking PATCH 6/9: target/m68k: Convert to DisasContextBase...
ERROR: space required before the open parenthesis '('
#559: FILE: target/m68k/translate.c:6134:
+        switch(dc->base.is_jmp) {

total: 1 errors, 0 warnings, 494 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/9: target/m68k: Convert to TranslatorOps...
Checking PATCH 8/9: target/m68k: Improve ending TB at page boundaries...
Checking PATCH 9/9: target/m68k: Merge disas_m68k_insn into m68k_tr_translate_insn...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Laurent Vivier May 13, 2018, 10:16 a.m. UTC | #2 
Le 12/05/2018 à 07:02, Richard Henderson a écrit :
> [ Ho, hum.  I didn't clear out my scratch directory before sending v1.0. ]

> 

> FYI, I've only tested this with linux-user-test-0.3 and

> our qemu coldfire testing kernel.


I've tested m68k-softmmu with Q800 emulation and started an LXC
container with m68k-linux-user:

Tested-by: Laurent Vivier <laurent@vivier.eu>
Laurent Vivier June 7, 2018, 8:25 p.m. UTC | #3 
Le 12/05/2018 à 07:02, Richard Henderson a écrit :
> [ Ho, hum.  I didn't clear out my scratch directory before sending v1.0. ]

> 

> FYI, I've only tested this with linux-user-test-0.3 and

> our qemu coldfire testing kernel.

> 

> 

> r~

> 

> 

> Richard Henderson (9):

>   target/m68k: Use DISAS_NORETURN for exceptions

>   target/m68k: Replace DISAS_TB_JUMP with DISAS_NORETURN

>   target/m68k: Remove DISAS_JUMP_NEXT as unused

>   target/m68k: Use lookup_and_goto_tb for DISAS_JUMP

>   target/m68k: Rename DISAS_UPDATE and gen_lookup_tb

>   target/m68k: Convert to DisasContextBase

>   target/m68k: Convert to TranslatorOps

>   target/m68k: Improve ending TB at page boundaries

>   target/m68k: Merge disas_m68k_insn into m68k_tr_translate_insn

> 

>  target/m68k/translate.c | 354 ++++++++++++++++++++--------------------

>  1 file changed, 179 insertions(+), 175 deletions(-)

> 


Richard,

do you want I take this through my m68k tree or do you take this in a
TCG pull requests?

Thanks,
Laurent
Richard Henderson June 8, 2018, 5:48 p.m. UTC | #4 
On 06/07/2018 10:25 AM, Laurent Vivier wrote:
> do you want I take this through my m68k tree or do you take this in a

> TCG pull requests?


Would you take it through your m68k tree please?


r~
Laurent Vivier June 8, 2018, 5:51 p.m. UTC | #5 
Le 08/06/2018 à 19:48, Richard Henderson a écrit :
> On 06/07/2018 10:25 AM, Laurent Vivier wrote:

>> do you want I take this through my m68k tree or do you take this in a

>> TCG pull requests?

> 

> Would you take it through your m68k tree please?


OK, I take.

Thanks,
Laurent