| Message ID | 20180709152117.21585-2-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | various docker fixes | expand |
On Mon, 07/09 16:21, Alex Bennée wrote: > This was being a little over enthusiastic hiding files. What is "this" that hides test-* and calls for this patch? > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/.gitignore b/tests/.gitignore > index 08e2df1ce1..72c18aaab0 100644 > --- a/tests/.gitignore > +++ b/tests/.gitignore > @@ -9,6 +9,7 @@ qht-bench > rcutorture > test-* > !test-*.c > +!docker/test-* > test-qapi-commands.[ch] > test-qapi-events.[ch] > test-qapi-types.[ch] > -- > 2.17.1 >
Fam Zheng <famz@redhat.com> writes: > On Mon, 07/09 16:21, Alex Bennée wrote: >> This was being a little over enthusiastic hiding files. > > What is "this" that hides test-* and calls for this patch? I thought that was implicit from the first line, this is the .gitignore. > >> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> --- >> tests/.gitignore | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/.gitignore b/tests/.gitignore >> index 08e2df1ce1..72c18aaab0 100644 >> --- a/tests/.gitignore >> +++ b/tests/.gitignore >> @@ -9,6 +9,7 @@ qht-bench >> rcutorture >> test-* >> !test-*.c >> +!docker/test-* >> test-qapi-commands.[ch] >> test-qapi-events.[ch] >> test-qapi-types.[ch] >> -- >> 2.17.1 >> -- Alex Bennée
On Tue, 07/10 08:54, Alex Bennée wrote: > > Fam Zheng <famz@redhat.com> writes: > > > On Mon, 07/09 16:21, Alex Bennée wrote: > >> This was being a little over enthusiastic hiding files. > > > > What is "this" that hides test-* and calls for this patch? > > I thought that was implicit from the first line, this is the .gitignore. Indeed you're right. Maybe that line should be more specific, but I have no strong opinion. Fam > > > > >> > >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > >> --- > >> tests/.gitignore | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/tests/.gitignore b/tests/.gitignore > >> index 08e2df1ce1..72c18aaab0 100644 > >> --- a/tests/.gitignore > >> +++ b/tests/.gitignore > >> @@ -9,6 +9,7 @@ qht-bench > >> rcutorture > >> test-* > >> !test-*.c > >> +!docker/test-* > >> test-qapi-commands.[ch] > >> test-qapi-events.[ch] > >> test-qapi-types.[ch] > >> -- > >> 2.17.1 > >> > > > -- > Alex Bennée
On 07/09/2018 12:21 PM, Alex Bennée wrote: > This was being a little over enthusiastic hiding files. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/.gitignore b/tests/.gitignore > index 08e2df1ce1..72c18aaab0 100644 > --- a/tests/.gitignore > +++ b/tests/.gitignore > @@ -9,6 +9,7 @@ qht-bench > rcutorture > test-* > !test-*.c > +!docker/test-* > test-qapi-commands.[ch] > test-qapi-events.[ch] > test-qapi-types.[ch] >
diff --git a/tests/.gitignore b/tests/.gitignore index 08e2df1ce1..72c18aaab0 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -9,6 +9,7 @@ qht-bench rcutorture test-* !test-*.c +!docker/test-* test-qapi-commands.[ch] test-qapi-events.[ch] test-qapi-types.[ch]
This was being a little over enthusiastic hiding files. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) -- 2.17.1