| Message ID | 20180619214054.19326-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | ec3d5f1658f44538907b149d6396453e0ceedc60 |
| Headers | show |
| Series | h8300: remove unnecessary of_platform_populate call | expand |
On Tue, Jun 19, 2018 at 3:40 PM Rob Herring <robh@kernel.org> wrote: > > The DT core will call of_platform_populate, so it is not necessary for > arch specific code to call it unless there are custom match entries, > auxdata or parent device. Neither of those apply here, so remove the call. > > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > Cc: uclinux-h8-devel@lists.sourceforge.jp > Signed-off-by: Rob Herring <robh@kernel.org> > --- > arch/h8300/kernel/setup.c | 10 ---------- > 1 file changed, 10 deletions(-) Ping? > > diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c > index a4d0470c10a9..b2b51f75774e 100644 > --- a/arch/h8300/kernel/setup.c > +++ b/arch/h8300/kernel/setup.c > @@ -23,7 +23,6 @@ > #include <linux/init.h> > #include <linux/of.h> > #include <linux/of_fdt.h> > -#include <linux/of_platform.h> > #include <linux/of_address.h> > #include <linux/clk-provider.h> > #include <linux/memblock.h> > @@ -188,15 +187,6 @@ const struct seq_operations cpuinfo_op = { > .show = show_cpuinfo, > }; > > -static int __init device_probe(void) > -{ > - of_platform_populate(NULL, NULL, NULL, NULL); > - > - return 0; > -} > - > -device_initcall(device_probe); > - > #if defined(CONFIG_CPU_H8300H) > #define get_wait(base, addr) ({ \ > int baddr; \ > -- > 2.17.1 >
On Wed, 20 Jun 2018 06:40:54 +0900, Rob Herring wrote: > > The DT core will call of_platform_populate, so it is not necessary for > arch specific code to call it unless there are custom match entries, > auxdata or parent device. Neither of those apply here, so remove the call. > > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > Cc: uclinux-h8-devel@lists.sourceforge.jp > Signed-off-by: Rob Herring <robh@kernel.org> > --- > arch/h8300/kernel/setup.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c > index a4d0470c10a9..b2b51f75774e 100644 > --- a/arch/h8300/kernel/setup.c > +++ b/arch/h8300/kernel/setup.c > @@ -23,7 +23,6 @@ > #include <linux/init.h> > #include <linux/of.h> > #include <linux/of_fdt.h> > -#include <linux/of_platform.h> > #include <linux/of_address.h> > #include <linux/clk-provider.h> > #include <linux/memblock.h> > @@ -188,15 +187,6 @@ const struct seq_operations cpuinfo_op = { > .show = show_cpuinfo, > }; > > -static int __init device_probe(void) > -{ > - of_platform_populate(NULL, NULL, NULL, NULL); > - > - return 0; > -} > - > -device_initcall(device_probe); > - > #if defined(CONFIG_CPU_H8300H) > #define get_wait(base, addr) ({ \ > int baddr; \ > -- > 2.17.1 > Sorry. too late reply. Applied to h8300-next. Thanks. -- Yosinori Sato
diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c index a4d0470c10a9..b2b51f75774e 100644 --- a/arch/h8300/kernel/setup.c +++ b/arch/h8300/kernel/setup.c @@ -23,7 +23,6 @@ #include <linux/init.h> #include <linux/of.h> #include <linux/of_fdt.h> -#include <linux/of_platform.h> #include <linux/of_address.h> #include <linux/clk-provider.h> #include <linux/memblock.h> @@ -188,15 +187,6 @@ const struct seq_operations cpuinfo_op = { .show = show_cpuinfo, }; -static int __init device_probe(void) -{ - of_platform_populate(NULL, NULL, NULL, NULL); - - return 0; -} - -device_initcall(device_probe); - #if defined(CONFIG_CPU_H8300H) #define get_wait(base, addr) ({ \ int baddr; \
The DT core will call of_platform_populate, so it is not necessary for arch specific code to call it unless there are custom match entries, auxdata or parent device. Neither of those apply here, so remove the call. Cc: Yoshinori Sato <ysato@users.sourceforge.jp> Cc: uclinux-h8-devel@lists.sourceforge.jp Signed-off-by: Rob Herring <robh@kernel.org> --- arch/h8300/kernel/setup.c | 10 ---------- 1 file changed, 10 deletions(-) -- 2.17.1