[17/17] fs-test: fix false positive error at Test Case 12

Message ID	20180720025723.6736-18-takahiro.akashi@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; From: AKASHI Takahiro <takahiro.akashi@linaro.org> To: trini@konsulko.com Date: Fri, 20 Jul 2018 11:57:23 +0900 Message-Id: <20180720025723.6736-18-takahiro.akashi@linaro.org> In-Reply-To: <20180720025723.6736-1-takahiro.akashi@linaro.org> References: <20180720025723.6736-1-takahiro.akashi@linaro.org> Cc: u-boot@lists.denx.de, xypron.glpk@gmx.de, agraf@suse.de Subject: [U-Boot] [PATCH 17/17] fs-test: fix false positive error at Test Case 12 Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	fs: fat: extend FAT write operations \| expand [00/17] fs: fat: extend FAT write operations [01/17] fs: fat: extend get_fs_info() for write use [02/17] fs: fat: handle "." and ".." of root dir correctly with fat_itr_resolve() [03/17] fs: fat: make directory iterator global for write use [04/17] fs: fat: assure iterator's ->dent belongs to ->clust [05/17] fs: fat: check and normailze file name [06/17] fs: fat: write returns error code instead of -1 [07/17] fs: fat: support write with sub-directory path [08/17] fs: fat: refactor write interface for a file offset [09/17] fs: fat: support write with non-zero offset [10/17] cmd: fat: add offset parameter to fatwrite [11/17] fs: add mkdir interface [12/17] fs: fat: remember the starting cluster number of directory [13/17] fs: fat: support mkdir [14/17] cmd: fat: add fatmkdir command [15/17] efi_loader: file: support creating a directory [16/17] efi_loader: implement a pseudo "file delete" [17/17] fs-test: fix false positive error at Test Case 12

Message ID

20180720025723.6736-18-takahiro.akashi@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: best guess record for domain of
	u-boot-bounces@lists.denx.de designates 81.169.180.215 as
	permitted sender) client-ip=81.169.180.215; 
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: trini@konsulko.com
Date: Fri, 20 Jul 2018 11:57:23 +0900
Message-Id: <20180720025723.6736-18-takahiro.akashi@linaro.org>
In-Reply-To: <20180720025723.6736-1-takahiro.akashi@linaro.org>
References: <20180720025723.6736-1-takahiro.akashi@linaro.org>
Cc: u-boot@lists.denx.de, xypron.glpk@gmx.de, agraf@suse.de
Subject: [U-Boot] [PATCH 17/17] fs-test: fix false positive error at Test
	Case 12
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

fs: fat: extend FAT write operations | expand

Comments

Heinrich Schuchardt July 29, 2018, 7:02 a.m. UTC | #1

On 07/20/2018 04:57 AM, AKASHI Takahiro wrote:
> The error message to be matched is wrong. Fix it.
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  test/fs/fs-test.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/fs/fs-test.sh b/test/fs/fs-test.sh
> index 2e8d5ee4df..7b0c5ea56f 100755
> --- a/test/fs/fs-test.sh
> +++ b/test/fs/fs-test.sh
> @@ -522,7 +522,7 @@ function check_results() {
>  		"TC11: 1MB write to $3.w - content verified"
>  
>  	# Check lookup of 'dot' directory
> -	grep -A4 "Test Case 12 " "$1" | grep -q 'Unable to write file'
> +	grep -A4 "Test Case 12 " "$1" | grep -q 'Unable to write'
>  	pass_fail "TC12: 1MB write to . - write denied"
>  
>  	# Check directory traversal
> 

Tom suggested in
https://lists.denx.de/pipermail/u-boot/2018-July/336378.html that the
comment headers in test/fs/fs-test.sh should be updated to reflect the
total number of passes and fails.

Best regards

Heinrich

AKASHI Takahiro July 31, 2018, 7:55 a.m. UTC | #2

On Sun, Jul 29, 2018 at 09:02:00AM +0200, Heinrich Schuchardt wrote:
> On 07/20/2018 04:57 AM, AKASHI Takahiro wrote:
> > The error message to be matched is wrong. Fix it.
> > 
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> >  test/fs/fs-test.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/test/fs/fs-test.sh b/test/fs/fs-test.sh
> > index 2e8d5ee4df..7b0c5ea56f 100755
> > --- a/test/fs/fs-test.sh
> > +++ b/test/fs/fs-test.sh
> > @@ -522,7 +522,7 @@ function check_results() {
> >  		"TC11: 1MB write to $3.w - content verified"
> >  
> >  	# Check lookup of 'dot' directory
> > -	grep -A4 "Test Case 12 " "$1" | grep -q 'Unable to write file'
> > +	grep -A4 "Test Case 12 " "$1" | grep -q 'Unable to write'
> >  	pass_fail "TC12: 1MB write to . - write denied"
> >  
> >  	# Check directory traversal
> > 
> 
> Tom suggested in
> https://lists.denx.de/pipermail/u-boot/2018-July/336378.html that the
> comment headers in test/fs/fs-test.sh should be updated to reflect the
> total number of passes and fails.

Thank you for this heads-up.
I'm now trying to rewrite fs-test.sh (at least part of it) on top of
py.test framework.
It will take some time as I'm still learning how to write tests for py.test.

-Takahiro AKASHI


> Best regards
> 
> Heinrich

diff --git a/test/fs/fs-test.sh b/test/fs/fs-test.sh
index 2e8d5ee4df..7b0c5ea56f 100755
--- a/test/fs/fs-test.sh
+++ b/test/fs/fs-test.sh
@@ -522,7 +522,7 @@  function check_results() {
 		"TC11: 1MB write to $3.w - content verified"
 
 	# Check lookup of 'dot' directory
-	grep -A4 "Test Case 12 " "$1" | grep -q 'Unable to write file'
+	grep -A4 "Test Case 12 " "$1" | grep -q 'Unable to write'
 	pass_fail "TC12: 1MB write to . - write denied"
 
 	# Check directory traversal

[17/17] fs-test: fix false positive error at Test Case 12

Commit Message

Comments

Patch