diff mbox series

Revert "cpan.bbclass: adopt to recent EU::MM"

Message ID 20180824080738.6061-1-raj.khem@gmail.com
State New
Headers show
Series Revert "cpan.bbclass: adopt to recent EU::MM" | expand

Commit Message

Khem Raj Aug. 24, 2018, 8:07 a.m. UTC 
This reverts commit 2e61533e7c1b1cfd49dc771e907207f11a15c44f.
---
 meta/classes/cpan.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.18.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Jens Rehsack Aug. 28, 2018, 7:21 a.m. UTC | #1 
> Am 24.08.2018 um 10:07 schrieb Khem Raj <raj.khem@gmail.com>:

> 

> This reverts commit 2e61533e7c1b1cfd49dc771e907207f11a15c44f.

> ---

> meta/classes/cpan.bbclass | 3 ++-

> 1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/meta/classes/cpan.bbclass b/meta/classes/cpan.bbclass

> index 926c6358a6..8e079e0d55 100644

> --- a/meta/classes/cpan.bbclass

> +++ b/meta/classes/cpan.bbclass

> @@ -16,7 +16,8 @@ export PERL_ARCHLIB = "${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/${@get_perl_version

> export PERLHOSTLIB = "${STAGING_LIBDIR_NATIVE}/perl-native/perl/${@get_perl_version(d)}/"

> 

> cpan_do_configure () {

> -	yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor NO_PERLLOCAL=1 NO_PACKLIST=1 ${EXTRA_CPANFLAGS}

> +	export PERL5LIB="${PERL_ARCHLIB}"

> +	yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor ${EXTRA_CPANFLAGS}

> 

> 	# Makefile.PLs can exit with success without generating a

> 	# Makefile, e.g. in cases of missing configure time

> --

> 2.18.0

> 

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core



This one shouldn't get tested together with
   2387c0d3 cpan.bbclass: make RPATH fix more general
since the hacked PERL5LIB="${PERL_ARCHLIB}" hides the broken RPATH
behavior.
--
Jens Rehsack - rehsack@gmail.com
<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">Am 24.08.2018 um 10:07 schrieb Khem Raj &lt;<a href="mailto:raj.khem@gmail.com" class="">raj.khem@gmail.com</a>&gt;:</div><br class="Apple-interchange-newline"><div class=""><div class="">This reverts commit 2e61533e7c1b1cfd49dc771e907207f11a15c44f.<br class="">---<br class=""> meta/classes/cpan.bbclass | 3 ++-<br class=""> 1 file changed, 2 insertions(+), 1 deletion(-)<br class=""><br class="">diff --git a/meta/classes/cpan.bbclass b/meta/classes/cpan.bbclass<br class="">index 926c6358a6..8e079e0d55 100644<br class="">--- a/meta/classes/cpan.bbclass<br class="">+++ b/meta/classes/cpan.bbclass<br class="">@@ -16,7 +16,8 @@ export PERL_ARCHLIB = "${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/${@get_perl_version<br class=""> export PERLHOSTLIB = "${STAGING_LIBDIR_NATIVE}/perl-native/perl/${@get_perl_version(d)}/"<br class=""><br class=""> cpan_do_configure () {<br class="">-<span class="Apple-tab-span" style="white-space:pre">	</span>yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor NO_PERLLOCAL=1 NO_PACKLIST=1 ${EXTRA_CPANFLAGS}<br class="">+<span class="Apple-tab-span" style="white-space:pre">	</span>export PERL5LIB="${PERL_ARCHLIB}"<br class="">+<span class="Apple-tab-span" style="white-space:pre">	</span>yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor ${EXTRA_CPANFLAGS}<br class=""><br class=""> <span class="Apple-tab-span" style="white-space:pre">	</span># Makefile.PLs can exit with success without generating a<br class=""> <span class="Apple-tab-span" style="white-space:pre">	</span># Makefile, e.g. in cases of missing configure time<br class="">-- <br class="">2.18.0<br class=""><br class="">-- <br class="">_______________________________________________<br class="">Openembedded-core mailing list<br class=""><a href="mailto:Openembedded-core@lists.openembedded.org" class="">Openembedded-core@lists.openembedded.org</a><br class="">http://lists.openembedded.org/mailman/listinfo/openembedded-core<br class=""></div></div></blockquote></div><div class=""><br class=""></div><div class="">This one shouldn't get tested together with&nbsp;</div><div class="">&nbsp; &nbsp;2387c0d3&nbsp;cpan.bbclass: make RPATH fix more general</div><div class="">since the hacked PERL5LIB="${PERL_ARCHLIB}" hides the broken RPATH</div><div class="">behavior.</div><div class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">--&nbsp;</div><div class="">Jens Rehsack - <a href="mailto:rehsack@gmail.com" class="">rehsack@gmail.com</a></div></div></div>
</div>
<br class=""></body></html>
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Aug. 28, 2018, 3:16 p.m. UTC | #2 
On Tue, Aug 28, 2018 at 12:21 AM Jens Rehsack <rehsack@gmail.com> wrote:

>

>

> Am 24.08.2018 um 10:07 schrieb Khem Raj <raj.khem@gmail.com>:

>

> This reverts commit 2e61533e7c1b1cfd49dc771e907207f11a15c44f.

> ---

> meta/classes/cpan.bbclass | 3 ++-

> 1 file changed, 2 insertions(+), 1 deletion(-)

>

> diff --git a/meta/classes/cpan.bbclass b/meta/classes/cpan.bbclass

> index 926c6358a6..8e079e0d55 100644

> --- a/meta/classes/cpan.bbclass

> +++ b/meta/classes/cpan.bbclass

> @@ -16,7 +16,8 @@ export PERL_ARCHLIB =

> "${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/${@get_perl_version

> export PERLHOSTLIB =

> "${STAGING_LIBDIR_NATIVE}/perl-native/perl/${@get_perl_version(d)}/"

>

> cpan_do_configure () {

> - yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor

> NO_PERLLOCAL=1 NO_PACKLIST=1 ${EXTRA_CPANFLAGS}

> + export PERL5LIB="${PERL_ARCHLIB}"

> + yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor

> ${EXTRA_CPANFLAGS}

>

> # Makefile.PLs can exit with success without generating a

> # Makefile, e.g. in cases of missing configure time

> --

> 2.18.0

>

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core

>

>

> This one shouldn't get tested together with

>    2387c0d3 cpan.bbclass: make RPATH fix more general

> since the hacked PERL5LIB="${PERL_ARCHLIB}" hides the broken RPATH

> behavior.

>


Yes it won’t this was actsully meant for master-next only

> --

> Jens Rehsack - rehsack@gmail.com

>

>
<div><br></div><div><br><div class="gmail_quote"><div dir="ltr">On Tue, Aug 28, 2018 at 12:21 AM Jens Rehsack &lt;<a href="mailto:rehsack@gmail.com">rehsack@gmail.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><br><div><br><blockquote type="cite"></blockquote></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><blockquote type="cite"><div>Am 24.08.2018 um 10:07 schrieb Khem Raj &lt;<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>&gt;:</div><br class="m_5519773361565648024Apple-interchange-newline"></blockquote></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><blockquote type="cite"><div><div></div></div></blockquote></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><blockquote type="cite"><div><div>This reverts commit 2e61533e7c1b1cfd49dc771e907207f11a15c44f.<br>---<br> meta/classes/cpan.bbclass | 3 ++-<br> 1 file changed, 2 insertions(+), 1 deletion(-)<br><br>diff --git a/meta/classes/cpan.bbclass b/meta/classes/cpan.bbclass<br>index 926c6358a6..8e079e0d55 100644<br>--- a/meta/classes/cpan.bbclass<br>+++ b/meta/classes/cpan.bbclass<br>@@ -16,7 +16,8 @@ export PERL_ARCHLIB = &quot;${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/${@get_perl_version<br> export PERLHOSTLIB = &quot;${STAGING_LIBDIR_NATIVE}/perl-native/perl/${@get_perl_version(d)}/&quot;<br><br> cpan_do_configure () {<br>-<span class="m_5519773361565648024Apple-tab-span" style="white-space:pre-wrap">	</span>yes &#39;&#39; | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor NO_PERLLOCAL=1 NO_PACKLIST=1 ${EXTRA_CPANFLAGS}<br>+<span class="m_5519773361565648024Apple-tab-span" style="white-space:pre-wrap">	</span>export PERL5LIB=&quot;${PERL_ARCHLIB}&quot;<br>+<span class="m_5519773361565648024Apple-tab-span" style="white-space:pre-wrap">	</span>yes &#39;&#39; | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor ${EXTRA_CPANFLAGS}<br><br> <span class="m_5519773361565648024Apple-tab-span" style="white-space:pre-wrap">	</span># Makefile.PLs can exit with success without generating a<br> <span class="m_5519773361565648024Apple-tab-span" style="white-space:pre-wrap">	</span># Makefile, e.g. in cases of missing configure time<br>-- <br>2.18.0<br><br></div></div></blockquote></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><blockquote type="cite"><div><div>-- <br>_______________________________________________<br>Openembedded-core mailing list<br><a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br><a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br></div></div></blockquote></div><div><br></div><div>This one shouldn&#39;t get tested together with </div><div>   2387c0d3 cpan.bbclass: make RPATH fix more general</div><div>since the hacked PERL5LIB=&quot;${PERL_ARCHLIB}&quot; hides the broken RPATH</div><div>behavior.</div></div></blockquote><div dir="auto"><br></div><div dir="auto">Yes it won’t this was actsully meant for master-next only </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div>
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div>-- </div><div>Jens Rehsack - <a href="mailto:rehsack@gmail.com" target="_blank">rehsack@gmail.com</a></div></div></div>
</div>
<br></div></blockquote></div></div>
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Richard Purdie Aug. 28, 2018, 3:32 p.m. UTC | #3 
Hi Khem,

I put the alternative fix into master as it passed OE-Core testing.
Could you see how the perl failures are looking in meta-oe now please?

Cheers,

Richard
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff mbox series

Patch

diff --git a/meta/classes/cpan.bbclass b/meta/classes/cpan.bbclass
index 926c6358a6..8e079e0d55 100644
--- a/meta/classes/cpan.bbclass
+++ b/meta/classes/cpan.bbclass
@@ -16,7 +16,8 @@  export PERL_ARCHLIB = "${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/${@get_perl_version
 export PERLHOSTLIB = "${STAGING_LIBDIR_NATIVE}/perl-native/perl/${@get_perl_version(d)}/"
 
 cpan_do_configure () {
-	yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor NO_PERLLOCAL=1 NO_PACKLIST=1 ${EXTRA_CPANFLAGS}
+	export PERL5LIB="${PERL_ARCHLIB}"
+	yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor ${EXTRA_CPANFLAGS}
 
 	# Makefile.PLs can exit with success without generating a
 	# Makefile, e.g. in cases of missing configure time