| Message ID | 20180829200425.16435-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | f55f61225a2b98fd3eef56428edee767dc43d21d |
| Headers | show |
| Series | soc: fsl/qe: Use of_get_child_by_name helper | expand |
From: Rob Herring <robh@kernel.org> date: 2018/8/30 4:04 > To: Qiang Zhao <qiang.zhao@nxp.com> > Cc: linux-kernel@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; > linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org > Subject: [PATCH] soc: fsl/qe: Use of_get_child_by_name helper > > Use the of_get_child_by_name() helper instead of open coding searching for the > 'firmware' child node. This removes directly accessing the name pointer as well. > > Cc: Qiang Zhao <qiang.zhao@nxp.com> > Cc: Li Yang <leoyang.li@nxp.com> > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/soc/fsl/qe/qe.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c index > 2ef6fc6487c1..612d9c551be5 100644 > --- a/drivers/soc/fsl/qe/qe.c > +++ b/drivers/soc/fsl/qe/qe.c > @@ -588,11 +588,7 @@ struct qe_firmware_info *qe_get_firmware_info(void) > } > > /* Find the 'firmware' child node */ > - for_each_child_of_node(qe, fw) { > - if (strcmp(fw->name, "firmware") == 0) > - break; > - } > - > + fw = of_get_child_by_name(qe, "firmware"); > of_node_put(qe); > > /* Did we find the 'firmware' node? */ > -- Acked-by: Qiang Zhao <qiang.zhao@nxp.com>
On Wed, Aug 29, 2018 at 9:49 PM Qiang Zhao <qiang.zhao@nxp.com> wrote: > > From: Rob Herring <robh@kernel.org> > date: 2018/8/30 4:04 > > > To: Qiang Zhao <qiang.zhao@nxp.com> > > Cc: linux-kernel@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; > > linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org > > Subject: [PATCH] soc: fsl/qe: Use of_get_child_by_name helper > > > > Use the of_get_child_by_name() helper instead of open coding searching for the > > 'firmware' child node. This removes directly accessing the name pointer as well. > > > > Cc: Qiang Zhao <qiang.zhao@nxp.com> > > Cc: Li Yang <leoyang.li@nxp.com> > > Cc: linuxppc-dev@lists.ozlabs.org > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Rob Herring <robh@kernel.org> Merged for next. Thanks. Regards, Leo
diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c index 2ef6fc6487c1..612d9c551be5 100644 --- a/drivers/soc/fsl/qe/qe.c +++ b/drivers/soc/fsl/qe/qe.c @@ -588,11 +588,7 @@ struct qe_firmware_info *qe_get_firmware_info(void) } /* Find the 'firmware' child node */ - for_each_child_of_node(qe, fw) { - if (strcmp(fw->name, "firmware") == 0) - break; - } - + fw = of_get_child_by_name(qe, "firmware"); of_node_put(qe); /* Did we find the 'firmware' node? */
Use the of_get_child_by_name() helper instead of open coding searching for the 'firmware' child node. This removes directly accessing the name pointer as well. Cc: Qiang Zhao <qiang.zhao@nxp.com> Cc: Li Yang <leoyang.li@nxp.com> Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/soc/fsl/qe/qe.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 2.17.1