| Message ID | 20181128143357.991-2-ard.biesheuvel@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Pkg: lift 40-bit IPA space limit | expand |
On 11/28/18 15:33, Ard Biesheuvel wrote: > Remove this module: it is unused, and should not be used as an > example going forward. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > EmbeddedPkg/TemplateSec/TemplateSec.inf | 65 ----------------- > EmbeddedPkg/TemplateSec/TemplateSec.c | 76 -------------------- > 2 files changed, 141 deletions(-) Reviewed-by: Laszlo Ersek <lersek@redhat.com> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On Wed, Nov 28, 2018 at 03:33:42PM +0100, Ard Biesheuvel wrote: > Remove this module: it is unused, and should not be used as an > example going forward. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > --- > EmbeddedPkg/TemplateSec/TemplateSec.inf | 65 ----------------- > EmbeddedPkg/TemplateSec/TemplateSec.c | 76 -------------------- > 2 files changed, 141 deletions(-) > > diff --git a/EmbeddedPkg/TemplateSec/TemplateSec.inf b/EmbeddedPkg/TemplateSec/TemplateSec.inf > deleted file mode 100644 > index 3a63e59294d3..000000000000 > --- a/EmbeddedPkg/TemplateSec/TemplateSec.inf > +++ /dev/null > @@ -1,65 +0,0 @@ > -#/** @file > -# > -# Component description file for DxeIpl module > -# > -# The responsibility of this module is to load the DXE Core from a Firmware Volume. This implementation i used to load a 32-bit DXE Core. > -# > -# Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR> > -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the BSD License > -# which accompanies this distribution. The full text of the license may be found at > -# http://opensource.org/licenses/bsd-license.php > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > -# > -#**/ > - > -[Defines] > - INF_VERSION = 0x00010005 > - BASE_NAME = TemplateSec > - FILE_GUID = 1D6F730F-5A55-4078-869B-E0A18324BDC8 > - MODULE_TYPE = SEC > - VERSION_STRING = 1.0 > - > - > -# > -# The following information is for reference only and not required by the build tools. > -# > -# VALID_ARCHITECTURES = IA32 X64 ARM > -# > - > -[Sources.common] > - TemplateSec.c > - > -[Sources.Ia32] > -# Ia32/ResetVector.asm | MSFT > -# Ia32/ResetVector.S | GCC > - > -[Sources.X64] > -# X64/ResetVector.asm | MSFT > -# X64/ResetVector.S | GCC > - > -[Sources.ARM] > -# Arm/ResetVector.asm | RVCT > -# Arm/ResetVector.S | GCC > - > -[Packages] > - MdePkg/MdePkg.dec > - MdeModulePkg/MdeModulePkg.dec > - EmbeddedPkg/EmbeddedPkg.dec > - > - > -[LibraryClasses] > - BaseLib > - DebugLib > - BaseMemoryLib > - UefiDecompressLib > - PeCoffLib > - CacheMaintenanceLib > - PrePiLib > - > -[Pcd] > - gEmbeddedTokenSpaceGuid.PcdEmbeddedFdBaseAddress > - gEmbeddedTokenSpaceGuid.PcdEmbeddedFdSize > - > diff --git a/EmbeddedPkg/TemplateSec/TemplateSec.c b/EmbeddedPkg/TemplateSec/TemplateSec.c > deleted file mode 100644 > index c63adbb6f90f..000000000000 > --- a/EmbeddedPkg/TemplateSec/TemplateSec.c > +++ /dev/null > @@ -1,76 +0,0 @@ > -/** @file > - > - Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR> > - > - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the BSD License > - which accompanies this distribution. The full text of the license may be found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > - > -**/ > - > -#include <PiPei.h> > - > -#include <Library/DebugLib.h> > -#include <Library/PrePiLib.h> > -#include <Library/PcdLib.h> > - > -#include <Ppi/GuidedSectionExtraction.h> > - > -VOID > -_ModuleEntryPoint ( > - VOID > - ) > -{ > -} > - > -VOID > -CEntryPoint ( > - VOID *MemoryBase, > - UINTN MemorySize, > - VOID *StackBase, > - UINTN StackSize > - ) > -{ > - EFI_PHYSICAL_ADDRESS MemoryBegin; > - UINT64 MemoryLength; > - VOID *HobBase; > - > - // > - // Boot strap the C environment so the other library services will work properly. > - // > - MemoryBegin = (EFI_PHYSICAL_ADDRESS)(UINTN)MemoryBase; > - MemoryLength = (UINT64)MemorySize; > - HobBase = (VOID *)(UINTN)(FixedPcdGet32(PcdEmbeddedFdBaseAddress) + FixedPcdGet32(PcdEmbeddedFdSize)); > - CreateHobList (MemoryBase, MemorySize, HobBase, StackBase); > - > - MemoryBegin = (EFI_PHYSICAL_ADDRESS)(UINTN)StackBase; > - MemoryLength = (UINT64)StackSize; > - UpdateStackHob (MemoryBegin, MemoryLength); > - > - DEBUG ((DEBUG_ERROR, "CEntryPoint (%x,%x,%x,%x)\n", MemoryBase, MemorySize, StackBase, StackSize)); > - > - // > - // Add your C code stuff here.... > - // > - > - > - // > - // Load the DXE Core and transfer control to it > - // > - > - // Give the DXE Core access to our DEBUG and ASSERT infrastructure so this will work prior > - // to the DXE version being loaded. Thus we close the debugging gap between phases. > - AddDxeCoreReportStatusCodeCallback (); > - > - //BuildFvHobs (PcdBfvBase, PcdBfvSize, NULL); > - > - LoadDxeCoreFromFv (NULL, 0); > - > - // DXE Core should always load and never return > - ASSERT (FALSE); > -} > - > -- > 2.19.1 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/EmbeddedPkg/TemplateSec/TemplateSec.inf b/EmbeddedPkg/TemplateSec/TemplateSec.inf deleted file mode 100644 index 3a63e59294d3..000000000000 --- a/EmbeddedPkg/TemplateSec/TemplateSec.inf +++ /dev/null @@ -1,65 +0,0 @@ -#/** @file -# -# Component description file for DxeIpl module -# -# The responsibility of this module is to load the DXE Core from a Firmware Volume. This implementation i used to load a 32-bit DXE Core. -# -# Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR> -# This program and the accompanying materials -# are licensed and made available under the terms and conditions of the BSD License -# which accompanies this distribution. The full text of the license may be found at -# http://opensource.org/licenses/bsd-license.php -# -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. -# -#**/ - -[Defines] - INF_VERSION = 0x00010005 - BASE_NAME = TemplateSec - FILE_GUID = 1D6F730F-5A55-4078-869B-E0A18324BDC8 - MODULE_TYPE = SEC - VERSION_STRING = 1.0 - - -# -# The following information is for reference only and not required by the build tools. -# -# VALID_ARCHITECTURES = IA32 X64 ARM -# - -[Sources.common] - TemplateSec.c - -[Sources.Ia32] -# Ia32/ResetVector.asm | MSFT -# Ia32/ResetVector.S | GCC - -[Sources.X64] -# X64/ResetVector.asm | MSFT -# X64/ResetVector.S | GCC - -[Sources.ARM] -# Arm/ResetVector.asm | RVCT -# Arm/ResetVector.S | GCC - -[Packages] - MdePkg/MdePkg.dec - MdeModulePkg/MdeModulePkg.dec - EmbeddedPkg/EmbeddedPkg.dec - - -[LibraryClasses] - BaseLib - DebugLib - BaseMemoryLib - UefiDecompressLib - PeCoffLib - CacheMaintenanceLib - PrePiLib - -[Pcd] - gEmbeddedTokenSpaceGuid.PcdEmbeddedFdBaseAddress - gEmbeddedTokenSpaceGuid.PcdEmbeddedFdSize - diff --git a/EmbeddedPkg/TemplateSec/TemplateSec.c b/EmbeddedPkg/TemplateSec/TemplateSec.c deleted file mode 100644 index c63adbb6f90f..000000000000 --- a/EmbeddedPkg/TemplateSec/TemplateSec.c +++ /dev/null @@ -1,76 +0,0 @@ -/** @file - - Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR> - - This program and the accompanying materials - are licensed and made available under the terms and conditions of the BSD License - which accompanies this distribution. The full text of the license may be found at - http://opensource.org/licenses/bsd-license.php - - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. - -**/ - -#include <PiPei.h> - -#include <Library/DebugLib.h> -#include <Library/PrePiLib.h> -#include <Library/PcdLib.h> - -#include <Ppi/GuidedSectionExtraction.h> - -VOID -_ModuleEntryPoint ( - VOID - ) -{ -} - -VOID -CEntryPoint ( - VOID *MemoryBase, - UINTN MemorySize, - VOID *StackBase, - UINTN StackSize - ) -{ - EFI_PHYSICAL_ADDRESS MemoryBegin; - UINT64 MemoryLength; - VOID *HobBase; - - // - // Boot strap the C environment so the other library services will work properly. - // - MemoryBegin = (EFI_PHYSICAL_ADDRESS)(UINTN)MemoryBase; - MemoryLength = (UINT64)MemorySize; - HobBase = (VOID *)(UINTN)(FixedPcdGet32(PcdEmbeddedFdBaseAddress) + FixedPcdGet32(PcdEmbeddedFdSize)); - CreateHobList (MemoryBase, MemorySize, HobBase, StackBase); - - MemoryBegin = (EFI_PHYSICAL_ADDRESS)(UINTN)StackBase; - MemoryLength = (UINT64)StackSize; - UpdateStackHob (MemoryBegin, MemoryLength); - - DEBUG ((DEBUG_ERROR, "CEntryPoint (%x,%x,%x,%x)\n", MemoryBase, MemorySize, StackBase, StackSize)); - - // - // Add your C code stuff here.... - // - - - // - // Load the DXE Core and transfer control to it - // - - // Give the DXE Core access to our DEBUG and ASSERT infrastructure so this will work prior - // to the DXE version being loaded. Thus we close the debugging gap between phases. - AddDxeCoreReportStatusCodeCallback (); - - //BuildFvHobs (PcdBfvBase, PcdBfvSize, NULL); - - LoadDxeCoreFromFv (NULL, 0); - - // DXE Core should always load and never return - ASSERT (FALSE); -} -
Remove this module: it is unused, and should not be used as an example going forward. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- EmbeddedPkg/TemplateSec/TemplateSec.inf | 65 ----------------- EmbeddedPkg/TemplateSec/TemplateSec.c | 76 -------------------- 2 files changed, 141 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel