| Message ID | 20181106175833.26964-16-ard.biesheuvel@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC | expand |
On 6/11/18 18:58, Ard Biesheuvel wrote: > Remove the forward declaration of e1000_disable_ulp_lpt_lp (), which > is never defined anywhere in the code. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> (Not tested with Visual Studio) > --- > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > index 7669630a5c03..e9fc5394ab28 100644 > --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > @@ -103,9 +103,6 @@ STATIC s32 e1000_reset_hw_ich8lan(struct e1000_hw *hw); > STATIC s32 e1000_init_hw_ich8lan(struct e1000_hw *hw); > STATIC s32 e1000_setup_link_ich8lan(struct e1000_hw *hw); > STATIC s32 e1000_setup_copper_link_ich8lan(struct e1000_hw *hw); > -#if !defined(NO_ULP_IN_S5_SUPPORT) > -STATIC s32 e1000_disable_ulp_lpt_lp(struct e1000_hw *hw, bool force); > -#endif /* !NO_ULP_IN_S5_SUPPORT && !ULP_IN_D0_SUPPORT */ > STATIC s32 e1000_setup_copper_link_pch_lpt(struct e1000_hw *hw); > STATIC s32 e1000_get_link_up_info_ich8lan(struct e1000_hw *hw, > u16 *speed, u16 *duplex); >
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com> On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > Remove the forward declaration of e1000_disable_ulp_lpt_lp (), which > is never defined anywhere in the code. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org> > --- > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > index 7669630a5c03..e9fc5394ab28 100644 > --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > @@ -103,9 +103,6 @@ STATIC s32 e1000_reset_hw_ich8lan(struct > e1000_hw *hw); > STATIC s32 e1000_init_hw_ich8lan(struct e1000_hw *hw); > STATIC s32 e1000_setup_link_ich8lan(struct e1000_hw *hw); > STATIC s32 e1000_setup_copper_link_ich8lan(struct e1000_hw *hw); > -#if !defined(NO_ULP_IN_S5_SUPPORT) > -STATIC s32 e1000_disable_ulp_lpt_lp(struct e1000_hw *hw, bool > force); > -#endif /* !NO_ULP_IN_S5_SUPPORT && !ULP_IN_D0_SUPPORT */ > STATIC s32 e1000_setup_copper_link_pch_lpt(struct e1000_hw *hw); > STATIC s32 e1000_get_link_up_info_ich8lan(struct e1000_hw *hw, > u16 *speed, u16 *duplex); _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c index 7669630a5c03..e9fc5394ab28 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c @@ -103,9 +103,6 @@ STATIC s32 e1000_reset_hw_ich8lan(struct e1000_hw *hw); STATIC s32 e1000_init_hw_ich8lan(struct e1000_hw *hw); STATIC s32 e1000_setup_link_ich8lan(struct e1000_hw *hw); STATIC s32 e1000_setup_copper_link_ich8lan(struct e1000_hw *hw); -#if !defined(NO_ULP_IN_S5_SUPPORT) -STATIC s32 e1000_disable_ulp_lpt_lp(struct e1000_hw *hw, bool force); -#endif /* !NO_ULP_IN_S5_SUPPORT && !ULP_IN_D0_SUPPORT */ STATIC s32 e1000_setup_copper_link_pch_lpt(struct e1000_hw *hw); STATIC s32 e1000_get_link_up_info_ich8lan(struct e1000_hw *hw, u16 *speed, u16 *duplex);
Remove the forward declaration of e1000_disable_ulp_lpt_lp (), which is never defined anywhere in the code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 3 --- 1 file changed, 3 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel