| Message ID | 44679b726ca9fe45757ee8c70a869b9d2a8720f9.1552574299.git.crobinso@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests: qemuxml2argv: support optional arguments | expand |
On Thu, 2019-03-14 at 10:44 -0400, Cole Robinson wrote: > Signed-off-by: Cole Robinson <crobinso@redhat.com> > --- > tests/qemuxml2argvtest.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c > index 130ab29d6e..b555166e82 100644 > --- a/tests/qemuxml2argvtest.c > +++ b/tests/qemuxml2argvtest.c > @@ -832,6 +832,9 @@ mymain(void) > # define DO_TEST_CAPS_LATEST_PARSE_ERROR(name) \ > DO_TEST_CAPS_ARCH_LATEST_FULL(name, "x86_64", FLAG_EXPECT_PARSE_ERROR, 0) > > + > +/* All the following macros require an explicit QEMU_CAPS_* list > + * at the end of the argument list, or the NONE placeholder */ > # define DO_TEST_FULL(name, ...) \ > do { \ > static struct testInfo info = { \ The comment does actually not apply to DO_TEST_FULL(), which expects a series of ARG_* and corresponding arguments rather than a list of QEMU_CAPS_*, so you should move it one macro down - right before DO_TEST() - instead. Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 130ab29d6e..b555166e82 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -832,6 +832,9 @@ mymain(void) # define DO_TEST_CAPS_LATEST_PARSE_ERROR(name) \ DO_TEST_CAPS_ARCH_LATEST_FULL(name, "x86_64", FLAG_EXPECT_PARSE_ERROR, 0) + +/* All the following macros require an explicit QEMU_CAPS_* list + * at the end of the argument list, or the NONE placeholder */ # define DO_TEST_FULL(name, ...) \ do { \ static struct testInfo info = { \
Signed-off-by: Cole Robinson <crobinso@redhat.com> --- tests/qemuxml2argvtest.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list