diff mbox series

[Xen-devel] xen/drivers: char: Match #if DEBUG_TRACE_DUMP and #endif comment

Message ID 20190319231915.23634-1-julien.grall@arm.com
State New
Headers show
Series [Xen-devel] xen/drivers: char: Match #if DEBUG_TRACE_DUMP and #endif comment | expand

Commit Message

Julien Grall March 19, 2019, 11:19 p.m. UTC 
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
 xen/drivers/char/console.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Beulich March 20, 2019, 7:01 a.m. UTC | #1 
>>> Julien Grall <julien.grall@arm.com> 03/20/19 12:19 AM >>>
>--- a/xen/drivers/char/console.c
>+++ b/xen/drivers/char/console.c
>@@ -1320,7 +1320,7 @@ static int __init debugtrace_init(void)
>}
>__initcall(debugtrace_init);
 >
>-#endif /* !NDEBUG */
>+#endif /* !DEBUG_TRACE_DUMP */
 
 But it's CONFIG_DEBUG_TRACE now, isn't it? With this adjusted
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan
Julien Grall March 21, 2019, 6:44 p.m. UTC | #2 
Hi,

On 3/20/19 7:01 AM, Jan Beulich wrote:
>>>> Julien Grall <julien.grall@arm.com> 03/20/19 12:19 AM >>>
>> --- a/xen/drivers/char/console.c
>> +++ b/xen/drivers/char/console.c
>> @@ -1320,7 +1320,7 @@ static int __init debugtrace_init(void)
>> }
>> __initcall(debugtrace_init);
>   >
>> -#endif /* !NDEBUG */
>> +#endif /* !DEBUG_TRACE_DUMP */
>   
>   But it's CONFIG_DEBUG_TRACE now, isn't it? With this adjusted

Hmm yes. I wrote this patch a few weeks ago and didn't check properly 
staging.

> Acked-by: Jan Beulich <jbeulich@suse.com>

Thank you! I have updated the patch and committed.

Cheers,
diff mbox series

Patch

diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index f41b689847..61695d967e 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -1320,7 +1320,7 @@  static int __init debugtrace_init(void)
 }
 __initcall(debugtrace_init);
 
-#endif /* !NDEBUG */
+#endif /* !DEBUG_TRACE_DUMP */
 
 
 /*