| Message ID | 20190412102733.5154-1-mark.rutland@arm.com |
|---|---|
| State | Accepted |
| Commit | 40453c4f9bb6d166a56a102a8c51dd24b0801557 |
| Headers | show |
| Series | kcov: improve CONFIG_ARCH_HAS_KCOV help text | expand |
On Fri, Apr 12, 2019 at 12:27 PM Mark Rutland <mark.rutland@arm.com> wrote: > > The help text for CONFIG_ARCH_HAS_KCOV is stale, and describes the > feature as being enabled only for x86_64, when it is now enabled for > several architectures, including arm, arm64, powerpc, and s390. > > Let's remove that stale help text, and update it along the lines of hat > for ARCH_HAS_FORTIFY_SOURCE, better describing when an architecture > should select CONFIG_ARCH_HAS_KCOV. > > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Dmitry Vyukov <dvyukov@google.com> > Cc: Kees Cook <keescook@chromium.org> > --- > lib/Kconfig.debug | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 0d9e81779e37..00dbcdbc9a0d 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -753,9 +753,9 @@ endmenu # "Memory Debugging" > config ARCH_HAS_KCOV > bool > help > - KCOV does not have any arch-specific code, but currently it is enabled > - only for x86_64. KCOV requires testing on other archs, and most likely > - disabling of instrumentation for some early boot code. > + An architecture should select this when it can successfully > + build and run with CONFIG_KCOV. This typically requires > + disabling instrumentation for some early boot code. > > config CC_HAS_SANCOV_TRACE_PC > def_bool $(cc-option,-fsanitize-coverage=trace-pc) > -- > 2.11.0 Acked-by: Dmitry Vyukov <dvyukov@google.com>
On Fri, Apr 12, 2019 at 12:31:10PM +0200, Dmitry Vyukov wrote: > On Fri, Apr 12, 2019 at 12:27 PM Mark Rutland <mark.rutland@arm.com> wrote: > > > > The help text for CONFIG_ARCH_HAS_KCOV is stale, and describes the > > feature as being enabled only for x86_64, when it is now enabled for > > several architectures, including arm, arm64, powerpc, and s390. > > > > Let's remove that stale help text, and update it along the lines of hat > > for ARCH_HAS_FORTIFY_SOURCE, better describing when an architecture > > should select CONFIG_ARCH_HAS_KCOV. > > > > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > > Cc: Andrew Morton <akpm@linux-foundation.org> > > Cc: Dmitry Vyukov <dvyukov@google.com> > > Cc: Kees Cook <keescook@chromium.org> > > --- > > lib/Kconfig.debug | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 0d9e81779e37..00dbcdbc9a0d 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -753,9 +753,9 @@ endmenu # "Memory Debugging" > > config ARCH_HAS_KCOV > > bool > > help > > - KCOV does not have any arch-specific code, but currently it is enabled > > - only for x86_64. KCOV requires testing on other archs, and most likely > > - disabling of instrumentation for some early boot code. > > + An architecture should select this when it can successfully > > + build and run with CONFIG_KCOV. This typically requires > > + disabling instrumentation for some early boot code. > > > > config CC_HAS_SANCOV_TRACE_PC > > def_bool $(cc-option,-fsanitize-coverage=trace-pc) > > -- > > 2.11.0 > > > Acked-by: Dmitry Vyukov <dvyukov@google.com> Thanks! Andrew, are you happy to pick this up? Mark.
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 0d9e81779e37..00dbcdbc9a0d 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -753,9 +753,9 @@ endmenu # "Memory Debugging" config ARCH_HAS_KCOV bool help - KCOV does not have any arch-specific code, but currently it is enabled - only for x86_64. KCOV requires testing on other archs, and most likely - disabling of instrumentation for some early boot code. + An architecture should select this when it can successfully + build and run with CONFIG_KCOV. This typically requires + disabling instrumentation for some early boot code. config CC_HAS_SANCOV_TRACE_PC def_bool $(cc-option,-fsanitize-coverage=trace-pc)
The help text for CONFIG_ARCH_HAS_KCOV is stale, and describes the feature as being enabled only for x86_64, when it is now enabled for several architectures, including arm, arm64, powerpc, and s390. Let's remove that stale help text, and update it along the lines of hat for ARCH_HAS_FORTIFY_SOURCE, better describing when an architecture should select CONFIG_ARCH_HAS_KCOV. Signed-off-by: Mark Rutland <mark.rutland@arm.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Dmitry Vyukov <dvyukov@google.com> Cc: Kees Cook <keescook@chromium.org> --- lib/Kconfig.debug | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.11.0