| Message ID | 20190424013802.27569-1-leo.yan@linaro.org |
|---|---|
| State | Accepted |
| Commit | 5f05182fab9a29fea6c4ab8113be45adf0c11bf0 |
| Headers | show |
| Series | tools lib traceevent: Change tag string for error | expand |
On Wed, 24 Apr 2019 09:38:02 +0800 Leo Yan <leo.yan@linaro.org> wrote: > The traceevnt lib is used by perf tool, when execute 'perf test -v 6' it > outputs error log on ARM64 platform: > > running test 33 '*:*'trace-cmd: No such file or directory > > [...] > > trace-cmd: Invalid argument > > The trace event parsing code originally came from trace-cmd so it keeps > the tag string "trace-cmd" for errors, this easily introduces the > impression that perf tool launches trace-cmd command for trace event > parsing, but in fact the related parsing is accomplished by traceevent > lib. > > This patch changes the tag string to "libtraceevent" so can avoid > confusion and let users to be more easily to connect the error with > traceevent lib. > > Signed-off-by: Leo Yan <leo.yan@linaro.org> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Arnaldo, Can you pull this into your tree. -- Steve > --- > tools/lib/traceevent/parse-utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/traceevent/parse-utils.c b/tools/lib/traceevent/parse-utils.c > index 77e4ec6402dd..e99867111387 100644 > --- a/tools/lib/traceevent/parse-utils.c > +++ b/tools/lib/traceevent/parse-utils.c > @@ -14,7 +14,7 @@ > void __vwarning(const char *fmt, va_list ap) > { > if (errno) > - perror("trace-cmd"); > + perror("libtraceevent"); > errno = 0; > > fprintf(stderr, " ");
Em Wed, Apr 24, 2019 at 08:08:29AM -0400, Steven Rostedt escreveu: > On Wed, 24 Apr 2019 09:38:02 +0800 > Leo Yan <leo.yan@linaro.org> wrote: > > > The traceevnt lib is used by perf tool, when execute 'perf test -v 6' it > > outputs error log on ARM64 platform: > > > > running test 33 '*:*'trace-cmd: No such file or directory > > > > [...] > > > > trace-cmd: Invalid argument > > > > The trace event parsing code originally came from trace-cmd so it keeps > > the tag string "trace-cmd" for errors, this easily introduces the > > impression that perf tool launches trace-cmd command for trace event > > parsing, but in fact the related parsing is accomplished by traceevent > > lib. > > > > This patch changes the tag string to "libtraceevent" so can avoid > > confusion and let users to be more easily to connect the error with > > traceevent lib. > > > > Signed-off-by: Leo Yan <leo.yan@linaro.org> > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > > Arnaldo, > > Can you pull this into your tree. Sure, applied. - Arnaldo
On Wed, Apr 24, 2019 at 09:44:27AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 24, 2019 at 08:08:29AM -0400, Steven Rostedt escreveu: > > On Wed, 24 Apr 2019 09:38:02 +0800 > > Leo Yan <leo.yan@linaro.org> wrote: > > > > > The traceevnt lib is used by perf tool, when execute 'perf test -v 6' it > > > outputs error log on ARM64 platform: > > > > > > running test 33 '*:*'trace-cmd: No such file or directory > > > > > > [...] > > > > > > trace-cmd: Invalid argument > > > > > > The trace event parsing code originally came from trace-cmd so it keeps > > > the tag string "trace-cmd" for errors, this easily introduces the > > > impression that perf tool launches trace-cmd command for trace event > > > parsing, but in fact the related parsing is accomplished by traceevent > > > lib. > > > > > > This patch changes the tag string to "libtraceevent" so can avoid > > > confusion and let users to be more easily to connect the error with > > > traceevent lib. > > > > > > Signed-off-by: Leo Yan <leo.yan@linaro.org> > > > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > > > > Arnaldo, > > > > Can you pull this into your tree. > > Sure, applied. Thanks, Steven and Arnaldo.
diff --git a/tools/lib/traceevent/parse-utils.c b/tools/lib/traceevent/parse-utils.c index 77e4ec6402dd..e99867111387 100644 --- a/tools/lib/traceevent/parse-utils.c +++ b/tools/lib/traceevent/parse-utils.c @@ -14,7 +14,7 @@ void __vwarning(const char *fmt, va_list ap) { if (errno) - perror("trace-cmd"); + perror("libtraceevent"); errno = 0; fprintf(stderr, " ");
The traceevnt lib is used by perf tool, when execute 'perf test -v 6' it outputs error log on ARM64 platform: running test 33 '*:*'trace-cmd: No such file or directory [...] trace-cmd: Invalid argument The trace event parsing code originally came from trace-cmd so it keeps the tag string "trace-cmd" for errors, this easily introduces the impression that perf tool launches trace-cmd command for trace event parsing, but in fact the related parsing is accomplished by traceevent lib. This patch changes the tag string to "libtraceevent" so can avoid confusion and let users to be more easily to connect the error with traceevent lib. Signed-off-by: Leo Yan <leo.yan@linaro.org> --- tools/lib/traceevent/parse-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1