| Message ID | 20190423204821.241925-1-ndesaulniers@google.com |
|---|---|
| State | Accepted |
| Commit | 861fde319134d4aaaa94ac6d976e4d8a329ab889 |
| Headers | show |
| Series | ia64: require -Wl,--hash-style=sysv | expand |
On Tue, Apr 23, 2019 at 1:48 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > > Towards the goal of removing cc-ldoption, it seems that --hash-style= > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > of binutils for the kernel according to > Documentation/process/changes.rst is 2.20. > > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html > Cc: clang-built-linux@googlegroups.com > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- > arch/ia64/kernel/Makefile.gate | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/ia64/kernel/Makefile.gate b/arch/ia64/kernel/Makefile.gate > index f53faf48b7ce..846867bff6d6 100644 > --- a/arch/ia64/kernel/Makefile.gate > +++ b/arch/ia64/kernel/Makefile.gate > @@ -11,7 +11,7 @@ quiet_cmd_gate = GATE $@ > cmd_gate = $(CC) -nostdlib $(GATECFLAGS_$(@F)) -Wl,-T,$(filter-out FORCE,$^) -o $@ > > GATECFLAGS_gate.so = -shared -s -Wl,-soname=linux-gate.so.1 \ > - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > + -Wl,--hash-style=sysv > $(obj)/gate.so: $(obj)/gate.lds $(obj)/gate.o FORCE > $(call if_changed,gate) > > -- > 2.21.0.593.g511ec345e18-goog > bumping for review -- Thanks, ~Nick Desaulniers
bumping for review, as the merge window is now open. On Tue, Apr 30, 2019 at 1:24 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > > On Tue, Apr 23, 2019 at 1:48 PM Nick Desaulniers > <ndesaulniers@google.com> wrote: > > > > Towards the goal of removing cc-ldoption, it seems that --hash-style= > > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > > of binutils for the kernel according to > > Documentation/process/changes.rst is 2.20. > > > > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html > > Cc: clang-built-linux@googlegroups.com > > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > > --- > > arch/ia64/kernel/Makefile.gate | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/ia64/kernel/Makefile.gate b/arch/ia64/kernel/Makefile.gate > > index f53faf48b7ce..846867bff6d6 100644 > > --- a/arch/ia64/kernel/Makefile.gate > > +++ b/arch/ia64/kernel/Makefile.gate > > @@ -11,7 +11,7 @@ quiet_cmd_gate = GATE $@ > > cmd_gate = $(CC) -nostdlib $(GATECFLAGS_$(@F)) -Wl,-T,$(filter-out FORCE,$^) -o $@ > > > > GATECFLAGS_gate.so = -shared -s -Wl,-soname=linux-gate.so.1 \ > > - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > > + -Wl,--hash-style=sysv > > $(obj)/gate.so: $(obj)/gate.lds $(obj)/gate.o FORCE > > $(call if_changed,gate) > > > > -- > > 2.21.0.593.g511ec345e18-goog > > > > bumping for review > > -- > Thanks, > ~Nick Desaulniers -- Thanks, ~Nick Desaulniers
On Thu, May 9, 2019 at 4:27 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > bumping for review, as the merge window is now open. ia64 is not very active these days. I applied this to my kbuild tree. I will send PR for this in the current MW. Thanks. > On Tue, Apr 30, 2019 at 1:24 PM Nick Desaulniers > <ndesaulniers@google.com> wrote: > > > > On Tue, Apr 23, 2019 at 1:48 PM Nick Desaulniers > > <ndesaulniers@google.com> wrote: > > > > > > Towards the goal of removing cc-ldoption, it seems that --hash-style= > > > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > > > of binutils for the kernel according to > > > Documentation/process/changes.rst is 2.20. > > > > > > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html > > > Cc: clang-built-linux@googlegroups.com > > > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > > > --- > > > arch/ia64/kernel/Makefile.gate | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/ia64/kernel/Makefile.gate b/arch/ia64/kernel/Makefile.gate > > > index f53faf48b7ce..846867bff6d6 100644 > > > --- a/arch/ia64/kernel/Makefile.gate > > > +++ b/arch/ia64/kernel/Makefile.gate > > > @@ -11,7 +11,7 @@ quiet_cmd_gate = GATE $@ > > > cmd_gate = $(CC) -nostdlib $(GATECFLAGS_$(@F)) -Wl,-T,$(filter-out FORCE,$^) -o $@ > > > > > > GATECFLAGS_gate.so = -shared -s -Wl,-soname=linux-gate.so.1 \ > > > - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > > > + -Wl,--hash-style=sysv > > > $(obj)/gate.so: $(obj)/gate.lds $(obj)/gate.o FORCE > > > $(call if_changed,gate) > > > > > > -- > > > 2.21.0.593.g511ec345e18-goog > > > > > > > bumping for review > > > > -- > > Thanks, > > ~Nick Desaulniers > > > > -- > Thanks, > ~Nick Desaulniers -- Best Regards Masahiro Yamada
diff --git a/arch/ia64/kernel/Makefile.gate b/arch/ia64/kernel/Makefile.gate index f53faf48b7ce..846867bff6d6 100644 --- a/arch/ia64/kernel/Makefile.gate +++ b/arch/ia64/kernel/Makefile.gate @@ -11,7 +11,7 @@ quiet_cmd_gate = GATE $@ cmd_gate = $(CC) -nostdlib $(GATECFLAGS_$(@F)) -Wl,-T,$(filter-out FORCE,$^) -o $@ GATECFLAGS_gate.so = -shared -s -Wl,-soname=linux-gate.so.1 \ - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) + -Wl,--hash-style=sysv $(obj)/gate.so: $(obj)/gate.lds $(obj)/gate.o FORCE $(call if_changed,gate)
Towards the goal of removing cc-ldoption, it seems that --hash-style= was added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to Documentation/process/changes.rst is 2.20. Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html Cc: clang-built-linux@googlegroups.com Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- arch/ia64/kernel/Makefile.gate | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.21.0.593.g511ec345e18-goog