diff mbox series

m68k: coldfire: Include the GPIO driver header

Message ID 20190821070923.687-1-linus.walleij@linaro.org
State Accepted
Commit 372ea263b3d9cdeb70f8cffa025b2e0875e51b62
Headers show
Series m68k: coldfire: Include the GPIO driver header | expand

Commit Message

Linus Walleij Aug. 21, 2019, 7:09 a.m. UTC
The Coldfire GPIO driver needs to explicitly incldue the
GPIO driver header since it is providing a driver.

Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
Geert can you pick this up for m68k?
---
 arch/m68k/coldfire/gpio.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.21.0

Comments

Geert Uytterhoeven Aug. 21, 2019, 7:19 a.m. UTC | #1
CC Greg (coldfire)

On Wed, Aug 21, 2019 at 9:09 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> The Coldfire GPIO driver needs to explicitly incldue the

> GPIO driver header since it is providing a driver.

>

> Cc: Geert Uytterhoeven <geert@linux-m68k.org>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---

> Geert can you pick this up for m68k?

> ---

>  arch/m68k/coldfire/gpio.c | 1 +

>  1 file changed, 1 insertion(+)

>

> diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c

> index a83898426127..ca26de257871 100644

> --- a/arch/m68k/coldfire/gpio.c

> +++ b/arch/m68k/coldfire/gpio.c

> @@ -9,6 +9,7 @@

>  #include <linux/module.h>

>  #include <linux/init.h>

>  #include <linux/device.h>

> +#include <linux/gpio/driver.h>

>

>  #include <linux/io.h>

>  #include <asm/coldfire.h>

> --

> 2.21.0
Greg Ungerer Aug. 21, 2019, 12:22 p.m. UTC | #2
On 21/8/19 5:19 pm, Geert Uytterhoeven wrote:
> CC Greg (coldfire)


Thanks Geert.
I am happy to take it via the m68knommu tree if you prefer?

Regards
Greg



> On Wed, Aug 21, 2019 at 9:09 AM Linus Walleij <linus.walleij@linaro.org> wrote:

>> The Coldfire GPIO driver needs to explicitly incldue the

>> GPIO driver header since it is providing a driver.

>>

>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>

>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

>> ---

>> Geert can you pick this up for m68k?

>> ---

>>   arch/m68k/coldfire/gpio.c | 1 +

>>   1 file changed, 1 insertion(+)

>>

>> diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c

>> index a83898426127..ca26de257871 100644

>> --- a/arch/m68k/coldfire/gpio.c

>> +++ b/arch/m68k/coldfire/gpio.c

>> @@ -9,6 +9,7 @@

>>   #include <linux/module.h>

>>   #include <linux/init.h>

>>   #include <linux/device.h>

>> +#include <linux/gpio/driver.h>

>>

>>   #include <linux/io.h>

>>   #include <asm/coldfire.h>

>> --

>> 2.21.0

>
Geert Uytterhoeven Aug. 21, 2019, 12:50 p.m. UTC | #3
Hi Greg,

On Wed, Aug 21, 2019 at 2:22 PM Greg Ungerer <gerg@linux-m68k.org> wrote:
> On 21/8/19 5:19 pm, Geert Uytterhoeven wrote:

> > CC Greg (coldfire)

>

> Thanks Geert.

> I am happy to take it via the m68knommu tree if you prefer?


Sounds most logical to me.
Thanks!

> > On Wed, Aug 21, 2019 at 9:09 AM Linus Walleij <linus.walleij@linaro.org> wrote:

> >> The Coldfire GPIO driver needs to explicitly incldue the

> >> GPIO driver header since it is providing a driver.

> >>

> >> Cc: Geert Uytterhoeven <geert@linux-m68k.org>

> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> >> ---

> >> Geert can you pick this up for m68k?

> >> ---

> >>   arch/m68k/coldfire/gpio.c | 1 +

> >>   1 file changed, 1 insertion(+)

> >>

> >> diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c

> >> index a83898426127..ca26de257871 100644

> >> --- a/arch/m68k/coldfire/gpio.c

> >> +++ b/arch/m68k/coldfire/gpio.c

> >> @@ -9,6 +9,7 @@

> >>   #include <linux/module.h>

> >>   #include <linux/init.h>

> >>   #include <linux/device.h>

> >> +#include <linux/gpio/driver.h>

> >>

> >>   #include <linux/io.h>

> >>   #include <asm/coldfire.h>


Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Greg Ungerer Aug. 22, 2019, 12:50 a.m. UTC | #4
Hi Geert, Linus,

On 21/8/19 10:50 pm, Geert Uytterhoeven wrote:
> On Wed, Aug 21, 2019 at 2:22 PM Greg Ungerer <gerg@linux-m68k.org> wrote:

>> On 21/8/19 5:19 pm, Geert Uytterhoeven wrote:

>>> CC Greg (coldfire)

>>

>> Thanks Geert.

>> I am happy to take it via the m68knommu tree if you prefer?

> 

> Sounds most logical to me.

> Thanks!


Pushed to the for-next branch of the m68knommu git tree.

Regards
Greg



>>> On Wed, Aug 21, 2019 at 9:09 AM Linus Walleij <linus.walleij@linaro.org> wrote:

>>>> The Coldfire GPIO driver needs to explicitly incldue the

>>>> GPIO driver header since it is providing a driver.

>>>>

>>>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>

>>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

>>>> ---

>>>> Geert can you pick this up for m68k?

>>>> ---

>>>>    arch/m68k/coldfire/gpio.c | 1 +

>>>>    1 file changed, 1 insertion(+)

>>>>

>>>> diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c

>>>> index a83898426127..ca26de257871 100644

>>>> --- a/arch/m68k/coldfire/gpio.c

>>>> +++ b/arch/m68k/coldfire/gpio.c

>>>> @@ -9,6 +9,7 @@

>>>>    #include <linux/module.h>

>>>>    #include <linux/init.h>

>>>>    #include <linux/device.h>

>>>> +#include <linux/gpio/driver.h>

>>>>

>>>>    #include <linux/io.h>

>>>>    #include <asm/coldfire.h>

> 

> Gr{oetje,eeting}s,

> 

>                          Geert

>
diff mbox series

Patch

diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c
index a83898426127..ca26de257871 100644
--- a/arch/m68k/coldfire/gpio.c
+++ b/arch/m68k/coldfire/gpio.c
@@ -9,6 +9,7 @@ 
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/device.h>
+#include <linux/gpio/driver.h>
 
 #include <linux/io.h>
 #include <asm/coldfire.h>