diff mbox series

[rt-tests,v1,v1,3/4] svsematest: Increase buffer to avoid overflow

Message ID 20190819064304.4676-4-wagi@monom.org
State New
Headers show
Series Fix gcc warning | expand

Commit Message

Daniel Wagner Aug. 19, 2019, 6:43 a.m. UTC
Increase the size of the char buffer. gcc 9.1.1 reports:

rc/svsematest/svsematest.c:578:24: warning: ‘%d’ directive writing between 1 and 10 bytes into a region of size 5 [-Wformat-overflow=]
  578 |     sprintf(f_opt, "-fr%d", i);
      |                        ^~
src/svsematest/svsematest.c:606:5: note: ‘sprintf’ output between 5 and 14 bytes into a destination of size 8
  606 |     sprintf(f_opt, "-fs%d", i);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Daniel Wagner <wagi@monom.org>

---
 src/svsematest/svsematest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.21.0

Comments

John Kacur Aug. 23, 2019, 3:19 p.m. UTC | #1
On Mon, 19 Aug 2019, Daniel Wagner wrote:

> Increase the size of the char buffer. gcc 9.1.1 reports:

> 

> rc/svsematest/svsematest.c:578:24: warning: ‘%d’ directive writing between 1 and 10 bytes into a region of size 5 [-Wformat-overflow=]

>   578 |     sprintf(f_opt, "-fr%d", i);

>       |                        ^~

> src/svsematest/svsematest.c:606:5: note: ‘sprintf’ output between 5 and 14 bytes into a destination of size 8

>   606 |     sprintf(f_opt, "-fs%d", i);

>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~

> 

> Signed-off-by: Daniel Wagner <wagi@monom.org>

> ---

>  src/svsematest/svsematest.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/src/svsematest/svsematest.c b/src/svsematest/svsematest.c

> index 8f880786ec0f..15e36af76288 100644

> --- a/src/svsematest/svsematest.c

> +++ b/src/svsematest/svsematest.c

> @@ -401,7 +401,7 @@ int main(int argc, char *argv[])

>  	struct params *sender = NULL;

>  	sigset_t sigset;

>  	void *param = NULL;

> -	char f_opt[8];

> +	char f_opt[14];

>  	struct timespec launchdelay, maindelay;

>  

>  	myfile = getenv("_");

> -- 

> 2.21.0

> 

Signed-off-by: John Kacur <jkacur@redhat.com>
diff mbox series

Patch

diff --git a/src/svsematest/svsematest.c b/src/svsematest/svsematest.c
index 8f880786ec0f..15e36af76288 100644
--- a/src/svsematest/svsematest.c
+++ b/src/svsematest/svsematest.c
@@ -401,7 +401,7 @@  int main(int argc, char *argv[])
 	struct params *sender = NULL;
 	sigset_t sigset;
 	void *param = NULL;
-	char f_opt[8];
+	char f_opt[14];
 	struct timespec launchdelay, maindelay;
 
 	myfile = getenv("_");