| Message ID | 20190924115243.25702-1-m.szyprowski@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: exynos: Add missing clock-cells property to Exynos3250 i2s node | expand |
On Tue, Sep 24, 2019 at 01:52:43PM +0200, Marek Szyprowski wrote: > From: Maciej Falkowski <m.falkowski@samsung.com> > > '#clock-cells' is a required property for clocks provider, missing > may cause compilation errors. This needs to be explained better. What compilation errors did you see (or expect)? As of now, there is no clock consumer for i2s clocks. After adding clock-cells, the driver will register/provide its clocks, so you add quite visible change without mentioning the effects in change log. Best regards, Krzysztof > > Signed-off-by: Maciej Falkowski <m.falkowski@samsung.com> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm/boot/dts/exynos3250.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 190d9160a5d1..bf32e00334ce 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -687,6 +687,7 @@ > interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; > clock-names = "iis", "i2s_opclk0"; > + #clock-cells = <1>; > dmas = <&pdma0 14>, <&pdma0 13>; > dma-names = "tx", "rx"; > pinctrl-0 = <&i2s2_bus>; > -- > 2.17.1 > > >
On 9/24/19 1:58 PM, Krzysztof Kozlowski wrote: > On Tue, Sep 24, 2019 at 01:52:43PM +0200, Marek Szyprowski wrote: >> From: Maciej Falkowski <m.falkowski@samsung.com> >> >> '#clock-cells' is a required property for clocks provider, missing >> may cause compilation errors. > This needs to be explained better. What compilation errors did you see > (or expect)? As of now, there is no clock consumer for i2s clocks. > > After adding clock-cells, the driver will register/provide its clocks, > so you add quite visible change without mentioning the effects in change > log. > > Best regards, > Krzysztof Hi Krzysztof, I wrongly interpreted that #clock-cells property is required and in result it may cause schema compilation errors if this property would be required there. As it is optional and here unintended, the patch does not make any sense. Best regards, Maciej Falkowski >> Signed-off-by: Maciej Falkowski <m.falkowski@samsung.com> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >> index 190d9160a5d1..bf32e00334ce 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -687,6 +687,7 @@ >> interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>; >> clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; >> clock-names = "iis", "i2s_opclk0"; >> + #clock-cells = <1>; >> dmas = <&pdma0 14>, <&pdma0 13>; >> dma-names = "tx", "rx"; >> pinctrl-0 = <&i2s2_bus>; >> -- >> 2.17.1 >> >> >> >
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 190d9160a5d1..bf32e00334ce 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -687,6 +687,7 @@ interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; clock-names = "iis", "i2s_opclk0"; + #clock-cells = <1>; dmas = <&pdma0 14>, <&pdma0 13>; dma-names = "tx", "rx"; pinctrl-0 = <&i2s2_bus>;