diff mbox series

[4.19,3/3] ocfs2: remove ocfs2_is_o2cb_active()

Message ID 20191126134741.12629-3-lee.jones@linaro.org
State Superseded
Headers show
Series [4.19,1/3] ARM: 8904/1: skip nomap memblocks while finding the lowmem/highmem boundary | expand

Commit Message

Lee Jones Nov. 26, 2019, 1:47 p.m. UTC 
From: Gang He <ghe@suse.com>


[ Upstream commit 9d452c602f0558ec3b0aeab1040bdf4dfbc590eb ]

Remove ocfs2_is_o2cb_active().  We have similar functions to identify
which cluster stack is being used via osb->osb_cluster_stack.

Secondly, the current implementation of ocfs2_is_o2cb_active() is not
totally safe.  Based on the design of stackglue, we need to get
ocfs2_stack_lock before using ocfs2_stack related data structures, and
that active_stack pointer can be NULL in the case of mount failure.

Link: http://lkml.kernel.org/r/1495441079-11708-1-git-send-email-ghe@suse.com
Signed-off-by: Gang He <ghe@suse.com>

Reviewed-by: Joseph Qi <jiangqi903@gmail.com>

Reviewed-by: Eric Ren <zren@suse.com>

Acked-by: Changwei Ge <ge.changwei@h3c.com>

Cc: Mark Fasheh <mark@fasheh.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 fs/ocfs2/dlmglue.c   | 2 +-
 fs/ocfs2/stackglue.c | 6 ------
 fs/ocfs2/stackglue.h | 3 ---
 3 files changed, 1 insertion(+), 10 deletions(-)

-- 
2.24.0

Comments

Greg KH Nov. 26, 2019, 4:24 p.m. UTC | #1 
On Tue, Nov 26, 2019 at 01:47:41PM +0000, Lee Jones wrote:
> From: Gang He <ghe@suse.com>

> 

> [ Upstream commit 9d452c602f0558ec3b0aeab1040bdf4dfbc590eb ]


That's not a valid git commit id in Linus's tree :(

These series are a mess.  Can you redo them all and resend them so that
I can apply them, and so I know what branch to apply them to?  :)

I'm dropping them all from my review queue now.

thanks,

greg k-h
Lee Jones Nov. 26, 2019, 4:28 p.m. UTC | #2 
On Tue, 26 Nov 2019, Greg KH wrote:

> On Tue, Nov 26, 2019 at 01:47:41PM +0000, Lee Jones wrote:

> > From: Gang He <ghe@suse.com>

> > 

> > [ Upstream commit 9d452c602f0558ec3b0aeab1040bdf4dfbc590eb ]

> 

> That's not a valid git commit id in Linus's tree :(


That's odd. I'll check my scripts.

They are new and you are the victim of the first run!

> These series are a mess.  Can you redo them all and resend them so that

> I can apply them, and so I know what branch to apply them to?  :)


I can do that.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
diff mbox series

Patch

diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index 933aac5da193..178cb9e6772a 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -3603,7 +3603,7 @@  static int ocfs2_downconvert_lock(struct ocfs2_super *osb,
 	 * we can recover correctly from node failure. Otherwise, we may get
 	 * invalid LVB in LKB, but without DLM_SBF_VALNOTVALID being set.
 	 */
-	if (!ocfs2_is_o2cb_active() &&
+	if (ocfs2_userspace_stack(osb) &&
 	    lockres->l_ops->flags & LOCK_TYPE_USES_LVB)
 		lvb = 1;
 
diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
index d6c350ba25b9..c4b029c43464 100644
--- a/fs/ocfs2/stackglue.c
+++ b/fs/ocfs2/stackglue.c
@@ -48,12 +48,6 @@  static char ocfs2_hb_ctl_path[OCFS2_MAX_HB_CTL_PATH] = "/sbin/ocfs2_hb_ctl";
  */
 static struct ocfs2_stack_plugin *active_stack;
 
-inline int ocfs2_is_o2cb_active(void)
-{
-	return !strcmp(active_stack->sp_name, OCFS2_STACK_PLUGIN_O2CB);
-}
-EXPORT_SYMBOL_GPL(ocfs2_is_o2cb_active);
-
 static struct ocfs2_stack_plugin *ocfs2_stack_lookup(const char *name)
 {
 	struct ocfs2_stack_plugin *p;
diff --git a/fs/ocfs2/stackglue.h b/fs/ocfs2/stackglue.h
index e3036e1790e8..f2dce10fae54 100644
--- a/fs/ocfs2/stackglue.h
+++ b/fs/ocfs2/stackglue.h
@@ -298,9 +298,6 @@  void ocfs2_stack_glue_set_max_proto_version(struct ocfs2_protocol_version *max_p
 int ocfs2_stack_glue_register(struct ocfs2_stack_plugin *plugin);
 void ocfs2_stack_glue_unregister(struct ocfs2_stack_plugin *plugin);
 
-/* In ocfs2_downconvert_lock(), we need to know which stack we are using */
-int ocfs2_is_o2cb_active(void);
-
 extern struct kset *ocfs2_kset;
 
 #endif  /* STACKGLUE_H */